Skip to contentSkip to conversation

mxser: make an experimental clone

PATCH Andrew Morton 2 participants 2 messages Sep 20, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 11 lines · On Wed, 20 Sep 2006 16:06:55 +0200 (CEST) Jiri Slaby <[email protected]>…
Quoted 6 lines · Andrew Morton

Ho hum, this is hard. I guess breaking the driver is one way to find out who is using it, but those who redistribute the kernel for a living might not appreciate the technique.

Perhaps we could create an mxser-new.c and offer that in config, plan to remove mxser.c N months hence?

Ok, here's a patch doing this. When you apply it, drop mxser-upgrade-to-191.patch, please, to get back unmodified version.

It was, umm, naive to assume that was the only outstanding patch against mxser.c. I had four patches. One wasn't actually in use and one I just dropped, so we now have serial-fix-up-offenders-peering-at-baud-bits-directly.patch and const-struct-tty_operations.patch.

Quoted 6 lines

mxser: clone a new driver

Clone a new driver for moxa smartio devices. It contains update to version 1.9.1 from Moxa site and static to dynamic structures (including some renaming) conversion for further work -- converting to pci probing.

That wasn't a good way to do this. It would have been (much) better to have one patch which copies mxser.c to mxser_new.c and *nothing else*. Then, new patches which update mxser_new.c.

So I have converted your patch into one which simply copies mxser.[ch] to mxser_new.[ch] and which makes no other changes. The versions which were copied were those _after_ the two pending patches were applied. Please send updates against those new files, thanks.

#2 lore raw
Quoted 14 lines · Andrew Morton
Quoted 10 lines · On Wed, 20 Sep 2006 16:06:55 +0200 (CEST) Jiri Slaby <[email protected]>…
Quoted 6 lines · Andrew Morton

Ho hum, this is hard. I guess breaking the driver is one way to find out who is using it, but those who redistribute the kernel for a living might not appreciate the technique.

Perhaps we could create an mxser-new.c and offer that in config, plan to remove mxser.c N months hence?

Ok, here's a patch doing this. When you apply it, drop mxser-upgrade-to-191.patch, please, to get back unmodified version.

Quoted 5 lines

It was, umm, naive to assume that was the only outstanding patch against mxser.c. I had four patches. One wasn't actually in use and one I just dropped, so we now have serial-fix-up-offenders-peering-at-baud-bits-directly.patch and const-struct-tty_operations.patch.

Aargh. Sorry for that, next time I'll make a revert- variant.

Quoted 6 lines
Quoted 5 lines

mxser: clone a new driver

Clone a new driver for moxa smartio devices. It contains update to version 1.9.1 from Moxa site and static to dynamic structures (including some renaming) conversion for further work -- converting to pci probing.

Quoted 7 lines

That wasn't a good way to do this. It would have been (much) better to
have one patch which copies mxser.c to mxser_new.c and *nothing else*. Then, new patches which update mxser_new.c.

So I have converted your patch into one which simply copies mxser.[ch] to mxser_new.[ch] and which makes no other changes. The versions which were copied were those _after_ the two pending patches were applied. Please send updates against those new files, thanks.

Ok, thank you,

Signature · 4 lines
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E