Skip to contentSkip to conversation

MODSIGN: Fix a compilation warning in extract-cert

PATCH In review David Howells 1 participant 2 messages Sep 8, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MODSIGN: Fix a compilation warning in extract-cert

Fix the following warning when compiling extract-cert:

scripts/extract-cert.c: In function ‘write_cert’:
scripts/extract-cert.c:89:2: warning: format not a string literal and no format arguments [-Wformat-security]
ERR(!i2d_X509_bio(wb, x509), cert_dst);
^

whereby the ERR() macro is taking cert_dst as the format string. "%s" should be used as the format string as the path could contain special characters.

---

 scripts/extract-cert.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/extract-cert.c +1 -1
index fd0db015c65c..10d23ca9f617 100644
@@ -86,7 +86,7 @@ static void write_cert(X509 *x509)
 		ERR(!wb, "%s", cert_dst);
 	}
 	X509_NAME_oneline(X509_get_subject_name(x509), buf, sizeof(buf));
-	ERR(!i2d_X509_bio(wb, x509), cert_dst);
+	ERR(!i2d_X509_bio(wb, x509), "%s", cert_dst);
 	if (kbuild_verbose)
 		fprintf(stderr, "Extracted cert: %s\n", buf);
 }