Add support for QE and 8360EMDS board -v2
cover Add support for QE and 8360EMDS board -v2
Paul,
The series of patches add generic QE infrastructure called qe_lib, and MPC8360EMDS board support. Qe_lib is used by QE device drivers such as ucc_geth driver.
This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
- Leo
Quoted 6 lines · Li Yang
Paul,
The series of patches add generic QE infrastructure called
qe_lib, and MPC8360EMDS board support.Qe_libis used by QE device drivers such asucc_gethdriver.
Quoted 7 lines
This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
Before accepting any of this code, I'd like to see what the drivers look like that are using it. Its hard to make significant comments w/o seeing what the consumers of all the 'lib' code look like.
- kumar
Quoted 13 lines · Kumar Gala
Quoted 10 lines · Li Yang
Paul,
The series of patches add generic QE infrastructure called
qe_lib, and MPC8360EMDS board support.Qe_libis used by QE device drivers such asucc_gethdriver.This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
Quoted 7 lines
Quoted 3 lines
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
Before accepting any of this code, I'd like to see what the drivers look like that are using it. Its hard to make significant comments w/
o seeing what the consumers of all the 'lib' code look like.
Current in-tree user of the lib is driver/net/ucc_geth.c. There is also QE ATM driver which is included in Alex's 8360sar project. QE USB host/client drivers are in Freescale LTIB BSP.
- Leo
Quoted 18 lines · Li Yang
Quoted 17 lines · Kumar Gala
Quoted 13 lines · Li Yang
Paul,
The series of patches add generic QE infrastructure called
qe_lib, and MPC8360EMDS board support.Qe_libis used by QE device drivers such asucc_gethdriver.This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
Quoted 7 lines
Quoted 3 lines
Before accepting any of this code, I'd like to see what the drivers look like that are using it. Its hard to make significant comments w/
o seeing what the consumers of all the 'lib' code look like.Current in-tree user of the lib is
driver/net/ucc_geth.c. There is also QE ATM driver which is included in Alex's 8360sar project. QE USB host/client drivers are in Freescale LTIB BSP.
is there a serial driver?
- k
Quoted 33 lines
-----Original Message-----
From: Kumar Gala [mailto:[email protected]]
Sent: Friday, September 29, 2006 12:37 AM
To: Li Yang-r58472
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/12] Add support for QE and 8360EMDS board -v2 =20
=20
On Sep 28, 2006, at 11:09 AM, Li Yang wrote:
=20Quoted 23 lines · Kumar Gala
Quoted 21 lines · Li Yang
Quoted 7 lines
Paul,
The series of patches add generic QE infrastructure called
qe_lib, and MPC8360EMDS board support.Qe_libis used by QE device drivers such asucc_gethdriver.Quoted 7 lines
This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
Before accepting any of this code, I'd like to see what the drivers look like that are using it. Its hard to make significant comments w/
o seeing what the consumers of all the 'lib' code look like.
Quoted 5 lines
Quoted 3 lines
Current in-tree user of the lib is
driver/net/ucc_geth.c. There is also QE ATM driver which is included in Alex's 8360sar project. QE USB host/client drivers are in Freescale LTIB BSP.=20
is there a serial driver?
No. It is not very necessary to have serial support for QE, as there is separate DUART SoC. We can use 8250 serial driver for that.
- Leo
Quoted 33 lines · On Fri, 29 Sep 2006 11:21:44 +0800 "Li Yang-r58472" <[email protected]> wrote:
Quoted 33 lines
-----Original Message-----
From: Kumar Gala [mailto:[email protected]]
Sent: Friday, September 29, 2006 12:37 AM
To: Li Yang-r58472
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/12] Add support for QE and 8360EMDS board -v2Quoted 23 lines · Li Yang
Quoted 21 lines · Kumar Gala
Quoted 6 lines · Li Yang
Paul,
The series of patches add generic QE infrastructure called
qe_lib, and MPC8360EMDS board support.Qe_libis used by QE device drivers such asucc_gethdriver.Quoted 7 lines
This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
Before accepting any of this code, I'd like to see what the drivers look like that are using it. Its hard to make significant comments w/
o seeing what the consumers of all the 'lib' code look like.
Quoted 10 lines
Quoted 5 lines
Quoted 3 lines
Current in-tree user of the lib is
driver/net/ucc_geth.c. There is also QE ATM driver which is included in Alex's 8360sar project. QE USB host/client drivers are in Freescale LTIB BSP.is there a serial driver?
No. It is not very necessary to have serial support for QE, as there is separate DUART SoC. We can use 8250 serial driver for that.
Leo,
the question was if ucc_slow.{c,h} have its applications so far. I think the answer is no, for the kernel at least.
Signature · 2 lines
Sincerely, Vitaly
Quoted 33 lines · On Sep 28, 2006, at 10:21 PM, Li Yang-r58472 wrote:
Quoted 33 lines
-----Original Message-----
From: Kumar Gala [mailto:[email protected]]
Sent: Friday, September 29, 2006 12:37 AM
To: Li Yang-r58472
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/12] Add support for QE and 8360EMDS board -v2Quoted 23 lines · Li Yang
Quoted 21 lines · Kumar Gala
Quoted 6 lines · Li Yang
Paul,
The series of patches add generic QE infrastructure called
qe_lib, and MPC8360EMDS board support.Qe_libis used by QE device drivers such asucc_gethdriver.Quoted 7 lines
This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
Before accepting any of this code, I'd like to see what the drivers look like that are using it. Its hard to make significant comments w/
o seeing what the consumers of all the 'lib' code look like.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Current in-tree user of the lib is
driver/net/ucc_geth.c. There is also QE ATM driver which is included in Alex's 8360sar project. QE USB host/client drivers are in Freescale LTIB BSP.is there a serial driver?
No. It is not very necessary to have serial support for QE, as there is separate DUART SoC. We can use 8250 serial driver for that.
Are there any examples of drivers for a UCC slow channel?
- k
Quoted 40 lines · Kumar Gala
Quoted 37 lines · On Sep 28, 2006, at 10:21 PM, Li Yang-r58472 wrote:
Quoted 37 lines
-----Original Message-----
From: Kumar Gala [mailto:[email protected]]
Sent: Friday, September 29, 2006 12:37 AM
To: Li Yang-r58472
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/12] Add support for QE and 8360EMDS board -v2Quoted 26 lines · Li Yang
Quoted 13 lines · Kumar Gala
Quoted 10 lines · Li Yang
Paul,
The series of patches add generic QE infrastructure called
qe_lib, and MPC8360EMDS board support.Qe_libis used by QE device drivers such asucc_gethdriver.This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
Quoted 8 lines
Quoted 3 lines
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
Before accepting any of this code, I'd like to see what the drivers look like that are using it. Its hard to make significant comments w/
o seeing what the consumers of all the 'lib' code look like.Current in-tree user of the lib is
driver/net/ucc_geth.c. There is also QE ATM driver which is included in Alex's 8360sar project. QE USB host/client drivers are in Freescale LTIB BSP.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
is there a serial driver?
No. It is not very necessary to have serial support for QE, as there is
separate DUART SoC. We can use 8250 serial driver for that.Are there any examples of drivers for a UCC slow channel?
No, at present.
Quoted 18 lines · On Fri, 29 Sep 2006 00:09:14 +0800 "Li Yang" <[email protected]> wrote:
Quoted 17 lines · Kumar Gala
Quoted 13 lines · Li Yang
Paul,
The series of patches add generic QE infrastructure called
qe_lib, and MPC8360EMDS board support.Qe_libis used by QE device drivers such asucc_gethdriver.This version updates QE interrupt controller to use new irq mapping mechanism, addresses all the comments received with last submission and includes some style fixes.
v2 change: Change to use device tree for BCSR and MURAM; Remove I/O port interrupt handling code as it is not generic enough.
Quoted 8 lines
Quoted 3 lines
Before accepting any of this code, I'd like to see what the drivers look like that are using it. Its hard to make significant comments w/
o seeing what the consumers of all the 'lib' code look like.Current in-tree user of the lib is
driver/net/ucc_geth.c. There is also QE ATM driver which is included in Alex's 8360sar project. QE USB host/client drivers are in Freescale LTIB BSP.
The point is we are following the way a bit opposite then normal - usually a bunch of similar stuff is wrapped into a library, and here we've made a library and trying to fit all the upcoming into.
I'd suggest to look at it as "add new soc family" approach, not more. OTOH, I am expecting it to become sort of versatile lib some time later...
Kumar,
no serial driver I'm aware of..
Signature · 2 lines
Sincerely, Vitaly