Skip to contentSkip to conversation

platform/x86: toshiba_acpi: Silence logging for some events

PATCH In review Hans de Goede 2 participants 6 messages Apr 2, 2024 – Apr 8, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: toshiba_acpi: Silence logging for some events

Stop logging unknown event / unknown keycode messages on suspend / resume on a Toshiba Portege Z830:

1. The Toshiba Portege Z830 sends a 0x8e event when the power button is pressed, ignore this.

2. The Toshiba Portege Z830 sends a 0xe00 hotkey event on resume from suspend, ignore this.

---
 drivers/platform/x86/toshiba_acpi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/platform/x86/toshiba_acpi.c +3 -1
index 2a5a651235fe..16e941449b14 100644
@@ -270,6 +270,7 @@ static const struct key_entry toshiba_acpi_keymap[] = {
 	{ KE_KEY, 0xb32, { KEY_NEXTSONG } },
 	{ KE_KEY, 0xb33, { KEY_PLAYPAUSE } },
 	{ KE_KEY, 0xb5a, { KEY_MEDIA } },
+	{ KE_IGNORE, 0x0e00, { KEY_RESERVED } }, /* Wake from sleep */
 	{ KE_IGNORE, 0x1430, { KEY_RESERVED } }, /* Wake from sleep */
 	{ KE_IGNORE, 0x1501, { KEY_RESERVED } }, /* Output changed */
 	{ KE_IGNORE, 0x1502, { KEY_RESERVED } }, /* HDMI plugged/unplugged */
@@ -3553,9 +3554,10 @@ static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
 					(dev->kbd_mode == SCI_KBD_MODE_ON) ?
 					LED_FULL : LED_OFF);
 		break;
+	case 0x8e: /* Power button pressed */
+		break;
 	case 0x85: /* Unknown */
 	case 0x8d: /* Unknown */
-	case 0x8e: /* Unknown */
 	case 0x94: /* Unknown */
 	case 0x95: /* Unknown */
 	default:
Signature · 1 line
2.44.0
#1 lore raw

Hi,

Quoted 10 lines · Hans de Goede

Stop logging unknown event / unknown keycode messages on suspend / resume on a Toshiba Portege Z830:

1. The Toshiba Portege Z830 sends a 0x8e event when the power button is pressed, ignore this.

2. The Toshiba Portege Z830 sends a 0xe00 hotkey event on resume from suspend, ignore this.

I've added this to my review-hans (soon to be for-next) branch now.

Regards,

Hans

Quoted 28 lines
---
 drivers/platform/x86/toshiba_acpi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/platform/x86/toshiba_acpi.c +3 -1
index 2a5a651235fe..16e941449b14 100644
@@ -270,6 +270,7 @@ static const struct key_entry toshiba_acpi_keymap[] = {
 	{ KE_KEY, 0xb32, { KEY_NEXTSONG } },
 	{ KE_KEY, 0xb33, { KEY_PLAYPAUSE } },
 	{ KE_KEY, 0xb5a, { KEY_MEDIA } },
+	{ KE_IGNORE, 0x0e00, { KEY_RESERVED } }, /* Wake from sleep */
 	{ KE_IGNORE, 0x1430, { KEY_RESERVED } }, /* Wake from sleep */
 	{ KE_IGNORE, 0x1501, { KEY_RESERVED } }, /* Output changed */
 	{ KE_IGNORE, 0x1502, { KEY_RESERVED } }, /* HDMI plugged/unplugged */
@@ -3553,9 +3554,10 @@ static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
 					(dev->kbd_mode == SCI_KBD_MODE_ON) ?
 					LED_FULL : LED_OFF);
 		break;
+	case 0x8e: /* Power button pressed */
+		break;
 	case 0x85: /* Unknown */
 	case 0x8d: /* Unknown */
-	case 0x8e: /* Unknown */
 	case 0x94: /* Unknown */
 	case 0x95: /* Unknown */
 	default:
maintainer
#2 lore raw
In reply to Hans de Goede
Quoted 10 lines · Hans de Goede

Stop logging unknown event / unknown keycode messages on suspend / resume on a Toshiba Portege Z830:

1. The Toshiba Portege Z830 sends a 0x8e event when the power button is pressed, ignore this.

2. The Toshiba Portege Z830 sends a 0xe00 hotkey event on resume from suspend, ignore this.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: toshiba_acpi: Silence logging for some events

      commit: 0dd50b3e2c3d651ea972c97cff1af67870f3deaf

--
i.

#3 lore raw

Hi,

Quoted 14 lines · Ilpo Järvinen
Quoted 10 lines · Hans de Goede

Stop logging unknown event / unknown keycode messages on suspend / resume on a Toshiba Portege Z830:

1. The Toshiba Portege Z830 sends a 0x8e event when the power button is pressed, ignore this.

2. The Toshiba Portege Z830 sends a 0xe00 hotkey event on resume from suspend, ignore this.

[...]

Quoted 8 lines

Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: toshiba_acpi: Silence logging for some events

      commit: 0dd50b3e2c3d651ea972c97cff1af67870f3deaf

Thanks.

Note I had also applied this to my review-hans branch for for-next, I'll drop it there.

Regards,

Hans

maintainer
#4 lore raw
Quoted 20 lines · Hans de Goede
Quoted 19 lines · Ilpo Järvinen
Quoted 10 lines · Hans de Goede

Stop logging unknown event / unknown keycode messages on suspend / resume on a Toshiba Portege Z830:

1. The Toshiba Portege Z830 sends a 0x8e event when the power button is pressed, ignore this.

2. The Toshiba Portege Z830 sends a 0xe00 hotkey event on resume from suspend, ignore this.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while.

Quoted 8 lines
Quoted 3 lines

The list of commits applied:
[1/1] platform/x86: toshiba_acpi: Silence logging for some events

      commit: 0dd50b3e2c3d651ea972c97cff1af67870f3deaf

Thanks.

Note I had also applied this to my review-hans branch for for-next, I'll drop it there.

Okay, I even tried hard to avoid that by checking what you had in review-hans branch but we just happened to work nearly at the same time so it didn't help.

Signature · 1 line
 i.
#5 lore raw

Hi,

Quoted 25 lines · Ilpo Järvinen
Quoted 24 lines · Hans de Goede
Quoted 22 lines · Ilpo Järvinen
Quoted 10 lines · Hans de Goede

Stop logging unknown event / unknown keycode messages on suspend / resume on a Toshiba Portege Z830:

1. The Toshiba Portege Z830 sends a 0x8e event when the power button is pressed, ignore this.

2. The Toshiba Portege Z830 sends a 0xe00 hotkey event on resume from suspend, ignore this.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: toshiba_acpi: Silence logging for some events

      commit: 0dd50b3e2c3d651ea972c97cff1af67870f3deaf
Quoted 8 lines
Quoted 4 lines

Thanks.

Note I had also applied this to my review-hans branch for for-next, I'll drop it there.

Okay, I even tried hard to avoid that by checking what you had in review-hans branch but we just happened to work nearly at the same time so it didn't help.

Yeah no worries, dropping the patch was almost 0 work.

Regards,

Hans