Dereference in drivers/scsi/lpfc/lpfc_ct.c
Subsystems (2)
PATCH 1/1 Dereference in drivers/scsi/lpfc/lpfc_ct.c
hi,
if we fail to allocate mp->virt during the first while loop iteration, mlist is still uninitialized, therefore we should check if before dereferencing.
Signed-off-by Eric Sesterhenn <[email protected]>
drivers/scsi/lpfc/lpfc_ct.c renamed from drivers/scsi/lpfc/lpfc_ct.c.orig +2 -1
@@ -188,7 +188,8 @@ lpfc_alloc_ct_rsp(struct lpfc_hba * phbaif (!mp->virt) {kfree (mp); -lpfc_free_ct_rsp (phba, mlist); +if (mlist) +lpfc_free_ct_rsp (phba, mlist);return NULL ; }
ACK - good fix.
-- james s
Quoted 23 lines · Eric Sesterhenn
hi,
if we fail to allocate
mp->virtduring the first while loop iteration, mlist is still uninitialized, therefore we should check if before dereferencing.Signed-off-by Eric Sesterhenn <[email protected]>drivers/scsi/lpfc/lpfc_ct.c renamed from drivers/scsi/lpfc/lpfc_ct.c.orig +2
-1@@ -188,7 +188,8 @@ lpfc_alloc_ct_rsp(struct lpfc_hba * phbaif (!mp->virt) {kfree (mp); -lpfc_free_ct_rsp (phba, mlist); +if (mlist) +lpfc_free_ct_rsp (phba, mlist);return NULL ; }