Skip to contentSkip to conversation

Pending September patches

DISCUSSION Dirk Behme 8 participants 14 messages Oct 4, 2006 – Oct 26, 2006

Subsystems (2)
lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

Hi,

my list of pending OMAP patches for September 2006:

1. [PATCH] MTD patch, including the latest modifications an offical upgrades for MTD
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007889.html

Note: Is this still necessary or does 2.6.18 contain it automatically?

2.[PATCH 1/4] TSC2102 main SPI driver
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007929.html

3. [PATCH 2/4] TSC2102 Touchscreen
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007931.html

Note: What's about "[PATCH 3/4] TSC2102 hwmon driver"?

4. [PATCH 4/4] TSC2102 OMAP audio driver
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007930.html

5. [PATCH] Request OMAP MMC Write-protect pin
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007976.html

6. LCD output from decompressor
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007977.html

Note: Should this be applied or only stay on the list for interested people?

Please correct if I missed anything, if any of above patches are already applied or if any has comments I overlooked and needs resend. Are there any older patches pending?

Cheers

Dirk

#1 lore raw
Quoted 11 lines · Dirk Behme

Hi,

my list of pending OMAP patches for September 2006:

1. [PATCH] MTD patch, including the latest modifications an offical upgrades for MTD
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007889.html

Note: Is this still necessary or does 2.6.18 contain it automatically?

Quoted 7 lines

2.[PATCH 1/4] TSC2102 main SPI driver
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007929.html

3. [PATCH 2/4] TSC2102 Touchscreen
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007931.html

Note: What's about "[PATCH 3/4] TSC2102 hwmon driver"?

The code from it was included in "[PATCH 1/4] TSC2102 main SPI driver".

Quoted 4 lines

4. [PATCH 4/4] TSC2102 OMAP audio driver
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007930.html

Quoted 8 lines

5. [PATCH] Request OMAP MMC Write-protect pin
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007976.html

6. LCD output from decompressor
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007977.html

Note: Should this be applied or only stay on the list for interested people?

It was meant to stay on the list for interested people. One part of the patch changes the 8x8 font to 8x16 which also affects Acorn RiscPC. The other part is non-intrusive but estimated interested people are few.

Greetings,

Signature · 1 line
balrog 2oo6
#2 lore raw

Help with LCD on OSK

Hello,

I was hoping I might be able to get some assistance with getting an external, custom LCD working with the OSK. It's driver board currently connects to the OSK via the 80-pin HiRose connector to Expansion Slot C on the OSK.

It's a grascale video LCD (320x240 from Hantronix) with it's 4x data lines connected to LCD.P2, LCD.P4, LCD.P6, and LCD.P8.

I've looked at lcd_osk.c and lcdc.c in .../arch/arm/drivers/plat-omap, but do not readily see what I need to modify to get things working.

In addition, I do not know how to tell if the driver is installed and loading correctly with my current kernel.

Any help and/or direction (to documentation or otherwise) would be greatly appreciated. As this is a university project, I'm on a tight schedule and would appreciate any response... really.

Thanks in advance.
______________________________________________
Scott R. Sideleau
ECE '07, Worcester Polytechnic Institute
@ MQP Ireland A'06, University of Limerick
+353 61-307310 / [email protected]

#3 lore raw

RE: Help with LCD on OSK

Hello,

Quoted 3 lines

It's a grascale video LCD (320x240 from Hantronix) with it's 4x data lines connected to LCD.P2, LCD.P4, LCD.P6, and LCD.P8.

Is its specification (or datasheet) available public, ideally on-line?

Quoted 2 lines

I've looked at lcd_osk.c and lcdc.c in .../arch/arm/drivers/plat-omap, but do not readily see what I need to modify to get things working.

Well, you might first want to understand each parameter with
the display controller datamanual.

	http://focus.ti.com/lit/ug/spru764b/spru764b.pdf
Quoted 2 lines

I do not know how to tell if the driver is installed and loading correctly with my current kernel.

I hope this page might help.

http://oskfordummies.hp.infoseek.co.jp/howto/lcd.html

Quoted 1 line

As this is a university project, I'm on a tight schedule

Probably you already know, but the OSK LCD board is already
is available from the 3rd parties.

	http://www.aditec.co.kr/2005_aditec/img/aglm.pdf

http://www.mistralsoftware.com/html/product/opendoc.php?document_url=oma
p_products/QVLM.pdf

Good luck,

Regards,
Ishigami

-----Original Message-----
From: Sideleau, Scott R [mailto:[email protected]]
Sent: Wednesday, October 04, 2006 9:30 AM
To: [email protected]
Subject: Help with LCD on OSK

Hello,

I was hoping I might be able to get some assistance with getting an external,
custom LCD working with the OSK. It's driver board currently connects to the
OSK via the 80-pin HiRose connector to Expansion Slot C on the OSK.

It's a grascale video LCD (320x240 from Hantronix) with it's 4x data lines
connected to LCD.P2, LCD.P4, LCD.P6, and LCD.P8.

I've looked at lcd_osk.c and lcdc.c in .../arch/arm/drivers/plat-omap, but do
not readily see what I need to modify to get things working.

In addition, I do not know how to tell if the driver is installed and loading
correctly with my current kernel.

Any help and/or direction (to documentation or otherwise) would be greatly
appreciated. As this is a university project, I'm on a tight schedule and
would appreciate any response... really.

Thanks in advance.
______________________________________________
Scott R. Sideleau
ECE '07, Worcester Polytechnic Institute
@ MQP Ireland A'06, University of Limerick
+353 61-307310 / [email protected]

#4 lore raw

RE: Help with LCD on OSK

Hello,

First, thanks for the reply, Ishigami.

Quoted 1 line

Is its specification (or datasheet) available public, ideally on-line?

Yes, indeed it is. Check out the data sheet and full specification sheet for the 320x240 display (scroll to table on bottom of page) at the following web site:

http://www.hantronix.com/2_1.html

Quoted 8 lines

Well, you might first want to understand each parameter with the display controller datamanual.
http://focus.ti.com/lit/ug/spru764b/spru764b.pdf

...

I hope this page might help.
http://oskfordummies.hp.infoseek.co.jp/howto/lcd.html

Thanks, I'll check out both of those links now.

Quoted 2 lines

Probably you already know, but the OSK LCD board is already is available from the 3rd parties.

Indeed, we were aware of the available OSK LCD boards; however, it being a university project with limited funding, one of the existing (rather expensive) solutions was not an option.

We have engineered the necessary driver circuitry for the Hantronix 320x240 Chip-on-Glass LCD and have verified it is receiving the necessary voltages when powered by the OSK development board across Expansion Connector C.

At this point, I believe it to be a software issue.

If you, or anyone else, has any further advice or knowledge in dealing with this aspect of the OSK, any assistance would be greatly appreciated.

Thanks, Ishigami, for your help thus far.
______________________________________________
Scott R. Sideleau
ECE '07, Worcester Polytechnic Institute
@ MQP Ireland A'06, University of Limerick
+353 61-307310 / [email protected]

#5 lore raw

using __raw_read function

Hi All,

I am having problems writing a value to a specific register. I dont know if the one causing this problem is the __raw_readl function. I've tried to use all the registers in the I2C and I get the same problem. The values are not changed. Is there anyone who knows what the problem is? I dont think this is specific to I2C.

Below is the example code that I am doing. I want to write to the register 0xFFFB382C a value of 0x48. With the use of printk I could see that the value was not changed.

#define LXK_I2C_BASE (void *) IO_ADDRESS(0xFFFB3800)
#define I2C_SA 0x2C

void *g_i2c_base = LXK_I2C_BASE;

static int i2c_open(struct inode *inode, struct file *filp)
u32 l;
l = 0x48;
__raw_writel(l,g_i2c_base + I2C_SA); printk("Slave address = %x
\n",(__raw_readl(g_i2c_base + I2C_SA)));

        return 0;
}

If someone have an idea on whats going on, please give me a hand.

Thanks,
OJ

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com

#6 lore raw

Re: using __raw_read function

Quoted 8 lines · Arnold

Hi All,

I am having problems writing a value to a specific register. I dont know if the one causing this problem is the __raw_readl function. I've tried to use all the registers in the I2C and I get the same problem. The values are not changed. Is there anyone who knows what the problem is? I dont think this is specific to I2C.

Maybe you don't have I2C clock(s) enabled?

Tony

#7 lore raw

Re: using __raw_read function

Hi Tony,

Thank you for taking time to answer. I checked the ARM_RSTCT2 bit 0 and it is enabled. I also checked the ARM_IDLECT2 bits 1 and 2 and it is already enabled. Is there anything I should still enable inorder to change the value of the i2c registers? It seems that I can not write to all i2c registers. Is there anything I am doing wrong?

Thanks,
OJ

Quoted 10 lines · --- Tony Lindgren
Quoted 4 lines · Arnold

Hi All,

I am having problems writing a value to a specific register. I dont know if the one causing this

problem

Quoted 1 line

is the __raw_readl function. I've tried to use all

the

Quoted 1 line

registers in the I2C and I get the same problem.

The

Quoted 9 lines
Quoted 1 line

values are not changed. Is there anyone who knows

what

Quoted 1 line

the problem is? I dont think this is specific to

I2C.

Maybe you don't have I2C clock(s) enabled?

Tony

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com

#8 lore raw
In reply to Dirk Behme
Quoted 10 lines · Dirk Behme

Hi,

my list of pending OMAP patches for September 2006:

1. [PATCH] MTD patch, including the latest modifications an offical upgrades for MTD
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007889.html

Note: Is this still necessary or does 2.6.18 contain it automatically?

2.6.18 is quite well synced with MTD tree. What is missing is out driver modification... Please consider.

[PATCH] Make omap-nand-flash driver work after MTD update

drivers/mtd/nand/omap-nand-flash.c +21 -18
index 35a3408..a231e18 100644
@@ -11,6 +11,7 @@
 
 #include <linux/init.h>
 #include <linux/ioport.h>
+#include <linux/delay.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
@@ -44,21 +45,25 @@ struct omap_nand_info {
 /*
  *	hardware specific access to control-lines
  *	NOTE:  boards may use different bits for these!!
+ *
+ *	ctrl:
+ *	NAND_NCE: bit 0 - don't care
+ *	NAND_CLE: bit 1 -> bit 1  (0x0002)
+ *	NAND_ALE: bit 2 -> bit 2  (0x0004)
  */
-#define	MASK_CLE	0x02
-#define	MASK_ALE	0x04
-static void omap_nand_hwcontrol(struct mtd_info *mtd, int cmd)
+
+static void omap_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl)
 {
-	struct nand_chip *this = mtd->priv;
-	unsigned long IO_ADDR_W = (unsigned long) this->IO_ADDR_W;
-
-	switch (cmd) {
-		case NAND_CTL_SETCLE: IO_ADDR_W |= MASK_CLE; break;
-		case NAND_CTL_CLRCLE: IO_ADDR_W &= ~MASK_CLE; break;
-		case NAND_CTL_SETALE: IO_ADDR_W |= MASK_ALE; break;
-		case NAND_CTL_CLRALE: IO_ADDR_W &= ~MASK_ALE; break;
-	}
-	this->IO_ADDR_W = (void __iomem *) IO_ADDR_W;
+	struct nand_chip *chip = mtd->priv;
+	unsigned long mask;
+
+	if (cmd == NAND_CMD_NONE)
+		return;
+
+	mask = (ctrl & NAND_CLE) ? 0x02 : 0;
+	if (ctrl & NAND_ALE)
+		mask |= 0x04;
+	writeb(cmd, (unsigned long)chip->IO_ADDR_W | mask);
 }
 
 static int omap_nand_dev_ready(struct mtd_info *mtd)
@@ -76,12 +81,10 @@ static int __devinit omap_nand_probe(str
 	unsigned long			size = res->end - res->start + 1;
 	int				err;
 
-	info = kmalloc(sizeof(struct omap_nand_info), GFP_KERNEL);
+	info = kzalloc(sizeof(struct omap_nand_info), GFP_KERNEL);
 	if (!info)
 		return -ENOMEM;
 
-	memset(info, 0, sizeof(struct omap_nand_info));
-
 	if (!request_mem_region(res->start, size, pdev->dev.driver->name)) {
 		err = -EBUSY;
 		goto out_free_info;
@@ -93,8 +96,8 @@ static int __devinit omap_nand_probe(str
 		goto out_release_mem_region;
 	}
 	info->nand.IO_ADDR_W = info->nand.IO_ADDR_R;
-	info->nand.hwcontrol = omap_nand_hwcontrol;
-	info->nand.eccmode = NAND_ECC_SOFT;
+	info->nand.cmd_ctrl = omap_nand_hwcontrol;
+	info->nand.ecc.mode = NAND_ECC_SOFT;
 	info->nand.options = pdata->options;
 	if (pdata->dev_ready)
 		info->nand.dev_ready = omap_nand_dev_ready;
#9 lore raw
Quoted 9 lines · Ladislav Michl
Quoted 8 lines · Dirk Behme

Hi,

my list of pending OMAP patches for September 2006:

1. [PATCH] MTD patch, including the latest modifications an offical upgrades for MTD
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007889.html

Quoted 7 lines
Quoted 2 lines

Note: Is this still necessary or does 2.6.18 contain it automatically?

2.6.18 is quite well synced with MTD tree. What is missing is out driver modification... Please consider.

[PATCH] Make omap-nand-flash driver work after MTD update

Pushing today. I assume you have also sent this to MTD tree for upstream merge?

Regards,

Tony

#10 lore raw

About to tag 2.6.18-omap1 (Was: Pending September patches)

In reply to Dirk Behme

Hi,

I believe things are mostly working, except for the pending McBSP without DSP compile issue. Most of the patches posted on this list have been integrated, please notify if you feel something is still missing. Also check that your patches got integrated properly.

Unless somebody knows of any showstoppers, I'll tag 2.6.18-omap1 tomorrow.

Below comments on Dirk's pending September patches list.

Quoted 10 lines · Dirk Behme

Hi,

my list of pending OMAP patches for September 2006:

1. [PATCH] MTD patch, including the latest modifications an offical upgrades for MTD
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007889.html

Note: Is this still necessary or does 2.6.18 contain it automatically?

Skipped this one as only Ladis' driver patch was needed.

Quoted 2 lines

2.[PATCH 1/4] TSC2102 main SPI driver
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007929.html

Pushed.

Quoted 2 lines

3. [PATCH 2/4] TSC2102 Touchscreen
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007931.html

Pushed.

Quoted 1 line

Note: What's about "[PATCH 3/4] TSC2102 hwmon driver"?

Not needed any longer.

Quoted 2 lines

4. [PATCH 4/4] TSC2102 OMAP audio driver
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007930.html

Pushed.

Quoted 2 lines

5. [PATCH] Request OMAP MMC Write-protect pin
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007976.html

Not pushed, let's wait for a board-*.c solution.

Quoted 5 lines

6. LCD output from decompressor
http://linux.omap.com/pipermail/linux-omap-open-source/2006-September/007977.html

Note: Should this be applied or only stay on the list for interested people?

Skipped.

Quoted 3 lines

Please correct if I missed anything, if any of above patches are already applied or if any has comments I overlooked and needs resend. Are there any older patches pending?

Well there's Dave's RTC patches, but I think those should be tested first.

Regards,

Tony

author
#11 lore raw

Re: About to tag 2.6.18-omap1 (Was: Pending September patches)

Quoted 4 lines · Tony Lindgren

I believe things are mostly working, except for the pending McBSP without DSP compile issue. Most of the patches posted on this list have been integrated, please notify if you feel something is still missing.

Just updated my pending patches list: it is nearly empty now :)

Only the two patches from today, the Palm Tungsten|T and your McBSP, are open now. But I think people should have some time to test them.

Many thanks

Dirk

#12 lore raw

Re: About to tag 2.6.18-omap1 (Was: Pending September patches)

Quoted 7 lines · Dirk Behme
Quoted 4 lines · Tony Lindgren

I believe things are mostly working, except for the pending McBSP without DSP compile issue. Most of the patches posted on this list have been integrated, please notify if you feel something is still missing.

Just updated my pending patches list: it is nearly empty now :)

Btw, are changes pushed? The weblog does not show them yet...

    http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=log;t=7
#13 lore raw

Re: About to tag 2.6.18-omap1 (Was: Pending September patches)

Quoted 11 lines · lamikr
Quoted 7 lines · Dirk Behme
Quoted 4 lines · Tony Lindgren

I believe things are mostly working, except for the pending McBSP without DSP compile issue. Most of the patches posted on this list have been integrated, please notify if you feel something is still missing.

Just updated my pending patches list: it is nearly empty now :)

Btw, are changes pushed? The weblog does not show them yet...

    http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=log;t=7

Oops, sorry. Pushed now.

Tony