b44: fix multicast with >32 groups
Subsystems (2)
PATCH 1/1 b44: fix multicast with >32 groups
The b44 driver has a bug where if there are more than B44_MCAST_TABLE_SIZE groups in the dev->mc_list, it will only listen to the first B44_MCAST_TABLE_SIZE that it sees.
This patch makes the driver go into RXCONFIG_ALLMULTI mode if there are more than B44_MCAST_TABLE_SIZE groups being subscribed to.
This patch is against 2.6.18, b44.c version 1.01.
drivers/net/b44.c +2 -1
@@ -1706,7 +1706,8 @@ static void __b44_set_rx_mode(struct net__b44_set_mac_addr (bp); -if (dev->flags &IFF_ALLMULTI ) +if ((dev->flags &IFF_ALLMULTI ) || + (dev->mc_count >B44_MCAST_TABLE_SIZE )) val |=RXCONFIG_ALLMULTI ;else i =__b44_load_mcast (bp, dev);
Quoted 18 lines · Bill Helfinstine
The b44 driver has a bug where if there are more than
B44_MCAST_TABLE_SIZEgroups in thedev->mc_list, it will only listen to the firstB44_MCAST_TABLE_SIZEthat it sees.This patch makes the driver go into
RXCONFIG_ALLMULTImode if there are more thanB44_MCAST_TABLE_SIZEgroups being subscribed to.This patch is against 2.6.18,
b44.cversion 1.01.Signed-off-by Bill Helfinstine <[email protected]>drivers/net/b44.c +0
-0
drivers/net/b44.c static void __b44_set_rx_mode(struct net · line 1713
Quoted 9 lines
drivers/net/b44.c +2
-1@@ -1706,7 +1706,8 @@ static void __b44_set_rx_mode(struct net__b44_set_mac_addr (bp); -if (dev->flags &IFF_ALLMULTI ) +if ((dev->flags &IFF_ALLMULTI ) || + (dev->mc_count >B44_MCAST_TABLE_SIZE )) val |=RXCONFIG_ALLMULTI ;else i =__b44_load_mcast (bp, dev);
It looks good to me, however, I'll have to nack it as this patch has spaces and will not apply. Please convert the spaces to tabs.
Thanks,
Gary
Quoted 9 lines · Bill Helfinstine
The b44 driver has a bug where if there are more than
B44_MCAST_TABLE_SIZEgroups in thedev->mc_list, it will only listen to the firstB44_MCAST_TABLE_SIZEthat it sees.This patch makes the driver go into
RXCONFIG_ALLMULTImode if there are more thanB44_MCAST_TABLE_SIZEgroups being subscribed to.This patch is against 2.6.18,
b44.cversion 1.01.Signed-off-by Bill Helfinstine <[email protected]>
applied manually, due to whitespace damage