Skip to contentSkip to conversation

crypto: s5p-sss: fix multiplatform build

PATCH In review Arnd Bergmann 3 participants 3 messages May 9, 2014 – May 13, 2014

Subsystems (3)
Crypto API Arm Samsung Exynos Samsung S5P Security SubSystem (sss) driver
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 crypto: s5p-sss: fix multiplatform build

As we are preparing to enable multiplatform support on EXYNOS, we can no longer include mach/*.h or plat/*.h headers from device drivers.

The s5p-sss driver was just enabled for EXYNOS when it used to be used only on s5pv210, and it includes two samsung platform specific header files for historic reasons. Fortunately, it no longer actually needs them, so we can remove the #includes and avoid the problem

Signed-off-by Arnd Bergmann <[email protected]>
Cc Naveen Krishna Chatradhi <[email protected]>
Cc Tomasz Figa <[email protected]>
Cc <[email protected]>
Cc Vladimir Zapolskiy <[email protected]>
Cc Herbert Xu <[email protected]>

---
Please apply on top of the other s5p-sss patches

drivers/crypto/s5p-sss.c +0 -3
index 47c568e..4197ad9 100644
@@ -30,9 +30,6 @@
 #include <crypto/aes.h>
 #include <crypto/ctr.h>
 
-#include <plat/cpu.h>
-#include <mach/dma.h>
-
 #define _SBF(s, v)                      ((v) << (s))
 #define _BIT(b)                         _SBF(b, 1)
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Arnd Bergmann

As we are preparing to enable multiplatform support on EXYNOS, we can no longer include mach/*.h or plat/*.h headers from device drivers.

The s5p-sss driver was just enabled for EXYNOS when it used to be used only on s5pv210, and it includes two samsung platform specific header files for historic reasons. Fortunately, it no longer actually needs them, so we can remove the #includes and avoid the problem

Quoted 6 lines
Signed-off-by Arnd Bergmann <[email protected]>
Cc Naveen Krishna Chatradhi <[email protected]>
Cc Tomasz Figa <[email protected]>
Cc <[email protected]>
Cc Vladimir Zapolskiy <[email protected]>
Cc Herbert Xu <[email protected]>

I checked that these machine specific headers are
unnecessary. Thanks!

Reviewed-by Jingoo Han <[email protected]>

Best regards,
Jingoo Han

Quoted 19 lines

---
Please apply on top of the other s5p-sss patches

drivers/crypto/s5p-sss.c +0 -4
index 47c568e..4197ad9 100644
@@ -30,9 +30,6 @@
 #include <crypto/aes.h>
 #include <crypto/ctr.h>
 
-#include <plat/cpu.h>
-#include <mach/dma.h>
-
 #define _SBF(s, v)                      ((v) << (s))
 #define _BIT(b)                         _SBF(b, 1)
 
 
--
maintainer
#2 lore raw
Quoted 19 lines · Jingoo Han
Quoted 11 lines · Arnd Bergmann

As we are preparing to enable multiplatform support on EXYNOS, we can no longer include mach/*.h or plat/*.h headers from device drivers.

The s5p-sss driver was just enabled for EXYNOS when it used to be used only on s5pv210, and it includes two samsung platform specific header files for historic reasons. Fortunately, it no longer actually needs them, so we can remove the #includes and avoid the problem

Quoted 6 lines
Signed-off-by Arnd Bergmann <[email protected]>
Cc Naveen Krishna Chatradhi <[email protected]>
Cc Tomasz Figa <[email protected]>
Cc <[email protected]>
Cc Vladimir Zapolskiy <[email protected]>
Cc Herbert Xu <[email protected]>
Quoted 4 lines

I checked that these machine specific headers are
unnecessary. Thanks!

Reviewed-by Jingoo Han <[email protected]>

Patch applied. Thanks!

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt