Skip to contentSkip to conversation

linux-next: build warning after merge of the vfs-brauner tree

DISCUSSION Stephen Rothwell 4 participants 5 messages Feb 19, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs) produced this warning:

Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]

Introduced by commit

20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs) produced this warning:

Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]

Introduced by commit

20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")

Separating the bullet list should suffice (plus s/recommend/recommended/ for consistency with the rest of docs):

---- >8 ----

Documentation/filesystems/porting.rst +3 -2
index 3b6622fbd66be9..cfac50a7258db6 100644
@@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
 dentry so this doesn't need to be checked.  If the name cannot be found,
 ERR_PTR(-ENOENT) is returned.
 
-** recommend**
+** recommended**
 
 lookup_one_qstr_excl() is changed to return errors in more cases, so
-these conditions don't require explicit checks.
+these conditions don't require explicit checks:
+
  - if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
    ERR_PTR(-ENOENT) is returned instead
  - if LOOKUP_EXCL IS given, then the dentry won't be positive,

Let me know if I should send the formal patch.

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#2 lore raw
Quoted 36 lines · Bagas Sanjaya
Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs) produced this warning:

Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]

Introduced by commit

20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")

Separating the bullet list should suffice (plus s/recommend/recommended/ for consistency with the rest of docs):

---- >8 ----

Documentation/filesystems/porting.rst +3 -2
index 3b6622fbd66be9..cfac50a7258db6 100644
@@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
 dentry so this doesn't need to be checked.  If the name cannot be found,
 ERR_PTR(-ENOENT) is returned.
 
-** recommend**
+** recommended**
 
 lookup_one_qstr_excl() is changed to return errors in more cases, so
-these conditions don't require explicit checks.
+these conditions don't require explicit checks:
+
  - if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
    ERR_PTR(-ENOENT) is returned instead
  - if LOOKUP_EXCL IS given, then the dentry won't be positive,
Quoted 1 line

Let me know if I should send the formal patch.

No, I'll fix it in-tree and fold it.
Thanks.

#3 lore raw
Quoted 24 lines · Christian Brauner
Quoted 23 lines · Bagas Sanjaya

Separating the bullet list should suffice (plus s/recommend/recommended/ for consistency with the rest of docs):

---- >8 ----

Documentation/filesystems/porting.rst +3 -2
index 3b6622fbd66be9..cfac50a7258db6 100644
@@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
  dentry so this doesn't need to be checked.  If the name cannot be found,
  ERR_PTR(-ENOENT) is returned.
 
-** recommend**
+** recommended**
 
  lookup_one_qstr_excl() is changed to return errors in more cases, so
-these conditions don't require explicit checks.
+these conditions don't require explicit checks:
+
   - if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
     ERR_PTR(-ENOENT) is returned instead
   - if LOOKUP_EXCL IS given, then the dentry won't be positive,
Quoted 4 lines
Quoted 1 line

Let me know if I should send the formal patch.

No, I'll fix it in-tree and fold it.
Thanks.

OK, thanks!

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#4 lore raw
In reply to Bagas Sanjaya
Quoted 36 lines · Bagas Sanjaya
Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs) produced this warning:

Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]

Introduced by commit

20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")

Separating the bullet list should suffice (plus s/recommend/recommended/ for consistency with the rest of docs):

---- >8 ----

Documentation/filesystems/porting.rst +3 -2
index 3b6622fbd66be9..cfac50a7258db6 100644
@@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
 dentry so this doesn't need to be checked.  If the name cannot be found,
 ERR_PTR(-ENOENT) is returned.
 
-** recommend**
+** recommended**
 
 lookup_one_qstr_excl() is changed to return errors in more cases, so
-these conditions don't require explicit checks.
+these conditions don't require explicit checks:
+
  - if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
    ERR_PTR(-ENOENT) is returned instead
  - if LOOKUP_EXCL IS given, then the dentry won't be positive,
Quoted 1 line

Let me know if I should send the formal patch.

Thanks a lot for correcting these for me!
NeilBrown

Quoted 6 lines

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara