ATA must depend on BLOCK
PATCH 1/1 ATA must depend on BLOCK
This patch fixes the following compile error with CONFIG_ATA=y, CONFIG_BLOCK=n:
<-- snip -->
...
CC drivers/ata/libata-scsi.o/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c: In function ‘ata_scsi_dev_config’:/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c:791: warning: implicit declaration of function ‘blk_queue_max_sectors’ /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c:799: error: ‘request_queue_t’ undeclared (first use in this function) /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c:799: error: (Each undeclared identifier is reported only once /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c:799: error: for each function it appears in.) /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c:799: error: ‘q’ undeclared (first use in this function) /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c:800: warning: implicit declaration of function ‘blk_queue_max_hw_segments’ /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c: In function ‘ata_scsi_slave_config’:/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-scsi.c:831:
warning: implicit declaration of function ‘blk_queue_max_phys_segments’
make[3]: *** [drivers/ata/libata-scsi.o] Error 1
<-- snip -->
Bug report by Jesper Juhl.
drivers/ata/Kconfig renamed from drivers/ata/Kconfig.old +1 -0
@@ -6,6 +6,7 @@ config ATA tristate "ATA device support" + depends on BLOCK depends on !(M32R || M68K) || BROKEN depends on !SUN4 || BROKEN select SCSI
Quoted 2 lines · Adrian Bunk
This patch fixes the following compile error with
CONFIG_ATA=y,CONFIG_BLOCK=n:
[...]
drivers/ata/Kconfig line 12
Quoted 6 lines
config ATA
drivers/ata/Kconfig renamed from drivers/ata/Kconfig.old +1
-0tristate "ATA device support" + depends on BLOCK depends on !(M32R || M68K) || BROKEN depends on !SUN4 || BROKEN select SCSI
The Kconfig isn't broken but the tool which generated the .config.
"config ATA\ select SCSI" implies a dependency of ATA on SCSI. SCSI depends on BLOCK.
Therefore "select SCSI" && "config SCSI\ depends on BLOCK" implies either "config ATA\ select BLOCK" or "config ATA\ depends on BLOCK".
{Ignore all what I said if ATA code directly uses the block API. Usages of the block API to manipulate SCSI data structures, particularly the request queue, does not necessarily count as independent usage of the block API though.}
Signature · 3 lines
Stefan Richter -=====-=-==- =-=- -=--- http://arcgraph.de/sr/