More uml build failures on 2.16.19-rc3 and 2.6.18.1
I've definetly not done any such change on my machine. Remember with the same compile, same environment, if i go back to 2.6.18 i can build uml fine. If i move to 2.6.18.1 or above it breaks...
I do notice my gcc stddef does have this defined
% grep offsetof /usr/lib/gcc/i686-linux/4.0.3/include/stddef.h #define offsetof(TYPE, MEMBER) __builtin_offsetof (TYPE, MEMBER)
And i notice my compiler has it inbuilt, so maybe this is a gcc 4.0.3 issue ?
% strings /usr/libexec/gcc/i686-linux/4.0.3/cc1|grep offsetof offsetof_member_designator__builtin_offsetoffold_offsetof_1
-Winvalid-offsetof
Warn about invalid uses of the "offsetof" macro
-------- Original Message --------
Subject: Re: More uml build failures on 2.16.19-rc3 and 2.6.18.1
Date: Tue, 24 Oct 2006 09:20:25 -0400
From: Jeff Dike <[email protected]>
To: Mitch <[email protected]>
CC: [email protected]
References: <[email protected]>
Quoted 8 lines · Mitch
I'm still having build failures on 2.6.18.1 and even the latest -rc3
home /usr/src/sources/kernel/linux-2.6.18% !ma
make ARCH=um
SYMLINKarch/um/include/kern_constants.h
CCarch/um/sys-i386/user-offsets.sarch/um/sys-i386/user-offsets.c: In function 'foo':arch/um/sys-i386/user-offsets.c:19: warning: implicit declaration of function 'offsetof'
The last time I saw this, someone had replaced the glibc kernel headers with a link to include/ within a kernel pool. There, offsetof is wrapped in #ifdef __KERNEL__, and inaccessible to userspace.
The glibc headers have a usable offsetof, so fix that, and UML should build.
Jeff
Quoted 3 lines · Mitch
I've definetly not done any such change on my machine. Remember with the same compile, same environment, if i go back to 2.6.18 i can build uml fine. If i move to 2.6.18.1 or above it breaks...
You're sure about that? I just looked through the 2.6.18.1 changelog and I see nothing that would cause this.
Quoted 4 lines
I do notice my gcc stddef does have this defined
% grep offsetof
/usr/lib/gcc/i686-linux/4.0.3/include/stddef.h#defineoffsetof(TYPE, MEMBER)__builtin_offsetof(TYPE, MEMBER)
I would do a -E build and make sure that this header, or another one that defines offsetof is getting pulled in.
Jeff