Skip to contentSkip to conversation

make ibm_acpi work right with notify handlers.

PATCH Applied Alexey Starikovskiy 2 participants 2 messages Oct 25, 2006 – Oct 27, 2006 ACPI

lore
Share & tools
lore

Alexey Starikovskiy

author
#0 lore raw

PATCH 1/1 make ibm_acpi work right with notify handlers.

Hi,

There is a bug in ibm_acpi module, which prevents its clean removal. This patch fixes the problem by moving setting notify_installed to the right place.

Thanks,
Alex.

make unload of ibm_acpi right.

From: Alexey Starikovskiy <[email protected]>

---

 drivers/acpi/ibm_acpi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/acpi/ibm_acpi.c +1 -2
index 003a987..719a320 100644
@@ -1805,7 +1805,7 @@ static int __init setup_notify(struct ib
 		       ibm->name, status);
 		return -ENODEV;
 	}
-
+	ibm->notify_installed = 1;
 	return 0;
 }
 

@@ -1882,7 +1882,6 @@ static int __init ibm_init(struct ibm_st
 		ret = setup_notify(ibm);
 		if (ret < 0)
 			return ret;
-		ibm->notify_installed = 1;
 	}
 
 	return 0;
Applied
#1 lore raw
Quoted 4 lines · Alexey Starikovskiy

Hi,

There is a bug in ibm_acpi module, which prevents its clean removal. This patch fixes the problem by moving setting notify_installed to the right place.

Applied.

thanks,
-Len