Skip to contentSkip to conversation

Function v9fs_get_idpool returns int, not u32 as called twice in fs/9p/vfs_inode.c

PATCH New Mika Kukkonen 1 participant 1 message Oct 25, 2006 9P file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Function v9fs_get_idpool returns int, not u32 as called twice in fs/9p/vfs_inode.c

|[V9FS] Function v9fs_get_idpool returns int, not u32. Actually
it returns -1 on errors, and these two callers check if the value is smaller than 0, which was caught by gcc with extra warning flags. Compile tested only but should be OK, as the value computed in v9fs_get_idpool() is also int.

---

fs/9p/vfs_inode.c | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)
fs/9p/vfs_inode.c +0 -0
index 5241c60..18f26cd 100644
@@ -256,7 +256,7 @@ static int

v9fs_create(struct v9fs_session_info *v9ses, u32 pfid, char *name, u32 perm,
u8 mode, char *extension, u32 *fidp, struct v9fs_qid *qid, u32 *iounit)
{
- u32 fid;

+	int fid;
	int err;
	struct v9fs_fcall *fcall;

@@ -310,7 +310,7 @@ static struct v9fs_fid*
v9fs_clone_walk(struct v9fs_session_info *v9ses, u32 fid, struct dentry *dentry)

{
	int err;
-	u32 nfid;
+	int nfid;
	struct v9fs_fid *ret;
	struct v9fs_fcall *fcall;

|