Skip to contentSkip to conversation

ARM: dts: Alpine platform devicetree

PATCH New Tsahee Zidenberg 4 participants 4 messages Mar 12, 2015 – Apr 1, 2015

Subsystems (2)
Device tree bindings Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Tsahee Zidenberg

author
#0 lore raw

PATCH v6 5/6 ARM: dts: Alpine platform devicetree

This patch introduces devicetree for the Alpine platform, and for a development board based on the same platform.

Signed-off-by Barak Wasserstrom <[email protected]>
Signed-off-by Tsahee Zidenberg <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
---
 arch/arm/boot/dts/Makefile      |   3 +
 arch/arm/boot/dts/alpine-db.dts |  35 ++++++++++
 arch/arm/boot/dts/alpine.dtsi   | 141 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 179 insertions(+)
 create mode 100644 arch/arm/boot/dts/alpine-db.dts
 create mode 100644 arch/arm/boot/dts/alpine.dtsi
arch/arm/boot/dts/Makefile +3 -0
index 2a45218..0eb23a0 100644
@@ -2,6 +2,9 @@ ifeq ($(CONFIG_OF),y)
 
 dtb-$(CONFIG_MACH_ASM9260) += \
 	alphascale-asm9260-devkit.dtb
+
+dtb-$(CONFIG_ARCH_ALPINE) += alpine_db.dtb
+
 # Keep at91 dtb files sorted alphabetically for each SoC
 dtb-$(CONFIG_SOC_SAM_V4_V5) += \
 	at91rm9200ek.dtb \
arch/arm/boot/dts/alpine-db.dts new file +35 -0
new file mode 100644
index 0000000..dfb5a08
@@ -0,0 +1,35 @@
+/*
+ * Copyright 2015 Annapurna Labs Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * Alternatively, redistribution and use in source and binary forms, with or
+ * without modification, are permitted provided that the following conditions
+ * are met:
+ *
+ *   *   Redistributions of source code must retain the above copyright notice,
+ *       this list of conditions and the following disclaimer.
+ *
+ *   *   Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in
+ *       the documentation and/or other materials provided with the
+ *       distribution.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ */
+
+/dts-v1/;
+
+#include "alpine.dtsi"
+
+/ {
+	model = "Annapurna Labs Alpine Dev Board";
+	/* no need for anything outside SOC */
+};
+
arch/arm/boot/dts/alpine.dtsi new file +141 -0

141 lines not on this page · raw message

Signature · 1 line
1.9.1
maintainer
#1 lore raw

PATCH v6 5/6 ARM: dts: Alpine platform devicetree

arch/arm/boot/dts/Makefile ifeq ($(CONFIG_OF),y) · line 10

Quoted 9 lines · On Thursday 12 March 2015 13:53:12 Tsahee Zidenberg wrote:

dtb-$(CONFIG_MACH_ASM9260) += \
alphascale-asm9260-devkit.dtb

arch/arm/boot/dts/Makefile +3 -0
+
+dtb-$(CONFIG_ARCH_ALPINE) += alpine_db.dtb
+
 # Keep at91 dtb files sorted alphabetically for each SoC
 dtb-$(CONFIG_SOC_SAM_V4_V5) += \
        at91rm9200ek.dtb \

I've adapted the formatting slightly to keep alphabetical ordering and the normal style that is used by the others here.

Please make sure you follow the local coding style for files you touch in the future.

Arnd

#2 lore raw

PATCH v6 5/6 ARM: dts: Alpine platform devicetree

In reply to Tsahee Zidenberg

Can we please get this patch reverted, or at least fixed - preferably before the merge window opens!

Quoted 1 line

+dtb-$(CONFIG_ARCH_ALPINE) += alpine_db.dtb

Here, the filename contains an underscore.

arch/arm/boot/dts/alpine-db.dts

Quoted 5 lines
arch/arm/boot/dts/alpine-db.dts new file +0 -0
new file mode 100644
index 0000000..dfb5a08

Here, the filename contains a hyphen.

Hence, when building a kernel with ARCH_ALPINE enabled, it fails to build, and this screws up an otherwise fine allmodconfig build.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
#3 lore raw

PATCH v6 5/6 ARM: dts: Alpine platform devicetree

Hi,

Quoted 15 lines · Russell King - ARM Linux

Can we please get this patch reverted, or at least fixed - preferably before the merge window opens!

Quoted 1 line

+dtb-$(CONFIG_ARCH_ALPINE) += alpine_db.dtb

Here, the filename contains an underscore.

arch/arm/boot/dts/alpine-db.dts

Quoted 5 lines
arch/arm/boot/dts/alpine-db.dts new file +0 -0
new file mode 100644
index 0000000..dfb5a08

Here, the filename contains a hyphen.

Quoted 2 lines

Hence, when building a kernel with ARCH_ALPINE enabled, it fails to build, and this screws up an otherwise fine allmodconfig build.

Yeah, I'll fix it up today. Apologies for not getting to it earlier (I know you reported it in person).

-Olof