Skip to contentSkip to conversation

qe_lib: qe_issue_cmd writes wrong value to CECDR

PATCH New Li Yang 1 participant 1 message Oct 31, 2006 PowerPC

lore
Share & tools
lore

Li Yang

author
#0 lore raw

PATCH 1/2 qe_lib: qe_issue_cmd writes wrong value to CECDR

From: Timur Tabi <[email protected]>

Changed qe_issue_cmd() to write cmd_input to the CECDR unmodified. It was treating cmd_input as a virtual address and tried to convert it to a physical address.

---

arch/powerpc/sysdev/qe_lib/qe.c +0 -0
index 2bae632..e422322 100644
@@ -122,8 +122,7 @@ int qe_issue_cmd(u32 cmd, u32 device, u8
				mcn_shift = QE_CR_MCN_NORMAL_SHIFT;
		}

- out_be32(&qe_immr->cp.cecdr,
- immrbar_virt_to_phys((void *)cmd_input));

+		out_be32(&qe_immr->cp.cecdr, cmd_input);
		out_be32(&qe_immr->cp.cecr,
			 (cmd | QE_CR_FLG | ((u32) device << dev_shift) | (u32)
			  mcn_protocol << mcn_shift));