Skip to contentSkip to conversation

ehea: kzalloc GFP_ATOMIC fix

PATCH Applied Jan-Bernd Themann 4 participants 4 messages Oct 25, 2006 – Nov 1, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ehea: kzalloc GFP_ATOMIC fix

This patch fixes kzalloc parameters (GFP_ATOMIC instead of GFP_KERNEL)

---

drivers/net/ehea/ehea_main.c +5 -6
index eb7d44d..4538c99 100644
@@ -586,8 +586,8 @@ int ehea_sense_port_attr(struct ehea_por
 	u64 hret;
 	struct hcp_ehea_port_cb0 *cb0;
 
-	cb0 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
-	if (!cb0) {
+	cb0 = kzalloc(H_CB_ALIGNMENT, GFP_ATOMIC);   /* May be called via */
+	if (!cb0) {                                  /* ehea_neq_tasklet() */
 		ehea_error("no mem for cb0");
 		ret = -ENOMEM;
 		goto out;
@@ -765,8 +765,7 @@ static void ehea_parse_eqe(struct ehea_a
 
 		if (EHEA_BMASK_GET(NEQE_PORT_UP, eqe)) {
 			if (!netif_carrier_ok(port->netdev)) {
-				ret = ehea_sense_port_attr(
-					port);
+				ret = ehea_sense_port_attr(port);
 				if (ret) {
 					ehea_error("failed resensing port "
 						   "attributes");
@@ -1502,7 +1501,7 @@ static void ehea_promiscuous(struct net_
 	if ((enable && port->promisc) || (!enable && !port->promisc))
 		return;
 
-	cb7 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
+	cb7 = kzalloc(H_CB_ALIGNMENT, GFP_ATOMIC);
 	if (!cb7) {
 		ehea_error("no mem for cb7");
 		goto out;
@@ -1606,7 +1605,7 @@ static void ehea_add_multicast_entry(str
 	struct ehea_mc_list *ehea_mcl_entry;
 	u64 hret;
 
-	ehea_mcl_entry = kzalloc(sizeof(*ehea_mcl_entry), GFP_KERNEL);
+	ehea_mcl_entry = kzalloc(sizeof(*ehea_mcl_entry), GFP_ATOMIC);
 	if (!ehea_mcl_entry) {
 		ehea_error("no mem for mcl_entry");
 		return;
#1 lore raw
Quoted 1 line · On Wed, 25 Oct 2006 13:11:42 +0200 Jan-Bernd Themann <[email protected]>…

This patch fixes kzalloc parameters (GFP_ATOMIC instead of GFP_KERNEL)

why?

#2 lore raw

Andrew Morton <[email protected]> wrote on 27.10.2006 05:13:13:

Quoted 6 lines
Quoted 1 line · On Wed, 25 Oct 2006 13:11:42 +0200 Jan-Bernd Themann <[email protected]>…

This patch fixes kzalloc parameters (GFP_ATOMIC instead of GFP_KERNEL)

why?

these few kcallocs run in atomic context in some situations. therefore GFP_KERNEL is no good idea.

Christoph R.