Skip to contentSkip to conversation

taskstats: uglify^Woptimize reply assembling

PATCH In review Oleg Nesterov 4 participants 5 messages Nov 1, 2006 – Nov 2, 2006 Documentation

lore
Share & tools
lore
#0 lore raw

cover taskstats: uglify^Woptimize reply assembling

The last series.

Balbir, Shailabh, could you suggest me some user-space tests?

Thomas, we are doing genlmsg_cancel() before nlmsg_free(), this is not necessary. Unless you have evil plans to complicate genetlink we can remove a little bit of code, what do you think?

Oleg.

#1 lore raw
Quoted 2 lines · Oleg Nesterov

The last series.

Thanks again for the refactoring/review and optimizations to the code base. Some of the earlier patches I'm still processing (to be sure the timings etc. of signal clearing vs. task exit are right) but these later ones are pretty straightforward and look good. Testing needed of course.

Quoted 1 line

Balbir, Shailabh, could you suggest me some user-space tests?

For stress testing, what we've used is to run

- one listener continuously getting exit stats (prototype listener code in Documentation/accounting/getdelays.c)
- a multithreaded app where each thread does some disk I/O and some cpu processing (incrementing a count etc.), threads get created and destroyed in a continuous loop
- periodically query the multithreaded app above (print out its tgid first) using another instance of Documentation/accounting/getdelays.c to see if the delay data is getting incremented as expected by what the threads do.
- cerebrus and/or kernel compiles running in background just to create a load

You can drop the cerebrus etc. if the load gets too much.

Running the above past a few hours has caught the kind of bugs seen so far.

Quoted 7 lines

Thomas, we are doing genlmsg_cancel() before nlmsg_free(), this is not necessary. Unless you have evil plans to complicate genetlink we can remove a little bit of code, what do you think?

Oleg.

#2 lore raw

PATCH 1/1 fix Documentation/accounting/getdelays.c buf size

getdelays reports a "fatal reply error, errno 258". We don't have enough room for multi-threaded exit (PID + TGID).

Documentation/accounting/getdelays.c renamed from Documentation/accounting/getdelays.c~ +1 -1
@@ -49,7 +49,7 @@ __u64 stime, utime;
 	}
 
 /* Maximum size of response requested or message sent */
-#define MAX_MSG_SIZE	256
+#define MAX_MSG_SIZE	1024
 /* Maximum number of cpus expected to be specified in a cpumask */
 #define MAX_CPUS	32
 /* Maximum length of pathname to log file */
#3 lore raw
In reply to Oleg Nesterov
Quoted 3 lines · Oleg Nesterov

The last series.

Balbir, Shailabh, could you suggest me some user-space tests?

Hi, Oleg,

We generally use getdelays (see Documentation/accounting/getdelays.c) for getting data of all running processes running on the system frequently along with a stress suite like cerebrus (ctcs) running on the side.

Signature · 3 lines
	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs
#4 lore raw
In reply to Oleg Nesterov

* Oleg Nesterov <[email protected]> 2006-11-01 21:25

Quoted 3 lines

Thomas, we are doing genlmsg_cancel() before nlmsg_free(), this is not necessary. Unless you have evil plans to complicate genetlink we can remove a little bit of code, what do you think?

genlmsg_cancel() is only required in error paths for dumping procedures.