[Bluez-devel] [patch]

PATCH In review Frédéric DALLEAU 3 participants 8 messages Nov 7, 2006 – Nov 14, 2006

Subsystems (2)

Bluetooth drivers Kbuild

lore

Share & tools

lore

Frédéric DALLEAU

author

2006-11-07 16:20 UTC #0 lore raw

PATCH 1/1 [Bluez-devel] [patch]

Hi brad,

Attached is my latest patch from a2dp,
It features :
- tests for an integrated resampler mainly if you don't have alsa,
- better plugin that will finally let alsa do all the resampling which gives the best quality and should work with any incoming stream.
- removed the realtime priority (could lock computer if spinning)
- Some A2DP protocol mods (AVDTP_START and AVDTP_STOP handled and AVDTP_CLOSE)
- Longer connection timeout

Certainly other things that I don't remember!

BR, Frederic

? .deps
? .libs
? Doxyfile
? Makefile
? Makefile.in
? a2play
? a2recv
? aclocal.m4
? autom4te.cache
? avrecv
? avsnd
? btsco
? btsco.kdevelop
? btsco.kdevelop.pcs
? btsco.kdevses
? btsco2
? compile
? config.guess
? config.h
? config.h.in
? config.log
? config.status
? config.sub
? configure
? depcomp
? install-sh
? libtool
? missing
? stamp-h1
? alsa-plugins/.deps
? alsa-plugins/.libs
? alsa-plugins/Makefile
? alsa-plugins/Makefile.in
? alsa-plugins/a2dp_ipc.lo
? alsa-plugins/a2dp_timer.lo
? alsa-plugins/a2dpd
? alsa-plugins/ctl_a2dpd.lo
? alsa-plugins/ctl_sco.lo
? alsa-plugins/libasound_module_ctl_a2dpd.la
? alsa-plugins/libasound_module_ctl_sco.la
? alsa-plugins/libasound_module_pcm_a2dp.la
? alsa-plugins/libasound_module_pcm_a2dpd.la
? alsa-plugins/libasound_module_pcm_sco.la
? alsa-plugins/pcm_a2dp.lo
? alsa-plugins/pcm_a2dpd.lo
? alsa-plugins/pcm_sco.lo
? alsa-plugins/headsetd/.deps
? alsa-plugins/headsetd/.libs
? alsa-plugins/headsetd/Makefile
? alsa-plugins/headsetd/Makefile.in
? alsa-plugins/headsetd/headsetd
? avdtp/.deps
? avdtp/.libs
? avdtp/Makefile
? avdtp/Makefile.in
? avdtp/avtest
? sbc/.deps
? sbc/.libs
? sbc/Makefile
? sbc/Makefile.in
? sbc/rcplay
? sbc/sbcdec
? sbc/sbcenc
? sbc/sbcinfo
Index: a2dp.h
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/a2dp.h,v
retrieving revision 1.10

a2dp.h +4 -0

diff -u -r1.10 a2dp.h
@@ -220,10 +220,14 @@
 #define AVDTP_DISCOVER 1
 #define AVDTP_GET_CAPABILITIES 2
 #define AVDTP_SET_CONFIGURATION 3
+#define AVDTP_GET_CONFIGURATION 4
+#define AVDTP_RECONFIGURE 5
 #define AVDTP_OPEN 6
 #define AVDTP_START 7
 #define AVDTP_CLOSE 8
 #define AVDTP_SUSPEND 9
+#define AVDTP_ABORT 0xA
+#define AVDTP_SECURITY_CONTROL 0xB
 
 #define MEDIA_TRANSPORT_CATEGORY 1
 #define MEDIA_CODEC 7

Index: alsa-plugins/Makefile.am
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/Makefile.am,v retrieving revision 1.9

Makefile.am +1 -1

diff -u -r1.9 Makefile.am
@@ -27,7 +27,7 @@
 libasound_module_ctl_sco_la_LIBADD = @ALSA_LIBS@
 
 bin_PROGRAMS = a2dpd
-a2dpd_SOURCES = a2dpd.c a2dplib.c alsalib.c
+a2dpd_SOURCES = a2dpd.c a2dplib.c alsalib.c resample.c
 a2dpd_CFLAGS = $(AM_CFLAGS)
 #a2dp_timer.c a2dp_ipc.c
 a2dpd_LDADD = a2dp_timer.o a2dp_ipc.o @ALSA_LIBS@ @BLUEZ_LIBS@ -lsbc -lpthread -lrt

Index: alsa-plugins/a2dp_ipc.c
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dp_ipc.c,v retrieving revision 1.4

a2dp_ipc.c +4 -1

diff -u -r1.4 a2dp_ipc.c
@@ -100,6 +100,8 @@
 
         if(sockfd>0)
         {
+        	int on = 1;
+        	setsockopt(sockfd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
                 if(bind(sockfd, (struct sockaddr *)&my_addr, sizeof(struct sockaddr))==0)
                 {
                         if(listen(sockfd, 0)==0)

@@ -223,6 +225,7 @@
 {
         int found=0, error=0;
         FILE* hFile = fopen(filename, "rt");
+	returnbuffer[0] = 0;
         //printf("read_config_string: reading %s\n", filename);
         if(hFile)
         {

@@ -285,7 +288,7 @@
                 strncpy(returnbuffer, defvalue, buffersize);
                 returnbuffer[buffersize-1]=0;
         }
-        syslog(LOG_INFO, "%s [%s] '%s'='%s'", __FUNCTION__, section, key, returnbuffer);
+        //syslog(LOG_INFO, "%s [%s] '%s'='%s'", __FUNCTION__, section, key, returnbuffer);
 }
 
 int read_config_int(char* filename, char* section, char* key, int defvalue)

Index: alsa-plugins/a2dpd.c
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dpd.c,v retrieving revision 1.9

a2dpd.c +545 ~~-176~~

1,012 lines not on this page · raw message

Index: alsa-plugins/a2dpd_protocol.h
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dpd_protocol.h,v retrieving revision 1.4

a2dpd_protocol.h +20 -2

diff -u -r1.4 a2dpd_protocol.h
@@ -24,17 +24,35 @@
 
 #include <stdint.h>
 
-
 // parameters used to describe device state
 typedef struct {
 	int16_t volume_speaker_right;
 	int16_t volume_speaker_left;
 	int16_t volume_micro_right;
 	int16_t volume_micro_left;
-} AUDIOMIXERDATA;
+} __attribute__ ((packed)) AUDIOMIXERDATA;
 
 #define INVALIDAUDIOMIXERDATA   { -1, -1, -1, -1 }
 
+// PCM formats defined in alsa, we will restrict our selves to 8 and 16 bits
+#define A2DPD_PCM_FORMAT_UNKNOWN 0x00000000
+#define A2DPD_PCM_FORMAT_S8      0x00000001
+#define A2DPD_PCM_FORMAT_U8      0x00000002
+#define A2DPD_PCM_FORMAT_S16_LE  0x00000003
+//#define A2DPD_FORMAT_S16_BE        0x00000004
+//#define A2DPD_FORMAT_U16_LE        0x00000005
+//#define A2DPD_FORMAT_U16_BE        0x00000006
+
+// parameters used to describe device state
+typedef struct {
+	uint32_t format;
+	uint16_t rate;
+	uint8_t channels;
+	uint16_t bitspersample;
+} __attribute__ ((packed)) AUDIOSTREAMINFOS;
+
+#define INVALIDAUDIOSTREAMINFOS   { 0, 0, 0 }
+
 // Different types of client plugin for the daemon
 #define INVALID_CLIENT_TYPE     0xFFFFFFFF
 #define A2DPD_PLUGIN_CTL_WRITE  0x00000001

Index: alsa-plugins/a2dplib.c
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dplib.c,v retrieving revision 1.6

a2dplib.c +153 ~~-95~~

494 lines not on this page · raw message

Index: alsa-plugins/a2dplib.h
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dplib.h,v retrieving revision 1.4

a2dplib.h +9 -2

diff -u -r1.4 a2dplib.h
@@ -33,7 +33,6 @@
 
 #define A2DPMAXIMUMTRANSFERUNITSIZE 610
 
-
 // To send one L2CAP packets of 678 bytes, 4 ACL packets are sent, 3 are 192 bytes long, 
 // 1 contains 49 bytes  => loss 192-49/4
 // To send one L2CAP packets of 610 bytes, 3 ACL packets are sent, 2 are 192 bytes long,

@@ -46,7 +45,15 @@
 extern void a2dp_exit( void);
 
 // Connect to an a2dp provider
-extern LPA2DP a2dp_new( char* bdaddr, int framerate);
+typedef struct
+{
+	char bdaddr[32];
+	int framerate;
+	int channels;
+	int sbcbitpool;
+} A2DPSETTINGS;
+
+extern LPA2DP a2dp_new( A2DPSETTINGS* settings);
 extern void a2dp_destroy( LPA2DP a2dp);
 
 // compress and transfers data

Index: alsa-plugins/pcm_a2dpd.c
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/pcm_a2dpd.c,v retrieving revision 1.5

pcm_a2dpd.c +72 ~~-51~~

232 lines not on this page · raw message

Index: alsa-plugins/sample.a2dprc
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/sample.a2dprc,v retrieving revision 1.3

sample.a2dprc +13 -2

diff -u -r1.3 sample.a2dprc
@@ -2,15 +2,26 @@
 #
 # Rate
 # use 32000 if your headset seems to not support 44100 (HP works well at 44100, Sonorix at 32000)
-# Alsa output may not work depending on your graphics card
-# Very few players supports it (xmms does, but not amarok/gxine engine)
+# However, 44100 is mandatory
 #
 rate=44100
 #rate=32000
+
+#
+# plugin-rate default is the rate used between the plugin and the daemon
+# if this value is 0 then 
+# if this value is not 0 then alsa will convert all stream to the specified rate and then send it to the daemon
+# if this value is 0, then alsa will do no conversion at all, the daemon will do it's own resampling.
+# This "features" is disabled because of the crappy quality of the daemon resampler
+# To test a2dpd resampling from 32000 to 44100 use plugin-rate=32000 and rate=44100
+#plugin-rate=32000
+
+# Recommended
 enablereversestereo=1
 
 #
 # AVRCP Commands to run
+# If these entries are emptied, then some keyboard entry will be sent to /dev/uinput
 #
 cmdplay=xmms --play
 cmdpause=xmms --pause

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Brad Midgley

2006-11-08 03:41 UTC #1 lore raw

Fr=E9d=E9ric,

It all sounds very interesting... including avdtp additions.

The patch doesn't contain resample.h so I couldn't try it yet.

Brad

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easi= er
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1=
21642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Frédéric DALLEAU

author

2006-11-08 10:05 UTC #2 lore raw

Sorry Brad,
This is far more useful than whitespaces :D
Fred

Quoted 8 lines · Brad Midgley

Frédéric,
It all sounds very interesting... including avdtp additions.
The patch doesn't contain resample.h so I couldn't try it yet.
Brad

Quoted 10 lines

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

a2dp.h +4 -0

diff -u -d -u -p -r1.10 a2dp.h
@@ -220,10 +220,14 @@ struct media_payload_header {
 #define AVDTP_DISCOVER 1
 #define AVDTP_GET_CAPABILITIES 2
 #define AVDTP_SET_CONFIGURATION 3
+#define AVDTP_GET_CONFIGURATION 4
+#define AVDTP_RECONFIGURE 5
 #define AVDTP_OPEN 6
 #define AVDTP_START 7
 #define AVDTP_CLOSE 8
 #define AVDTP_SUSPEND 9
+#define AVDTP_ABORT 0xA
+#define AVDTP_SECURITY_CONTROL 0xB
 
 #define MEDIA_TRANSPORT_CATEGORY 1
 #define MEDIA_CODEC 7

Index: alsa-plugins/Makefile.am
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/Makefile.am,v retrieving revision 1.9

Makefile.am +1 -1

diff -u -d -u -p -r1.9 Makefile.am
@@ -27,7 +27,7 @@ libasound_module_ctl_sco_la_SOURCES = ct
 libasound_module_ctl_sco_la_LIBADD = @ALSA_LIBS@
 
 bin_PROGRAMS = a2dpd
-a2dpd_SOURCES = a2dpd.c a2dplib.c alsalib.c
+a2dpd_SOURCES = a2dpd.c a2dplib.c alsalib.c resample.c
 a2dpd_CFLAGS = $(AM_CFLAGS)
 #a2dp_timer.c a2dp_ipc.c
 a2dpd_LDADD = a2dp_timer.o a2dp_ipc.o @ALSA_LIBS@ @BLUEZ_LIBS@ -lsbc -lpthread -lrt

Index: alsa-plugins/a2dp_ipc.c
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dp_ipc.c,v retrieving revision 1.4

a2dp_ipc.c +4 -1

diff -u -d -u -p -r1.4 a2dp_ipc.c
@@ -100,6 +100,8 @@ int make_server_socket()
 
         if(sockfd>0)
         {
+        	int on = 1;
+        	setsockopt(sockfd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
                 if(bind(sockfd, (struct sockaddr *)&my_addr, sizeof(struct sockaddr))==0)
                 {
                         if(listen(sockfd, 0)==0)

@@ -223,6 +225,7 @@ void read_config_string(char* filename, 
 {
         int found=0, error=0;
         FILE* hFile = fopen(filename, "rt");
+	returnbuffer[0] = 0;
         //printf("read_config_string: reading %s\n", filename);
         if(hFile)
         {

@@ -285,7 +288,7 @@ void read_config_string(char* filename, 
                 strncpy(returnbuffer, defvalue, buffersize);
                 returnbuffer[buffersize-1]=0;
         }
-        syslog(LOG_INFO, "%s [%s] '%s'='%s'", __FUNCTION__, section, key, returnbuffer);
+        //syslog(LOG_INFO, "%s [%s] '%s'='%s'", __FUNCTION__, section, key, returnbuffer);
 }
 
 int read_config_int(char* filename, char* section, char* key, int defvalue)

Index: alsa-plugins/a2dpd.c
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dpd.c,v retrieving revision 1.9

a2dpd.c +545 ~~-176~~

1,012 lines not on this page · raw message

a2dpd_protocol.h +20 -2

diff -u -d -u -p -r1.4 a2dpd_protocol.h
@@ -24,17 +24,35 @@
 
 #include <stdint.h>
 
-
 // parameters used to describe device state
 typedef struct {
 	int16_t volume_speaker_right;
 	int16_t volume_speaker_left;
 	int16_t volume_micro_right;
 	int16_t volume_micro_left;
-} AUDIOMIXERDATA;
+} __attribute__ ((packed)) AUDIOMIXERDATA;
 
 #define INVALIDAUDIOMIXERDATA   { -1, -1, -1, -1 }
 
+// PCM formats defined in alsa, we will restrict our selves to 8 and 16 bits
+#define A2DPD_PCM_FORMAT_UNKNOWN 0x00000000
+#define A2DPD_PCM_FORMAT_S8      0x00000001
+#define A2DPD_PCM_FORMAT_U8      0x00000002
+#define A2DPD_PCM_FORMAT_S16_LE  0x00000003
+//#define A2DPD_FORMAT_S16_BE        0x00000004
+//#define A2DPD_FORMAT_U16_LE        0x00000005
+//#define A2DPD_FORMAT_U16_BE        0x00000006
+
+// parameters used to describe device state
+typedef struct {
+	uint32_t format;
+	uint16_t rate;
+	uint8_t channels;
+	uint16_t bitspersample;
+} __attribute__ ((packed)) AUDIOSTREAMINFOS;
+
+#define INVALIDAUDIOSTREAMINFOS   { 0, 0, 0 }
+
 // Different types of client plugin for the daemon
 #define INVALID_CLIENT_TYPE     0xFFFFFFFF
 #define A2DPD_PLUGIN_CTL_WRITE  0x00000001

Index: alsa-plugins/a2dplib.c
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dplib.c,v retrieving revision 1.6

a2dplib.c +152 ~~-94~~

493 lines not on this page · raw message

Index: alsa-plugins/a2dplib.h
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/a2dplib.h,v retrieving revision 1.4

a2dplib.h +9 -2

diff -u -d -u -p -r1.4 a2dplib.h
@@ -33,7 +33,6 @@
 
 #define A2DPMAXIMUMTRANSFERUNITSIZE 610
 
-
 // To send one L2CAP packets of 678 bytes, 4 ACL packets are sent, 3 are 192 bytes long, 
 // 1 contains 49 bytes  => loss 192-49/4
 // To send one L2CAP packets of 610 bytes, 3 ACL packets are sent, 2 are 192 bytes long,

@@ -46,7 +45,15 @@ extern void a2dp_init( void);
 extern void a2dp_exit( void);
 
 // Connect to an a2dp provider
-extern LPA2DP a2dp_new( char* bdaddr, int framerate);
+typedef struct
+{
+	char bdaddr[32];
+	int framerate;
+	int channels;
+	int sbcbitpool;
+} A2DPSETTINGS;
+
+extern LPA2DP a2dp_new( A2DPSETTINGS* settings);
 extern void a2dp_destroy( LPA2DP a2dp);
 
 // compress and transfers data

Index: alsa-plugins/pcm_a2dpd.c
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/pcm_a2dpd.c,v retrieving revision 1.5

pcm_a2dpd.c +72 ~~-51~~

232 lines not on this page · raw message

Index: alsa-plugins/resample.c
===================================================================
RCS file: alsa-plugins/resample.c

resample.c new file +337 -0

337 lines not on this page · raw message

Index: alsa-plugins/resample.h
===================================================================
RCS file: alsa-plugins/resample.h

resample.h new file +14 -0

diff -N alsa-plugins/resample.h
@@ -0,0 +1,14 @@
+#ifndef __RESAMPLE_H
+#define __RESAMPLE_H
+/* resample.c */
+
+struct ReSampleContext;
+
+typedef struct ReSampleContext ReSampleContext;
+
+ReSampleContext *audio_resample_init(int output_channels, int input_channels, 
+                                     int output_rate, int input_rate);
+int audio_resample(ReSampleContext *s, short *output, short *input, int nb_samples);
+void audio_resample_close(ReSampleContext *s);
+
+#endif

Index: alsa-plugins/sample.a2dprc
===================================================================
RCS file: /cvsroot/bluetooth-alsa/btsco/alsa-plugins/sample.a2dprc,v retrieving revision 1.3

sample.a2dprc +15 -2

diff -u -d -u -p -r1.3 sample.a2dprc
@@ -2,15 +2,28 @@
 #
 # Rate
 # use 32000 if your headset seems to not support 44100 (HP works well at 44100, Sonorix at 32000)
-# Alsa output may not work depending on your graphics card
-# Very few players supports it (xmms does, but not amarok/gxine engine)
+# However, 44100 is mandatory
 #
 rate=44100
 #rate=32000
+
+#
+# plugin-rate default is the rate used between the plugin and the daemon
+# if this value is not 0 then alsa will convert all stream to the specified rate and then send it to the daemon
+# if this value is 0, then alsa will do no conversion at all, the daemon will do it's own resampling.
+# This "features" is disabled because of the crappy quality of the daemon resampler
+# For example, to test a2dpd resampling from 32000 to 44100 use plugin-rate=32000 and rate=44100
+#plugin-rate=32000
+
+# Allows to specify the sbc bitpool, this can help reducing bandwith
+#sbcbitpool=32
+
+# Recommended
 enablereversestereo=1
 
 #
 # AVRCP Commands to run
+# If these entries are emptied, then some keyboard entry will be sent to /dev/uinput
 #
 cmdplay=xmms --play
 cmdpause=xmms --pause

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Hilzinger

2006-11-10 13:18 UTC #3 lore raw

Am Mittwoch, 8. November 2006 11:05 schrieb Fr=E9d=E9ric DALLEAU:

Quoted 3 lines

Sorry Brad,
This is far more useful than whitespaces :D
Fred

Hi Fr=E9d=E9ric,

I applied your patch on the cvs-code from today and now I get these errors =

randomly:

Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation fra=

me =

(len 0)

Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation fra=

me =

(len 0)

Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation fra=

me =

(len 0)

Nov 10 14:15:56 kim kernel: l2cap_recv_acldata: Unexpected continuation fra=

me =

(len 0)

the error means, that for 1-2 seconds there is no sound.

Any idea, if it's due to the patch or just "par hazard"?

-- =

Mit freundlichen Gr=FC=DFen,
Marcel Hilzinger

Linux New Media AG
S=FCskindstr. 4
D-81929 M=FCnchen
Tel: +49 (89) 99 34 11 0
Fax: +49 (89) 99 34 11 99

Marcel Hilzinger

2006-11-10 13:34 UTC #4 lore raw

Am Freitag, 10. November 2006 14:18 schrieb Marcel Hilzinger:

Quoted 17 lines

Am Mittwoch, 8. November 2006 11:05 schrieb Fr=E9d=E9ric DALLEAU:
Quoted 3 lines
Sorry Brad,
This is far more useful than whitespaces :D
Fred
Hi Fr=E9d=E9ric,
I applied your patch on the cvs-code from today and now I get these errors randomly:
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:56 kim kernel: l2cap_recv_acldata: Unexpected continuation

Quoted 6 lines

frame (len 0)
the error means, that for 1-2 seconds there is no sound.
Any idea, if it's due to the patch or just "par hazard"?

OK. It was me: I removed sbcbitpool=3D64 from .a2dpdrc. =

Now I put it back and the underruns are gone.

-- =

Mit freundlichen Gr=FC=DFen,
Marcel Hilzinger

Linux New Media AG
S=FCskindstr. 4
D-81929 M=FCnchen
Tel: +49 (89) 99 34 11 0
Fax: +49 (89) 99 34 11 99

Frédéric DALLEAU

author

2006-11-10 13:49 UTC #5 lore raw

Marcel Hilzinger a =E9crit :

Quoted 14 lines

Am Freitag, 10. November 2006 14:18 schrieb Marcel Hilzinger:
=
Quoted 11 lines
Am Mittwoch, 8. November 2006 11:05 schrieb Fr=E9d=E9ric DALLEAU:
    =
Quoted 4 lines
Sorry Brad,
This is far more useful than whitespaces :D
Fred
      =
Hi Fr=E9d=E9ric,
I applied your patch on the cvs-code from today and now I get these erro=

Quoted 18 lines

Quoted 9 lines
randomly:
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:56 kim kernel: l2cap_recv_acldata: Unexpected continuation
Quoted 7 lines
frame (len 0)
the error means, that for 1-2 seconds there is no sound.
Any idea, if it's due to the patch or just "par hazard"?
    =

Quoted 6 lines

OK. It was me: I removed sbcbitpool=3D64 from .a2dpdrc. =
Now I put it back and the underruns are gone.
=

This line is commented in the default file so it should not be the case. =

Does it work with 32.
Can you send me the faulty .a2dprc?

Marcel Hilzinger

2006-11-10 14:01 UTC #6 lore raw

Am Freitag, 10. November 2006 14:49 schrieb Fr=E9d=E9ric DALLEAU:

Quoted 24 lines

Marcel Hilzinger a =E9crit :
Quoted 23 lines
Am Freitag, 10. November 2006 14:18 schrieb Marcel Hilzinger:
Quoted 22 lines
Am Mittwoch, 8. November 2006 11:05 schrieb Fr=E9d=E9ric DALLEAU:
Quoted 3 lines
Sorry Brad,
This is far more useful than whitespaces :D
Fred
Hi Fr=E9d=E9ric,
I applied your patch on the cvs-code from today and now I get these errors randomly:
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:55 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
Nov 10 14:15:56 kim kernel: l2cap_recv_acldata: Unexpected continuation
frame (len 0)
the error means, that for 1-2 seconds there is no sound.

Quoted 8 lines

Quoted 5 lines
Quoted 1 line
Any idea, if it's due to the patch or just "par hazard"?
OK. It was me: I removed sbcbitpool=3D64 from .a2dpdrc.
Now I put it back and the underruns are gone.
This line is commented in the default file so it should not be the case. Does it work with 32.

With 32 i have some underruns, but not much. With 64 I have almost no =

problems. If I comment the option out, then they appear quite often.

Quoted 1 line

Can you send me the faulty .a2dprc?

#####################################
[a2dpd]
#
# Rate

# use 32000 if your headset seems to not support 44100 (HP works well at =

44100, Sonorix at 32000)
# Alsa output may not work depending on your graphics card
# Very few players supports it (xmms does, but not amarok/gxine engine) #
rate=3D44100
#rate=3D32000
enablereversestereo=3D1

#
# AVRCP Commands to run
#
cmdplay=3Dxmms --play
cmdpause=3Dxmms --pause
cmdprev=3Dxmms --rew
cmdnext=3Dxmms --fwd
#cmdprev=3Damarok --previous
#cmdnext=3Damarok --next
cmdnew=3Dxmms --play
# Put to 0 to ignore AVRCP (if your computer freezes when commands are =

received)
enableavrcp=3D1

#
# Audio routing
#
# If set to 1 (at a2dp startup only) a2dp will reread configuration file #=A0for audio routing changes each second enablerereadconfig=3D1

# 0 =3D> Bluetooth A2DP Sink
# 1 =3D> Alsa
enableredirectalsa=3D0

# Hint from Fr=E9d=E9ric
#sbcbitpool=3D32

# Your bluetooth headset address
address=3D00:13:17:70:44:5A # Jabra
#address=3D00:0D:44:58:11:CA # Logitech

# Address of your alsa output (default : plughw:0,0) you have to know what = to =

do
alsaoutput=3D

#########################
Linebreaks done by my mail client...

-- =

Mit freundlichen Gr=FC=DFen,
Marcel Hilzinger

Linux New Media AG
S=FCskindstr. 4
D-81929 M=FCnchen
Tel: +49 (89) 99 34 11 0
Fax: +49 (89) 99 34 11 99

Brad Midgley

2006-11-14 03:56 UTC #7 lore raw

In reply to Frédéric DALLEAU

Fr=E9d=E9ric

I applied it.

I like how the pitch is held more constant in spite of transmission =

errors. Before the pitch of a song would get wobbly when recovering from =

going out of range.

Quoted 10 lines

This is far more useful than whitespaces :D
Fred
=
Brad Midgley a =E9crit :
Quoted 5 lines
Fr=E9d=E9ric,
It all sounds very interesting... including avdtp additions.
The patch doesn't contain resample.h so I couldn't try it yet.

Brad