Skip to contentSkip to conversation

asihpi, snd_runtime_check assertions fixes

PATCH Applied Delio Brignoli 2 participants 2 messages Aug 5, 2005 – Aug 8, 2005

lore
Share & tools
lore

Delio Brignoli

author
#0 lore raw

PATCH 1/1 asihpi, snd_runtime_check assertions fixes

Hello,

in the rush I made some mistakes converting assertions to the snd_runtime_check, this patch fixes them, please apply.

Changelog:
*fixed snd_runtime_check assertions

Signed-off-by Delio Brignoli [email protected]

thanks
--
Delio Brignoli

pci/asihpi.c +7 -7
@@ -1174,7 +1174,7 @@
 	HPI_HCONTROL hControl = kcontrol->private_value;
 	HW16 source;
 
-	snd_runtime_check( func(phSubSys, hControl, &source) != 0 , return -EINVAL );
+	func(phSubSys, hControl, &source);
 
 	/* default to S/PDIF */
 	ucontrol->value.enumerated.item[0] = 0;

@@ -1199,7 +1199,7 @@
 	if ( ucontrol->value.enumerated.item[0] == 2 )
 		source = HPI_AESEBU_SOURCE_AESEBU;
 
-	snd_runtime_check( func(phSubSys, hControl, source) != 0, return -EINVAL );
+	snd_runtime_check( func(phSubSys, hControl, source) == 0, return -EINVAL );
 
 	return 1;
 }

@@ -1256,7 +1256,7 @@
 	HPI_HCONTROL hControl = kcontrol->private_value;
 	HW16 sync;
 
-	snd_runtime_check( HPI_AESEBU_Transmitter_GetClockSource(phSubSys, hControl, &sync) );
+	HPI_AESEBU_Transmitter_GetClockSource(phSubSys, hControl, &sync);
 
 	/* default to HPI_AESEBU_CLOCKSOURCE_ADAPTER */
 	ucontrol->value.enumerated.item[0] = 0;

@@ -1280,7 +1280,7 @@
 	if ( ucontrol->value.enumerated.item[0] == 1 )
 		sync = HPI_AESEBU_CLOCKSOURCE_AESEBU_SYNC;
 
-	snd_runtime_check( HPI_AESEBU_Transmitter_SetClockSource(phSubSys, hControl, sync) != 0, return -EINVAL );
+	snd_runtime_check( HPI_AESEBU_Transmitter_SetClockSource(phSubSys, hControl, sync) == 0, return -EINVAL );
 
 	return 1;
 }

@@ -1578,7 +1578,7 @@
 	asihpi_ctl_name_prefix( snd_control, asihpi_control );
 	strcat(snd_control->name, " Gain");
 
-	snd_runtime_check( ctl_add( card, snd_control, asihpi ) != 0, return -EINVAL );
+	snd_runtime_check( ctl_add( card, snd_control, asihpi ) == 0, return -EINVAL );
 
 /* Band ctl */
 

@@ -1590,7 +1590,7 @@
 	asihpi_ctl_name_prefix( snd_control, asihpi_control );
 	strcat(snd_control->name, " Band");
 
-	snd_runtime_check( ctl_add( card, snd_control, asihpi ) != 0, return -EINVAL );
+	snd_runtime_check( ctl_add( card, snd_control, asihpi ) == 0, return -EINVAL );
 
 /* Freq ctl */
 

@@ -1602,7 +1602,7 @@
 	asihpi_ctl_name_prefix( snd_control, asihpi_control );
 	strcat(snd_control->name, " Freq");
 
-	snd_runtime_check( ctl_add( card, snd_control, asihpi ) != 0, return -EINVAL );
+	snd_runtime_check( ctl_add( card, snd_control, asihpi ) == 0, return -EINVAL );
 
 /* Level meter */
Applied
#1 lore raw

At Fri, 5 Aug 2005 15:06:58 -0700,

Quoted 10 lines · Delio Brignoli

Hello,

in the rush I made some mistakes converting assertions to the snd_runtime_check, this patch fixes them, please apply.

Changelog:
*fixed snd_runtime_check assertions

Signed-off-by Delio Brignoli [email protected]

Applied. Thanks!

Takashi

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf