Skip to contentSkip to conversation

drm/meson: fix TMDS clock filtering for DMT monitors

PATCH In review Neil Armstrong 2 participants 3 messages Mar 20, 2019 – Mar 25, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/meson: fix TMDS clock filtering for DMT monitors

DMT monitors does not necessarely report a maximum TMDS clock in a VSDB EDID extension.

In this case, all modes are wrongly rejected, including the DRM fallback EDID.

This patch only rejects modes whith clock > max_tmds_clock if the max_tmds_clock is specified. This will only reject 4:2:0 HDMI2.0 modes, who reports a clock > max_tmds_clock.

Fixes d7d8fb7046b6 ("drm/meson: add HDMI div40 TMDS mode")
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/meson/meson_dw_hdmi.c +2 -1
index e28814f4ea6c..563953ec6ad0 100644
@@ -569,7 +569,8 @@ dw_hdmi_mode_valid(struct drm_connector *connector,
 	DRM_DEBUG_DRIVER("Modeline " DRM_MODE_FMT "\n", DRM_MODE_ARG(mode));
 
 	/* If sink max TMDS clock, we reject the mode */
-	if (mode->clock > connector->display_info.max_tmds_clock)
+	if (connector->display_info.max_tmds_clock &&
+	    mode->clock > connector->display_info.max_tmds_clock)
 		return MODE_BAD;
 
 	/* Check against non-VIC supported modes */
Signature · 1 line
2.21.0
Tested-by Reviewed-by on v1 1/1
#1 lore raw

Hi Neil,

Quoted 33 lines · Neil Armstrong

DMT monitors does not necessarely report a maximum TMDS clock in a VSDB EDID extension.

In this case, all modes are wrongly rejected, including the DRM fallback EDID.

This patch only rejects modes whith clock > max_tmds_clock if the max_tmds_clock is specified. This will only reject 4:2:0 HDMI2.0 modes, who reports a clock > max_tmds_clock.

Fixes d7d8fb7046b6 ("drm/meson: add HDMI div40 TMDS mode")
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/meson/meson_dw_hdmi.c +2 -2
index e28814f4ea6c..563953ec6ad0 100644
@@ -569,7 +569,8 @@ dw_hdmi_mode_valid(struct drm_connector *connector,
        DRM_DEBUG_DRIVER("Modeline " DRM_MODE_FMT "\n", DRM_MODE_ARG(mode));
 
        /* If sink max TMDS clock, we reject the mode */
-       if (mode->clock > connector->display_info.max_tmds_clock)
+       if (connector->display_info.max_tmds_clock &&
+           mode->clock > connector->display_info.max_tmds_clock)
                return MODE_BAD;
 
        /* Check against non-VIC supported modes */
--
Quoted 2 lines

2.21.0

Thanks, this patch restores HDMI output with my old 1080p TV which does not specify a max tmds clock in its EDID. (all modes were considered BAD before).

#2 lore raw
In reply to Neil Armstrong
Quoted 23 lines · Neil Armstrong

DMT monitors does not necessarely report a maximum TMDS clock in a VSDB EDID extension.

In this case, all modes are wrongly rejected, including the DRM fallback EDID.

This patch only rejects modes whith clock > max_tmds_clock if the max_tmds_clock is specified. This will only reject 4:2:0 HDMI2.0 modes, who reports a clock > max_tmds_clock.

Fixes d7d8fb7046b6 ("drm/meson: add HDMI div40 TMDS mode")
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/meson/meson_dw_hdmi.c +0 -0
index e28814f4ea6c..563953ec6ad0 100644

drivers/gpu/drm/meson/meson_dw_hdmi.c dw_hdmi_mode_valid(struct drm_connector *connector, · line 576

Quoted 9 lines
drivers/gpu/drm/meson/meson_dw_hdmi.c +2 -1
@@ -569,7 +569,8 @@ dw_hdmi_mode_valid(struct drm_connector *connector,
 	DRM_DEBUG_DRIVER("Modeline " DRM_MODE_FMT "\n", DRM_MODE_ARG(mode));
 
 	/* If sink max TMDS clock, we reject the mode */
-	if (mode->clock > connector->display_info.max_tmds_clock)
+	if (connector->display_info.max_tmds_clock &&
+	    mode->clock > connector->display_info.max_tmds_clock)
 		return MODE_BAD;
 
 	/* Check against non-VIC supported modes */

Applied to drm-misc-fixes
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel