Skip to contentSkip to conversation

Fix Kconfig wrt CRC32 [8/9]

GFS2 Steven Whitehouse 2 participants 7 messages Nov 24, 2006 – Nov 29, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
Quoted 1 line

From 6f788fd00c82533d4cd5587a9706f8468658a24d Mon Sep 17 00:00:00 2001

From: Steven Whitehouse <[email protected]>
Date: Mon, 20 Nov 2006 10:04:49 -0500
Subject: [PATCH] [GFS2] Fix Kconfig wrt CRC32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GFS2 requires the CRC32 library function. This was reported by Toralf Förster.

---
 fs/gfs2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/gfs2/Kconfig +1 -0
index 8c27de8..c0791cb 100644
@@ -2,6 +2,7 @@ config GFS2_FS
 	tristate "GFS2 file system support"
 	depends on EXPERIMENTAL
 	select FS_POSIX_ACL
+	select CRC32
 	help
 	A cluster filesystem.
 
Signature · 1 line
1.4.1
#1 lore raw
Quoted 21 lines · On Fri, 24 Nov 2006 09:34:49 +0000 Steven Whitehouse wrote:
Quoted 1 line

From 6f788fd00c82533d4cd5587a9706f8468658a24d Mon Sep 17 00:00:00 2001

From: Steven Whitehouse <[email protected]>
Date: Mon, 20 Nov 2006 10:04:49 -0500
Subject: [PATCH] [GFS2] Fix Kconfig wrt CRC32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GFS2 requires the CRC32 library function. This was reported by Toralf Förster.

---
 fs/gfs2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/gfs2/Kconfig +0 -0
index 8c27de8..c0791cb 100644

fs/gfs2/Kconfig config GFS2_FS · line 7

Quoted 6 lines
fs/gfs2/Kconfig +1 -0
@@ -2,6 +2,7 @@ config GFS2_FS
 	tristate "GFS2 file system support"
 	depends on EXPERIMENTAL
 	select FS_POSIX_ACL
+	select CRC32
 	help
 	A cluster filesystem.

Hi,

Do you also have Kconfig patches for DLM needing SYSFS and DLM needing CONFIG_NET ?

---
~Randy

#2 lore raw

Hi,

Quoted 32 lines · Randy Dunlap
Quoted 21 lines · On Fri, 24 Nov 2006 09:34:49 +0000 Steven Whitehouse wrote:
Quoted 1 line

From 6f788fd00c82533d4cd5587a9706f8468658a24d Mon Sep 17 00:00:00 2001

From: Steven Whitehouse <[email protected]>
Date: Mon, 20 Nov 2006 10:04:49 -0500
Subject: [PATCH] [GFS2] Fix Kconfig wrt CRC32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GFS2 requires the CRC32 library function. This was reported by Toralf Förster.

---
 fs/gfs2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/gfs2/Kconfig +0 -0
index 8c27de8..c0791cb 100644

fs/gfs2/Kconfig config GFS2_FS · line 7

Quoted 6 lines
fs/gfs2/Kconfig +1 -0
@@ -2,6 +2,7 @@ config GFS2_FS
 	tristate "GFS2 file system support"
 	depends on EXPERIMENTAL
 	select FS_POSIX_ACL
+	select CRC32
 	help
 	A cluster filesystem.

Hi,

Quoted 5 lines

Do you also have Kconfig patches for DLM needing SYSFS and DLM needing CONFIG_NET ?

---
~Randy

My original reply to this seemed to disappear into my email system somewhere, so apologies if this is the second copy you get.

The DLM shouldn't depend upon SYSFS at all. I believe that its perfectly ok whether or not thats compiled in. There is a patch relating to the Kconfig for DLM which is in my -nmw tree:

http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=8758fbc8724c2da8a6a062f2b61d79c8f2a55c5f

This applies after the patch adding the TCP communications layer to DLM which is also in -nmw. The patches in -nmw (next merge window) are a superset of the ones I just requested that Linus pull since it contains the newer features and more involved bug fixes and clean ups.

I believe that the Kconfig in -nmw is correct for DLM, though I'm willing to be proved wrong. I'm also copying in Patrick in case he wants to comment further as its more his area than mine,

Steve.

#3 lore raw
Quoted 40 lines · Steven Whitehouse

Hi,

Quoted 31 lines · Randy Dunlap
Quoted 21 lines · On Fri, 24 Nov 2006 09:34:49 +0000 Steven Whitehouse wrote:
Quoted 1 line

From 6f788fd00c82533d4cd5587a9706f8468658a24d Mon Sep 17 00:00:00 2001

From: Steven Whitehouse <[email protected]>
Date: Mon, 20 Nov 2006 10:04:49 -0500
Subject: [PATCH] [GFS2] Fix Kconfig wrt CRC32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GFS2 requires the CRC32 library function. This was reported by Toralf F?rster.

---
 fs/gfs2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/gfs2/Kconfig +0 -0
index 8c27de8..c0791cb 100644

fs/gfs2/Kconfig config GFS2_FS · line 7

Quoted 6 lines
fs/gfs2/Kconfig +1 -0
@@ -2,6 +2,7 @@ config GFS2_FS
 	tristate "GFS2 file system support"
 	depends on EXPERIMENTAL
 	select FS_POSIX_ACL
+	select CRC32
 	help
 	A cluster filesystem.

Hi,

Quoted 5 lines

Do you also have Kconfig patches for DLM needing SYSFS and DLM needing CONFIG_NET ?

---
~Randy

Quoted 6 lines

My original reply to this seemed to disappear into my email system somewhere, so apologies if this is the second copy you get.

The DLM shouldn't depend upon SYSFS at all. I believe that its perfectly ok whether or not thats compiled in. There is a patch relating to the Kconfig for DLM which is in my -nmw tree:

Hm, OK. Apparently I meant CONFIGFS instead of SYSFS.

Quoted 10 lines

http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=8758fbc8724c2da8a6a062f2b61d79c8f2a55c5f

This applies after the patch adding the TCP communications layer to DLM which is also in -nmw. The patches in -nmw (next merge window) are a superset of the ones I just requested that Linus pull since it contains the newer features and more involved bug fixes and clean ups.

I believe that the Kconfig in -nmw is correct for DLM, though I'm willing to be proved wrong. I'm also copying in Patrick in case he wants to comment further as its more his area than mine,

I applied just that one patch to 2.6.19-rc6-git10 (which may or may not be sufficient -- please say) and built with my previously failing config file. It still fails with:

WARNING: "kernel_sendmsg" [fs/dlm/dlm.ko] undefined!
WARNING: "sock_release" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_put" [fs/dlm/dlm.ko] undefined!
WARNING: "sock_create_kern" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_init_type_name" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_init_type_name" [fs/dlm/dlm.ko] undefined!
WARNING: "configfs_register_subsystem" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_find_obj" [fs/dlm/dlm.ko] undefined!
WARNING: "configfs_unregister_subsystem" [fs/dlm/dlm.ko] undefined!
WARNING: "kernel_recvmsg" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_get" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_init" [fs/dlm/dlm.ko] undefined!
CC arch/x86_64/boot/compressed/misc.o
OBJCOPY arch/x86_64/boot/compressed/vmlinux.bin
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

config attached.

Signature · 5 lines
~Randy
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: config-dlm-needs
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20061127/ef7c5bec/attachment.ksh>
#4 lore raw

Hi,

Quoted 41 lines · Randy Dunlap
Quoted 40 lines · Steven Whitehouse

Hi,

Quoted 36 lines · Randy Dunlap
Quoted 21 lines · On Fri, 24 Nov 2006 09:34:49 +0000 Steven Whitehouse wrote:
Quoted 1 line

From 6f788fd00c82533d4cd5587a9706f8468658a24d Mon Sep 17 00:00:00 2001

From: Steven Whitehouse <[email protected]>
Date: Mon, 20 Nov 2006 10:04:49 -0500
Subject: [PATCH] [GFS2] Fix Kconfig wrt CRC32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GFS2 requires the CRC32 library function. This was reported by Toralf F?rster.

---
 fs/gfs2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/gfs2/Kconfig +0 -0
index 8c27de8..c0791cb 100644

fs/gfs2/Kconfig config GFS2_FS · line 7

Quoted 6 lines
fs/gfs2/Kconfig +1 -0
@@ -2,6 +2,7 @@ config GFS2_FS
 	tristate "GFS2 file system support"
 	depends on EXPERIMENTAL
 	select FS_POSIX_ACL
+	select CRC32
 	help
 	A cluster filesystem.

Hi,

Do you also have Kconfig patches for DLM needing SYSFS and DLM needing CONFIG_NET ?

---
~Randy

Quoted 9 lines
Quoted 6 lines

My original reply to this seemed to disappear into my email system somewhere, so apologies if this is the second copy you get.

The DLM shouldn't depend upon SYSFS at all. I believe that its perfectly ok whether or not thats compiled in. There is a patch relating to the Kconfig for DLM which is in my -nmw tree:

Hm, OK. Apparently I meant CONFIGFS instead of SYSFS.

The Kconfig for DLM in Linus' current tree says:
select CONFIGFS_FS

so I don't know what else is needed.... its the same in -nmw as that bit hasn't changed.

Quoted 7 lines
Quoted 7 lines

http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=8758fbc8724c2da8a6a062f2b61d79c8f2a55c5f

This applies after the patch adding the TCP communications layer to DLM which is also in -nmw. The patches in -nmw (next merge window) are a superset of the ones I just requested that Linus pull since it contains the newer features and more involved bug fixes and clean ups.

Quoted 6 lines
Quoted 3 lines

I believe that the Kconfig in -nmw is correct for DLM, though I'm willing to be proved wrong. I'm also copying in Patrick in case he wants to comment further as its more his area than mine,

I applied just that one patch to 2.6.19-rc6-git10 (which may or may not be sufficient -- please say) and built with my previously failing config file.

You'll need the patch:
http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=4a28fda50d864ede7d2724723949407e0e4043b8
as well. I'm also slightly surprised that you managed to get the errors that you did, since most of those symbols appear to be networking related and the DLM depends on INET which is clearly not set since NET is not set.

Quoted 19 lines

It still fails with:

WARNING: "kernel_sendmsg" [fs/dlm/dlm.ko] undefined!
WARNING: "sock_release" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_put" [fs/dlm/dlm.ko] undefined!
WARNING: "sock_create_kern" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_init_type_name" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_init_type_name" [fs/dlm/dlm.ko] undefined!
WARNING: "configfs_register_subsystem" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_find_obj" [fs/dlm/dlm.ko] undefined!
WARNING: "configfs_unregister_subsystem" [fs/dlm/dlm.ko] undefined!
WARNING: "kernel_recvmsg" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_get" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_init" [fs/dlm/dlm.ko] undefined!
CC arch/x86_64/boot/compressed/misc.o
OBJCOPY arch/x86_64/boot/compressed/vmlinux.bin
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Which of the various methods (oldconfig, xconfig, menuconfig, etc) did you use to generate this config?

Steve.

#5 lore raw
Quoted 67 lines · Steven Whitehouse

Hi,

Quoted 40 lines · Randy Dunlap
Quoted 39 lines · Steven Whitehouse

Hi,

Quoted 36 lines · Randy Dunlap
Quoted 21 lines · On Fri, 24 Nov 2006 09:34:49 +0000 Steven Whitehouse wrote:
Quoted 1 line

From 6f788fd00c82533d4cd5587a9706f8468658a24d Mon Sep 17 00:00:00 2001

From: Steven Whitehouse <[email protected]>
Date: Mon, 20 Nov 2006 10:04:49 -0500
Subject: [PATCH] [GFS2] Fix Kconfig wrt CRC32
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GFS2 requires the CRC32 library function. This was reported by Toralf Förster.

---
 fs/gfs2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/gfs2/Kconfig +0 -0
index 8c27de8..c0791cb 100644

fs/gfs2/Kconfig config GFS2_FS · line 7

Quoted 6 lines
fs/gfs2/Kconfig +1 -0
@@ -2,6 +2,7 @@ config GFS2_FS
 	tristate "GFS2 file system support"
 	depends on EXPERIMENTAL
 	select FS_POSIX_ACL
+	select CRC32
 	help
 	A cluster filesystem.

Hi,

Do you also have Kconfig patches for DLM needing SYSFS and DLM needing CONFIG_NET ?

---
~Randy

Quoted 8 lines
Quoted 6 lines

My original reply to this seemed to disappear into my email system somewhere, so apologies if this is the second copy you get.

The DLM shouldn't depend upon SYSFS at all. I believe that its perfectly ok whether or not thats compiled in. There is a patch relating to the Kconfig for DLM which is in my -nmw tree:

Hm, OK. Apparently I meant CONFIGFS instead of SYSFS.

The Kconfig for DLM in Linus' current tree says:
select CONFIGFS_FS

so I don't know what else is needed.... its the same in -nmw as that bit hasn't changed.

Quoted 10 lines
Quoted 10 lines

http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=8758fbc8724c2da8a6a062f2b61d79c8f2a55c5f

This applies after the patch adding the TCP communications layer to DLM which is also in -nmw. The patches in -nmw (next merge window) are a superset of the ones I just requested that Linus pull since it contains the newer features and more involved bug fixes and clean ups.

I believe that the Kconfig in -nmw is correct for DLM, though I'm willing to be proved wrong. I'm also copying in Patrick in case he wants to comment further as its more his area than mine,

Quoted 8 lines
Quoted 2 lines

I applied just that one patch to 2.6.19-rc6-git10 (which may or may not be sufficient -- please say) and built with my previously failing config file.

You'll need the patch:
http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=4a28fda50d864ede7d2724723949407e0e4043b8
as well. I'm also slightly surprised that you managed to get the errors that you did, since most of those symbols appear to be networking related and the DLM depends on INET which is clearly not set since NET is not set.

Thanks, I'll apply that patch also and test again.

Part of the problem (IMO) is that kconfig s/w doesn't follow dependency chains when applying "select"s.

Quoted 19 lines
Quoted 19 lines

It still fails with:

WARNING: "kernel_sendmsg" [fs/dlm/dlm.ko] undefined!
WARNING: "sock_release" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_put" [fs/dlm/dlm.ko] undefined!
WARNING: "sock_create_kern" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_init_type_name" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_init_type_name" [fs/dlm/dlm.ko] undefined!
WARNING: "configfs_register_subsystem" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_find_obj" [fs/dlm/dlm.ko] undefined!
WARNING: "configfs_unregister_subsystem" [fs/dlm/dlm.ko] undefined!
WARNING: "kernel_recvmsg" [fs/dlm/dlm.ko] undefined!
WARNING: "config_item_get" [fs/dlm/dlm.ko] undefined!
WARNING: "config_group_init" [fs/dlm/dlm.ko] undefined!
CC arch/x86_64/boot/compressed/misc.o
OBJCOPY arch/x86_64/boot/compressed/vmlinux.bin
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Quoted 2 lines

Which of the various methods (oldconfig, xconfig, menuconfig, etc) did you use to generate this config?

make randconfig

Signature · 1 line
~Randy
#6 lore raw

Hi,

Quoted 1 line · Randy Dunlap

Steven Whitehouse wrote:

[bits snipped to cut down size of reply]

Quoted 7 lines
Quoted 6 lines

You'll need the patch:
http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=4a28fda50d864ede7d2724723949407e0e4043b8
as well. I'm also slightly surprised that you managed to get the errors that you did, since most of those symbols appear to be networking related and the DLM depends on INET which is clearly not set since NET is not set.

Quoted 5 lines

Thanks, I'll apply that patch also and test again.

Part of the problem (IMO) is that kconfig s/w doesn't follow dependency chains when applying "select"s.

Ah, light begins to dawn :-) Sorry for being a bit slow on the uptake... I think I see what the problem might be now. I've attached a patch as a possible solution, let me know if you agree. Its against my -nmw tree, so for the current upstream it would be the same except for not needing the "if DLM_SCTP" on the end of the select line,

Steve.

fs/dlm/Kconfig +1 -1
index b5654a2..a1d083d 100644
@@ -1,5 +1,5 @@
 menu "Distributed Lock Manager"
-	depends on EXPERIMENTAL && INET
+	depends on EXPERIMENTAL && NET && INET
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
fs/gfs2/Kconfig +3 -1
index c0791cb..6a2ffa2 100644
@@ -34,7 +34,9 @@ config GFS2_FS_LOCKING_NOLOCK
 
 config GFS2_FS_LOCKING_DLM
 	tristate "GFS2 DLM locking module"
-	depends on GFS2_FS
+	depends on GFS2_FS && NET && INET && (IPV6 || IPV6=n)
+	select IP_SCTP if DLM_SCTP
+	select CONFIGFS_FS
 	select DLM
 	help
 	Multiple node locking module for GFS2