Skip to contentSkip to conversation

Add loglevels to all printk()s

PATCH Applied Roland Dreier 2 participants 3 messages Nov 29, 2006 – Nov 30, 2006 2 messages not in the archive KVM

lore
Share & tools
lore

Roland Dreier

author
#0 lore raw

PATCH 1/1 Add loglevels to all printk()s

Here's a trivial patch that adds log levels to all printks. This avoids ugly things like

Message from syslogd@roland-xeon-2 at Wed Nov 29 14:01:01 2006 ... roland-xeon-2 kernel: [81842.565619] msrs: 6

popping up in a console on my system when starting a guest.

---

kernel/vmx.c +1 -1
@@ -1153,7 +1153,7 @@
 		vcpu->guest_msrs[j] = vcpu->host_msrs[j];
 		++vcpu->nmsrs;
 	}
-	printk("msrs: %d\n", vcpu->nmsrs);
+	printk(KERN_DEBUG "kvm: msrs: %d\n", vcpu->nmsrs);
 
 	nr_good_msrs = vcpu->nmsrs - NR_BAD_MSRS;
 	vmcs_writel(VM_ENTRY_MSR_LOAD_ADDR,
kernel/svm.c +2 -2
@@ -990,7 +990,7 @@
 
 		addr_mask = io_adress(vcpu, _in, &kvm_run->io.address);
 		if (!addr_mask) {
-			printk("%s: get io address failed\n", __FUNCTION__);
+			printk(KERN_DEBUG "%s: get io address failed\n", __FUNCTION__);
 			return 1;
 		}
 

@@ -1030,7 +1030,7 @@
 
 static int task_switch_interception(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
 {
-	printk("%s: task swiche is unsupported\n", __FUNCTION__);
+	printk(KERN_DEBUG "%s: task swiche is unsupported\n", __FUNCTION__);
 	kvm_run->exit_reason = KVM_EXIT_UNKNOWN;
 	return 0;
 }

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#2 lore raw
Quoted 8 lines · Roland Dreier

Here's a trivial patch that adds log levels to all printks. This avoids ugly things like

Message from syslogd@roland-xeon-2 at Wed Nov 29 14:01:01 2006 ... roland-xeon-2 kernel: [81842.565619] msrs: 6

popping up in a console on my system when starting a guest.

Applied, thanks. Please add signed-off-by's in the future, even to trivial patches.

Signature · 8 lines
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

A message that is not in the archive (sent off-list or not yet received): 456E9D54.50306-atKUWr5tajBWk0Htik3J/[email protected]

author
#4 lore raw
Quoted 2 lines

Applied, thanks. Please add signed-off-by's in the future, even to trivial patches.

Will do. I wasn't aware you were tracking s-o-b lines, since I didn't see any in your revision log.

- R.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV