Skip to contentSkip to conversation

softmac: fix unbalanced mutex_lock/unlock in ieee80211softmac_wx_set_mlme

PATCH New Larry Finger 1 participant 1 message Dec 3, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 softmac: fix unbalanced mutex_lock/unlock in ieee80211softmac_wx_set_mlme

From: Maxime Austruy <maxime-+3Uz/[email protected]>

Routine ieee80211softmac_wx_set_mlme has one return that fails to release a mutex acquired at entry.

---

John and Chris,

This error was introduced in the 2.6.19-rxX series and must be applied to 2.6.19-stable and wireless-2.6.

Larry

 net/ieee80211/softmac/ieee80211softmac_wx.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/ieee80211/softmac/ieee80211softmac_wx.c +2 -1
@@ -495,7 +495,8 @@ ieee80211softmac_wx_set_mlme(struct net_
 			printk(KERN_DEBUG PFX "wx_set_mlme: we should know the net here...\n");
 			goto out;
 		}
-		return ieee80211softmac_deauth_req(mac, net, reason);
+		err =  ieee80211softmac_deauth_req(mac, net, reason);
+		goto out;
 	case IW_MLME_DISASSOC:
 		ieee80211softmac_send_disassoc_req(mac, reason);
 		mac->associnfo.associated = 0;

-
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html