Skip to contentSkip to conversation

dm snapshot: fix freeing pending exception

PATCH In review Milan Broz 2 participants 2 messages Dec 5, 2006 – Dec 6, 2006 Device mapper

lore
Share & tools
lore

Milan Broz

author
#0 lore raw

PATCH 1/1 dm snapshot: fix freeing pending exception

Fix oops when removing full snapshot
kernel bugzilla bug 7040

If a snapshot became invalid (full) while there is outstanding pending_exception, pending_complete() forgets to remove
the corresponding exception from its exception table before freeing it.

Already fixed in 2.6.19.

drivers/md/dm-snap.c +1 -0
Index: linux-2.6.18.5/drivers/md/dm-snap.c
===================================================================
@@ -691,6 +691,7 @@ static void pending_complete(struct pend
 
 		free_exception(e);
 
+		remove_exception(&pe->e);
 		error_snapshot_bios(pe);
 		goto out;
 	}