Skip to contentSkip to conversation

several oopses of nfsd in 2.6.16.29 (patch)

DISCUSSION Kevin Jamieson 1 participant 1 message Dec 6, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
Quoted 4 lines · Kevin Jamieson

I am seeing similar oopses on a 2.6.16.21 Linux server in conjunction with a Solaris 8 client using NFSv2 with ACL support enabled (although no ACLs actually created). The problem does not occur with NFSv3 or with ACL support disabled.

I believe I've tracked the problem I'm seeing down to the release function for the setacl/getattr/access procedures in fs/nfsd/nfs2acl.c having the wrong type for the resp parameter.

The below patch (against SuSE's 2.6.16.21-0.8) appears to resolve the problem (in limited testing thus far).

Kevin

fs/nfsd/nfs2acl.c renamed from fs/nfsd/nfs2acl.c.bak +12 -5
@@ -287,8 +287,15 @@
 	return 1;
 }
 
-static int nfsaclsvc_release_fhandle(struct svc_rqst *rqstp, u32 *p,
-		struct nfsd_fhandle *resp)
+static int nfsaclsvc_release_attrstat(struct svc_rqst *rqstp, u32 *p,
+		struct nfsd_attrstat *resp)
+{
+	fh_put(&resp->fh);
+	return 1;
+}
+
+static int nfsaclsvc_release_access(struct svc_rqst *rqstp, u32 *p,
+		struct nfsd3_accessres *resp)
 {
 	fh_put(&resp->fh);
 	return 1;
@@ -322,9 +329,9 @@
 static struct svc_procedure		nfsd_acl_procedures2[] = {
   PROC(null,	void,		void,		void,	  RC_NOCACHE, ST),
   PROC(getacl,	getacl,		getacl,		getacl,	  RC_NOCACHE, ST+1+2*(1+ACL)),
-  PROC(setacl,	setacl,		attrstat,	fhandle,  RC_NOCACHE, ST+AT),
-  PROC(getattr, fhandle,	attrstat,	fhandle,  RC_NOCACHE, ST+AT),
-  PROC(access,	access,		access,		fhandle,  RC_NOCACHE, ST+AT+1),
+  PROC(setacl,	setacl,		attrstat,	attrstat, RC_NOCACHE, ST+AT),
+  PROC(getattr, fhandle,	attrstat,	attrstat, RC_NOCACHE, ST+AT),
+  PROC(access,	access,		access,		access,   RC_NOCACHE, ST+AT+1),
 };
 
 struct svc_version	nfsd_acl_version2 = {

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs