Skip to contentSkip to conversation

pcieport-driver: remove invalid warning message

PATCH New Kenji Kaneshige 1 participant 1 message Dec 6, 2006 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcieport-driver: remove invalid warning message

Hi,

I got the following warning messages on some PCI Express ports.

    pcie_portdrv_probe->Dev[1263:10cf] has invalid IRQ. Check vendor BIOS

I think this message is improper because those PCI Express ports don't use an interrupt pin. This message should not be displayed for devices which don't use an interrupt pin.

Thanks,
Kenji Kaneshige

The following warning message should not be displayed for devices which don't use an interrupt pin.

    pcie_portdrv_probe->Dev[XXXX:XXXX] has invalid IRQ. Check vendor BIOS
---
 drivers/pci/pcie/portdrv_pci.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pcie/portdrv_pci.c +1 -1
Index: linux-2.6.19/drivers/pci/pcie/portdrv_pci.c
===================================================================
@@ -90,7 +90,7 @@
 		return -ENODEV;
 	
 	pci_set_master(dev);
-        if (!dev->irq) {
+        if (!dev->irq && dev->pin) {
 		printk(KERN_WARNING 
 		"%s->Dev[%04x:%04x] has invalid IRQ. Check vendor BIOS\n", 
 		__FUNCTION__, dev->device, dev->vendor);