Skip to contentSkip to conversation

ensure unique i_ino in filesystems without permanent inode numbers (pipefs)

PATCH In review Jeff Layton 1 participant 2 messages Dec 7, 2006 – Dec 9, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 3/3 ensure unique i_ino in filesystems without permanent inode numbers (pipefs)

pipefs is a rather busy filesystem and so is a good place to start to make sure we flush out any performance problems

fs/pipe.c +3 -0
index b1626f2..d74ae65 100644
@@ -845,6 +845,9 @@ static struct inode * get_pipe_inode(voi
 	if (!inode)
 		goto fail_inode;
 
+	if (iunique_register(inode, 0))
+		goto fail_iput;
+
 	pipe = alloc_pipe_info(inode);
 	if (!pipe)
 		goto fail_iput;
#1 lore raw
Quoted 3 lines · Jeff Layton

pipefs is a rather busy filesystem and so is a good place to start to make sure we flush out any performance problems

This patch changes the earlier patch to use the new_registered_inode wrapper and that simplifies things a bit. It also goes ahead and changes over sockfs in the same way.

fs/pipe.c +1 -1
index f8b6bdc..4d30f49 100644
@@ -846,7 +846,7 @@ static struct dentry_operations pipefs_d
 
 static struct inode * get_pipe_inode(void)
 {
-	struct inode *inode = new_inode(pipe_mnt->mnt_sb);
+	struct inode *inode = new_registered_inode(pipe_mnt->mnt_sb, 0);
 	struct pipe_inode_info *pipe;
 
 	if (!inode)
net/socket.c +1 -1
index 4e39631..ec63a96 100644
@@ -486,7 +486,7 @@ static struct socket *sock_alloc(void)
 	struct inode *inode;
 	struct socket *sock;
 
-	inode = new_inode(sock_mnt->mnt_sb);
+	inode = new_registered_inode(sock_mnt->mnt_sb, 0);
 	if (!inode)
 		return NULL;