Skip to contentSkip to conversation

GFS2 rename race - lock reordering

RFC In review Wendy Cheng 1 participant 2 messages Dec 12, 2006

lore
Share & tools
lore
#0 lore raw

RFC 2/3 GFS2 rename race - lock reordering

Currently GFS2 only obtains its rename global locks if the "source" is a directory. This could result a deadlock if:

- Node 1 does "rename dir1/file-a dir2/file-b"
- Node 2 does "rename dir2/file-c dir1/file-a"

We'll unconditionally grab the global lock from now on unless the "source" and "destination" are from the same directory.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gfs2_rename_lock.patch
Type: text/x-patch
Size: 2137 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20061212/9054c7a2/attachment.bin>

#1 lore raw
Quoted 6 lines · Wendy Cheng

Currently GFS2 only obtains its rename global locks if the "source" is a directory. This could result a deadlock if:

- Node 1 does "rename dir1/file-a dir2/file-b"
- Node 2 does "rename dir2/file-c dir1/file-a"

Sorry, typo .. 2nd line should be:

Node 2 does "rename dir2/file-c dir1/file-d"

-- Wendy