Skip to contentSkip to conversation

cleanup unused EXPORTs

PATCH In review Jan Kiszka 2 participants 2 messages Dec 13, 2006 – Dec 14, 2006

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 cleanup unused EXPORTs

As I'm unable to find any modular users of the symbols below, I suggest to remove the EXPORTs and make __ipipe_pipelock static.

Jan

---
 include/linux/ipipe.h |    2 --
 kernel/ipipe/core.c   |    7 +------
 2 files changed, 1 insertion(+), 8 deletions(-)
include/linux/ipipe.h +0 -2
Index: linux-2.6.19-ipipe/include/linux/ipipe.h
===================================================================
@@ -241,8 +241,6 @@ extern unsigned long __ipipe_virtual_irq
 
 extern struct list_head __ipipe_pipeline;
 
-extern ipipe_spinlock_t __ipipe_pipelock;
-
 extern int __ipipe_event_monitors[];
 
 /* Private interface */
kernel/ipipe/core.c +1 -6
Index: linux-2.6.19-ipipe/kernel/ipipe/core.c
===================================================================
@@ -47,7 +47,7 @@ struct ipipe_domain ipipe_root =
 DEFINE_PER_CPU(struct ipipe_domain *, ipipe_percpu_domain) =
 	{ &ipipe_root };
 
-ipipe_spinlock_t __ipipe_pipelock = IPIPE_SPIN_LOCK_UNLOCKED;
+static IPIPE_DEFINE_SPINLOCK(__ipipe_pipelock);
 
 LIST_HEAD(__ipipe_pipeline);
 
@@ -1396,12 +1396,7 @@ EXPORT_SYMBOL(__ipipe_restore_root);
 EXPORT_SYMBOL(__ipipe_test_and_stall_root);
 EXPORT_SYMBOL(__ipipe_test_root);
 EXPORT_SYMBOL(__ipipe_dispatch_event);
-EXPORT_SYMBOL(__ipipe_dispatch_wired);
-EXPORT_SYMBOL(__ipipe_sync_stage);
 EXPORT_SYMBOL(__ipipe_pipeline);
-EXPORT_SYMBOL(__ipipe_pipelock);
-EXPORT_SYMBOL(__ipipe_virtual_irq_map);
-
 EXPORT_SYMBOL(ipipe_register_domain);
 EXPORT_SYMBOL(ipipe_unregister_domain);
 EXPORT_SYMBOL(ipipe_free_virq);
#1 lore raw
Quoted 2 lines · Jan Kiszka

As I'm unable to find any modular users of the symbols below, I suggest to remove the EXPORTs and make __ipipe_pipelock static.

Looks ok. I've queued this for the next release. Thanks.

Quoted 51 lines

Jan
plain text document attachment (cleanup-exports.patch)

---
 include/linux/ipipe.h |    2 --
 kernel/ipipe/core.c   |    7 +------
 2 files changed, 1 insertion(+), 8 deletions(-)

Index: linux-2.6.19-ipipe/include/linux/ipipe.h
===================================================================

include/linux/ipipe.h +0 -2
@@ -241,8 +241,6 @@ extern unsigned long __ipipe_virtual_irq
 
 extern struct list_head __ipipe_pipeline;
 
-extern ipipe_spinlock_t __ipipe_pipelock;
-
 extern int __ipipe_event_monitors[];
 
 /* Private interface */

Index: linux-2.6.19-ipipe/kernel/ipipe/core.c
===================================================================

kernel/ipipe/core.c +1 -6
@@ -47,7 +47,7 @@ struct ipipe_domain ipipe_root =
 DEFINE_PER_CPU(struct ipipe_domain *, ipipe_percpu_domain) =
 	{ &ipipe_root };
 
-ipipe_spinlock_t __ipipe_pipelock = IPIPE_SPIN_LOCK_UNLOCKED;
+static IPIPE_DEFINE_SPINLOCK(__ipipe_pipelock);
 
 LIST_HEAD(__ipipe_pipeline);
 
@@ -1396,12 +1396,7 @@ EXPORT_SYMBOL(__ipipe_restore_root);
 EXPORT_SYMBOL(__ipipe_test_and_stall_root);
 EXPORT_SYMBOL(__ipipe_test_root);
 EXPORT_SYMBOL(__ipipe_dispatch_event);
-EXPORT_SYMBOL(__ipipe_dispatch_wired);
-EXPORT_SYMBOL(__ipipe_sync_stage);
 EXPORT_SYMBOL(__ipipe_pipeline);
-EXPORT_SYMBOL(__ipipe_pipelock);
-EXPORT_SYMBOL(__ipipe_virtual_irq_map);
-
 EXPORT_SYMBOL(ipipe_register_domain);
 EXPORT_SYMBOL(ipipe_unregister_domain);
 EXPORT_SYMBOL(ipipe_free_virq);

_______________________________________________
Adeos-main mailing list
[email protected]
https://mail.gna.org/listinfo/adeos-main

Signature · 1 line
Philippe.