Skip to contentSkip to conversation

genirq: fix irq flow handler uninstall

PATCH In review Thomas Gleixner 2 participants 2 messages Dec 15, 2006 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 genirq: fix irq flow handler uninstall

The sanity check for no_irq_chip in __set_irq_hander() is unconditional on both install and uninstall of an handler. This triggers false warnings and replaces no_irq_chip by dummy_irq_chip in the uninstall case.

Check only, when a real handler is installed.

kernel/irq/chip.c +1 -2
Index: 2.6.19-git19/kernel/irq/chip.c
===================================================================
@@ -517,8 +517,7 @@ __set_irq_handler(unsigned int irq, irq_
 
 	if (!handle)
 		handle = handle_bad_irq;
-
-	if (desc->chip == &no_irq_chip) {
+	else if (desc->chip == &no_irq_chip) {
 		printk(KERN_WARNING "Trying to install %sinterrupt handler "
 		       "for IRQ%d\n", is_chained ? "chained " : " ", irq);
 		/*
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Thomas Gleixner

The sanity check for no_irq_chip in __set_irq_hander() is unconditional on both install and uninstall of an handler. This triggers false warnings and replaces no_irq_chip by dummy_irq_chip in the uninstall case.

Check only, when a real handler is installed.

Definitly fixed the spurious warning.

Sylvain