ARM: dts: Fix undocumented LM75 compatible nodes
Subsystems (11)
Rob Herring (Arm)
maintainerPATCH v2 1/1 ARM: dts: Fix undocumented LM75 compatible nodes
"lm75" without any vendor is undocumented. It works with the Linux kernel since the I2C subsystem will do matches of the compatible string without a vendor prefix to the i2c_device_id and/or driver name.
Mostly replace "lm75" with "national,lm75" as that's the original part vendor and the compatible which matches what "lm75" matched with. In a couple of cases the node name or compatible gives a clue to the actual part and vendor and a more specific compatible can be used. In these cases, it does change the variant the kernel picks.
"nct75" is an OnSemi part which is compatible with TI TMP75C based on a comparison of the OnSemi NCT75 datasheet and configuration the Linux driver uses. Adding an OnSemi compatible would be an ABI change.
"nxp,lm75" is most likely an NXP part. Alexander Stein says the i.MX53 boards are a NXP LM75A as well. NXP makes a LM75A and LM75B. Both are 11-bit resolution and 100ms sample time. The "national,lm75a" is 9-bit, so "national,lm75b" is the closest match for both NXP variants.
While we're here, fix the node names to use the generic name "temperature-sensor".
---
SoC maintainers, Please take this directly for v6.12.
v2:
- Also use "national,lm75b" on i.MX53 boards.
--- .../aspeed/aspeed-bmc-facebook-greatlakes.dts | 2 +- .../socfpga/socfpga_cyclone5_vining_fpga.dts | 4 +-- .../dts/marvell/armada-385-clearfog-gtr.dtsi | 8 ++--- .../boot/dts/nuvoton/nuvoton-npcm730-kudo.dts | 32 +++++++++---------- .../boot/dts/nuvoton/nuvoton-npcm750-evb.dts | 6 ++-- arch/arm/boot/dts/nxp/imx/imx53-mba53.dts | 4 +-- arch/arm/boot/dts/nxp/imx/imx53-tqma53.dtsi | 4 +-- .../dts/nxp/lpc/lpc4357-ea4357-devkit.dts | 4 +-- .../boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dts | 2 +- arch/arm/boot/dts/ti/omap/am335x-nano.dts | 2 +- .../boot/dts/xilinx/zynq-zturn-common.dtsi | 4 +-- 11 files changed, 36 insertions(+), 36 deletions(-)
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-greatlakes.dts +1 -1
@@ -201,7 +201,7 @@ eeprom at 54 { &i2c12 { status = "okay"; temperature-sensor at 4f { - compatible = "lm75"; + compatible = "national,lm75"; reg = <0x4f>; }; };
arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_vining_fpga.dts +2 -2
@@ -130,8 +130,8 @@ gpio: pca9557 at 1f { #gpio-cells = <2>; }; - temp: lm75 at 48 { - compatible = "lm75"; + temp: temperature-sensor at 48 { + compatible = "national,lm75"; reg = <0x48>; };
arch/arm/boot/dts/marvell/armada-385-clearfog-gtr.dtsi +4 -4
@@ -423,14 +423,14 @@ &i2c0 { status = "okay"; /* U26 temperature sensor placed near SoC */ - temp1: nct75 at 4c { - compatible = "lm75"; + temp1: temperature-sensor at 4c { + compatible = "ti,tmp75c"; reg = <0x4c>; }; /* U27 temperature sensor placed near RTC battery */ - temp2: nct75 at 4d { - compatible = "lm75"; + temp2: temperature-sensor at 4d { + compatible = "ti,tmp75c"; reg = <0x4d>; };
arch/arm/boot/dts/nuvoton/nuvoton-npcm730-kudo.dts +16 -16
@@ -531,8 +531,8 @@ i2c at 4 { reg = <4>; // INLET1_T - lm75 at 5c { - compatible = "ti,lm75"; + temperature-sensor at 5c { + compatible = "national,lm75"; reg = <0x5c>; }; };
@@ -543,8 +543,8 @@ i2c at 5 { reg = <5>; // OUTLET1_T - lm75 at 5c { - compatible = "ti,lm75"; + temperature-sensor at 5c { + compatible = "national,lm75"; reg = <0x5c>; }; };
@@ -555,8 +555,8 @@ i2c at 6 { reg = <6>; // OUTLET2_T - lm75 at 5c { - compatible = "ti,lm75"; + temperature-sensor at 5c { + compatible = "national,lm75"; reg = <0x5c>; }; };
@@ -567,8 +567,8 @@ i2c at 7 { reg = <7>; // OUTLET3_T - lm75 at 5c { - compatible = "ti,lm75"; + temperature-sensor at 5c { + compatible = "national,lm75"; reg = <0x5c>; }; };
@@ -697,8 +697,8 @@ i2c at 3 { reg = <3>; // M2_ZONE_T - lm75 at 28 { - compatible = "ti,lm75"; + temperature-sensor at 28 { + compatible = "national,lm75"; reg = <0x28>; }; };
@@ -709,8 +709,8 @@ i2c at 4 { reg = <4>; // BATT_ZONE_T - lm75 at 29 { - compatible = "ti,lm75"; + temperature-sensor at 29 { + compatible = "national,lm75"; reg = <0x29>; }; };
@@ -721,8 +721,8 @@ i2c at 5 { reg = <5>; // NBM1_ZONE_T - lm75 at 28 { - compatible = "ti,lm75"; + temperature-sensor at 28 { + compatible = "national,lm75"; reg = <0x28>; }; };
@@ -732,8 +732,8 @@ i2c at 6 { reg = <6>; // NBM2_ZONE_T - lm75 at 29 { - compatible = "ti,lm75"; + temperature-sensor at 29 { + compatible = "national,lm75"; reg = <0x29>; }; };
arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dts +3 -3
@@ -198,7 +198,7 @@ &i2c0 { clock-frequency = <100000>; status = "okay"; lm75 at 48 { - compatible = "lm75"; + compatible = "national,lm75"; reg = <0x48>; status = "okay"; };
@@ -208,8 +208,8 @@ lm75 at 48 { &i2c1 { clock-frequency = <100000>; status = "okay"; - lm75 at 48 { - compatible = "lm75"; + temperature-sensor at 48 { + compatible = "national,lm75"; reg = <0x48>; status = "okay"; };
arch/arm/boot/dts/nxp/imx/imx53-mba53.dts +2 -2
@@ -175,8 +175,8 @@ expander: pca9554 at 20 { gpio-controller; }; - sensor2: lm75 at 49 { - compatible = "lm75"; + sensor2: temperature-sensor at 49 { + compatible = "national,lm75b"; reg = <0x49>; }; };
arch/arm/boot/dts/nxp/imx/imx53-tqma53.dtsi +2 -2
@@ -254,8 +254,8 @@ pmic: mc34708 at 8 { interrupts = <6 4>; /* PATA_DATA6, active high */ }; - sensor1: lm75 at 48 { - compatible = "lm75"; + sensor1: temperature-sensor at 48 { + compatible = "national,lm75b"; reg = <0x48>; };
arch/arm/boot/dts/nxp/lpc/lpc4357-ea4357-devkit.dts +2 -2
@@ -482,8 +482,8 @@ mma7455 at 1d { reg = <0x1d>; }; - lm75 at 48 { - compatible = "nxp,lm75"; + temperature-sensor at 48 { + compatible = "national,lm75b"; reg = <0x48>; };
arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dts +1 -1
@@ -511,7 +511,7 @@ &i2c1 { clock-frequency = <400000>; sensor at 49 { - compatible = "lm75"; + compatible = "national,lm75"; reg = <0x49>; };
arch/arm/boot/dts/ti/omap/am335x-nano.dts +1 -1
@@ -231,7 +231,7 @@ tps: tps at 24 { }; temperature-sensor at 48 { - compatible = "lm75"; + compatible = "national,lm75"; reg = <0x48>; };
arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi +2 -2
@@ -97,9 +97,9 @@ &i2c0 { status = "okay"; clock-frequency = <400000>; - stlm75 at 49 { + temperature-sensor at 49 { status = "okay"; - compatible = "lm75"; + compatible = "st,stlm75"; reg = <0x49>; };
Signature · 1 line
2.43.0
Hi Rob,
thanks for the update.
Am Freitag, 16. August 2024, 18:47:14 CEST schrieb Rob Herring (Arm):
Quoted 19 lines
"lm75" without any vendor is undocumented. It works with the Linux kernel since the I2C subsystem will do matches of the compatible string without a vendor prefix to the
i2c_device_idand/or driver name.Mostly replace "lm75" with "national,lm75" as that's the original part vendor and the compatible which matches what "lm75" matched with. In a couple of cases the node name or compatible gives a clue to the actual part and vendor and a more specific compatible can be used. In these cases, it does change the variant the kernel picks.
"nct75" is an OnSemi part which is compatible with TI TMP75C based on a comparison of the OnSemi NCT75 datasheet and configuration the Linux driver uses. Adding an OnSemi compatible would be an ABI change.
"nxp,lm75" is most likely an NXP part. Alexander Stein says the i.MX53 boards are a NXP LM75A as well. NXP makes a LM75A and LM75B. Both are 11-bit resolution and 100ms sample time. The "national,lm75a" is 9-bit, so "national,lm75b" is the closest match for both NXP variants.
Quoted 6 lines
While we're here, fix the node names to use the generic name "temperature-sensor".
Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by Rob Herring (Arm) <[email protected]>
Quoted 274 lines
---
SoC maintainers, Please take this directly for v6.12.v2:
- Also use "national,lm75b" on i.MX53 boards.--- .../aspeed/aspeed-bmc-facebook-greatlakes.dts | 2 +- .../socfpga/socfpga_cyclone5_vining_fpga.dts | 4 +-- .../dts/marvell/armada-385-clearfog-gtr.dtsi | 8 ++--- .../boot/dts/nuvoton/nuvoton-npcm730-kudo.dts | 32 +++++++++---------- .../boot/dts/nuvoton/nuvoton-npcm750-evb.dts | 6 ++-- arch/arm/boot/dts/nxp/imx/imx53-mba53.dts | 4 +-- arch/arm/boot/dts/nxp/imx/imx53-tqma53.dtsi | 4 +-- .../dts/nxp/lpc/lpc4357-ea4357-devkit.dts | 4 +-- .../boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dts | 2 +- arch/arm/boot/dts/ti/omap/am335x-nano.dts | 2 +- .../boot/dts/xilinx/zynq-zturn-common.dtsi | 4 +-- 11 files changed, 36 insertions(+), 36 deletions(-)arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-greatlakes.dts +1
-1@@ -201,7 +201,7 @@ eeprom at 54 { &i2c12 { status = "okay"; temperature-sensor at 4f { - compatible = "lm75"; + compatible = "national,lm75"; reg = <0x4f>; }; };arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_vining_fpga.dts +2
-2@@ -130,8 +130,8 @@ gpio: pca9557 at 1f { #gpio-cells = <2>; }; - temp: lm75 at 48 { - compatible = "lm75"; + temp: temperature-sensor at 48 { + compatible = "national,lm75"; reg = <0x48>; };arch/arm/boot/dts/marvell/armada-385-clearfog-gtr.dtsi +4
-4@@ -423,14 +423,14 @@ &i2c0 { status = "okay"; /* U26 temperature sensor placed near SoC */ - temp1: nct75 at 4c { - compatible = "lm75"; + temp1: temperature-sensor at 4c { + compatible = "ti,tmp75c"; reg = <0x4c>; }; /* U27 temperature sensor placed near RTC battery */ - temp2: nct75 at 4d { - compatible = "lm75"; + temp2: temperature-sensor at 4d { + compatible = "ti,tmp75c"; reg = <0x4d>; };arch/arm/boot/dts/nuvoton/nuvoton-npcm730-kudo.dts +16
-16@@ -531,8 +531,8 @@ i2c at 4 { reg = <4>; // INLET1_T - lm75 at 5c { - compatible = "ti,lm75"; + temperature-sensor at 5c { + compatible = "national,lm75"; reg = <0x5c>; }; };@@ -543,8 +543,8 @@ i2c at 5 { reg = <5>; // OUTLET1_T - lm75 at 5c { - compatible = "ti,lm75"; + temperature-sensor at 5c { + compatible = "national,lm75"; reg = <0x5c>; }; };@@ -555,8 +555,8 @@ i2c at 6 { reg = <6>; // OUTLET2_T - lm75 at 5c { - compatible = "ti,lm75"; + temperature-sensor at 5c { + compatible = "national,lm75"; reg = <0x5c>; }; };@@ -567,8 +567,8 @@ i2c at 7 { reg = <7>; // OUTLET3_T - lm75 at 5c { - compatible = "ti,lm75"; + temperature-sensor at 5c { + compatible = "national,lm75"; reg = <0x5c>; }; };@@ -697,8 +697,8 @@ i2c at 3 { reg = <3>; // M2_ZONE_T - lm75 at 28 { - compatible = "ti,lm75"; + temperature-sensor at 28 { + compatible = "national,lm75"; reg = <0x28>; }; };@@ -709,8 +709,8 @@ i2c at 4 { reg = <4>; // BATT_ZONE_T - lm75 at 29 { - compatible = "ti,lm75"; + temperature-sensor at 29 { + compatible = "national,lm75"; reg = <0x29>; }; };@@ -721,8 +721,8 @@ i2c at 5 { reg = <5>; // NBM1_ZONE_T - lm75 at 28 { - compatible = "ti,lm75"; + temperature-sensor at 28 { + compatible = "national,lm75"; reg = <0x28>; }; };@@ -732,8 +732,8 @@ i2c at 6 { reg = <6>; // NBM2_ZONE_T - lm75 at 29 { - compatible = "ti,lm75"; + temperature-sensor at 29 { + compatible = "national,lm75"; reg = <0x29>; }; };arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dts +3
-3@@ -198,7 +198,7 @@ &i2c0 { clock-frequency = <100000>; status = "okay"; lm75 at 48 { - compatible = "lm75"; + compatible = "national,lm75"; reg = <0x48>; status = "okay"; };@@ -208,8 +208,8 @@ lm75 at 48 { &i2c1 { clock-frequency = <100000>; status = "okay"; - lm75 at 48 { - compatible = "lm75"; + temperature-sensor at 48 { + compatible = "national,lm75"; reg = <0x48>; status = "okay"; };arch/arm/boot/dts/nxp/imx/imx53-mba53.dts +2
-2@@ -175,8 +175,8 @@ expander: pca9554 at 20 { gpio-controller; }; - sensor2: lm75 at 49 { - compatible = "lm75"; + sensor2: temperature-sensor at 49 { + compatible = "national,lm75b"; reg = <0x49>; }; };arch/arm/boot/dts/nxp/imx/imx53-tqma53.dtsi +2
-2@@ -254,8 +254,8 @@ pmic: mc34708 at 8 { interrupts = <6 4>; /* PATA_DATA6, active high */ }; - sensor1: lm75 at 48 { - compatible = "lm75"; + sensor1: temperature-sensor at 48 { + compatible = "national,lm75b"; reg = <0x48>; };arch/arm/boot/dts/nxp/lpc/lpc4357-ea4357-devkit.dts +2
-2@@ -482,8 +482,8 @@ mma7455 at 1d { reg = <0x1d>; }; - lm75 at 48 { - compatible = "nxp,lm75"; + temperature-sensor at 48 { + compatible = "national,lm75b"; reg = <0x48>; };arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dts +1
-1@@ -511,7 +511,7 @@ &i2c1 { clock-frequency = <400000>; sensor at 49 { - compatible = "lm75"; + compatible = "national,lm75"; reg = <0x49>; };arch/arm/boot/dts/ti/omap/am335x-nano.dts +1
-1@@ -231,7 +231,7 @@ tps: tps at 24 { }; temperature-sensor at 48 { - compatible = "lm75"; + compatible = "national,lm75"; reg = <0x48>; };arch/arm/boot/dts/xilinx/zynq-zturn-common.dtsi +2
-2@@ -97,9 +97,9 @@ &i2c0 { status = "okay"; clock-frequency = <400000>; - stlm75 at 49 { + temperature-sensor at 49 { status = "okay"; - compatible = "lm75"; + compatible = "st,stlm75"; reg = <0x49>; };
Signature · 4 lines
TQ-Systems GmbH | M?hlstra?e 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M?nchen, HRB 105018 Gesch?ftsf?hrer: Detlef Schneider, R?diger Stahl, Stefan Schneider http://www.tq-group.com/
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:
Hello:
This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:
Quoted 11 lines · On Fri, 16 Aug 2024 10:47:14 -0600 you wrote:
"lm75" without any vendor is undocumented. It works with the Linux kernel since the I2C subsystem will do matches of the compatible string without a vendor prefix to the
i2c_device_idand/or driver name.Mostly replace "lm75" with "national,lm75" as that's the original part vendor and the compatible which matches what "lm75" matched with. In a couple of cases the node name or compatible gives a clue to the actual part and vendor and a more specific compatible can be used. In these cases, it does change the variant the kernel picks.
[...]
Here is the summary with links:
- [v2] ARM: dts: Fix undocumented LM75 compatible nodes
https://git.kernel.org/soc/soc/c/ef1e32cb6314
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html