Skip to contentSkip to conversation

rt2x00_pci: Fix interrupt handler name (visible at /proc/interrupts)

PATCH In review Kirill Tkhai 2 participants 2 messages Oct 1, 2013 – Oct 2, 2013 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rt2x00_pci: Fix interrupt handler name (visible at /proc/interrupts)

Currently driver name is wrong. PCI device address is visible at /proc/interrupts instead of the name:

 43:    124      0      0      0   PCI-MSI-edge    rtsx_pci
 44:    384      0      0      0   PCI-MSI-edge    snd_hda_intel
 45:  25096      0      0      0   PCI-MSI-edge    0000:01:00.0
                                                   ^^^^^^^^^^^^

So, pass the right name. rt2x00_ops->name contains KBUILD_MODNAME and good for that, so pass it.

Handler names will be "rt2500pci", "rt2500pci" etc.

CC Ivo van Doorn <[email protected]>
CC Gertjan van Wingerde <[email protected]>
CC Helmut Schaa <[email protected]>
---
 drivers/net/wireless/rt2x00/rt2x00pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/rt2x00/rt2x00pci.c +1 -1
index 76d95de..6c5d667 100644
@@ -121,7 +121,7 @@ int rt2x00pci_probe(struct pci_dev *pci_dev, const struct rt2x00_ops *ops)
 	rt2x00dev->ops = ops;
 	rt2x00dev->hw = hw;
 	rt2x00dev->irq = pci_dev->irq;
-	rt2x00dev->name = pci_name(pci_dev);
+	rt2x00dev->name = ops->name;
 
 	if (pci_is_pcie(pci_dev))
 		rt2x00_set_chip_intf(rt2x00dev, RT2X00_CHIP_INTF_PCIE);
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Kirill Tkhai

Currently driver name is wrong. PCI device address is visible at /proc/interrupts instead of the name:

 43:    124      0      0      0   PCI-MSI-edge    rtsx_pci
 44:    384      0      0      0   PCI-MSI-edge    snd_hda_intel
 45:  25096      0      0      0   PCI-MSI-edge    0000:01:00.0
                                                   ^^^^^^^^^^^^
Quoted 4 lines

So, pass the right name. rt2x00_ops->name contains KBUILD_MODNAME and good for that, so pass it.

Handler names will be "rt2500pci", "rt2500pci" etc.

Looks sane. I was afraid that is not possible to have two or more interrupts with the same name, but that's not true.

Stanislaw