Skip to contentSkip to conversation

input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register address

PATCH RESEND Applied Sebastian Krzyszkowiak 3 participants 3 messages Sep 27, 2022

Subsystems (3)
Stable branch HID Input drivers
lore
Share & tools
lore

Sebastian Krzyszkowiak

author
#0 lore raw

PATCH RESEND v2 1/1 input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register address

Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1 (chapters 57.9 and 6.4.5 respectively).

Without this, trying to read the revision number results in 0 on all revisions, causing the i.MX6 quirk to apply on all platforms, which in turn causes the driver to synthesise power button release events instead of passing the real one as they happen even on platforms like i.MX8 where that's not wanted.

Fixes 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q")
Cc <[email protected]>
Tested-by Martin Kepplinger <[email protected]>
Signed-off-by Sebastian Krzyszkowiak <[email protected]>

---
Resent <[email protected]>
v2: augmented commit message; added cc: stable and tested-by

---
 drivers/input/keyboard/snvs_pwrkey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/snvs_pwrkey.c +1 -1
index 65286762b02a..ad8660be0127 100644
@@ -20,7 +20,7 @@
 #include <linux/mfd/syscon.h>
 #include <linux/regmap.h>
 
-#define SNVS_HPVIDR1_REG	0xF8
+#define SNVS_HPVIDR1_REG	0xBF8
 #define SNVS_LPSR_REG		0x4C	/* LP Status Register */
 #define SNVS_LPCR_REG		0x38	/* LP Control Register */
 #define SNVS_HPSR_REG		0x14
Signature · 1 line
2.35.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Sebastian Krzyszkowiak

Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1 (chapters 57.9 and 6.4.5 respectively).

Without this, trying to read the revision number results in 0 on all revisions, causing the i.MX6 quirk to apply on all platforms, which in turn causes the driver to synthesise power button release events instead of passing the real one as they happen even on platforms like i.MX8 where that's not wanted.

Quoted 4 lines
Fixes 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q")
Cc <[email protected]>
Tested-by Martin Kepplinger <[email protected]>
Signed-off-by Sebastian Krzyszkowiak <[email protected]>
Reviewed-by Mattijs Korpershoek <[email protected]>
Quoted 22 lines

---
Resent <[email protected]>
v2: augmented commit message; added cc: stable and tested-by

---
 drivers/input/keyboard/snvs_pwrkey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/snvs_pwrkey.c +1 -1
index 65286762b02a..ad8660be0127 100644
@@ -20,7 +20,7 @@
 #include <linux/mfd/syscon.h>
 #include <linux/regmap.h>
 
-#define SNVS_HPVIDR1_REG	0xF8
+#define SNVS_HPVIDR1_REG	0xBF8
 #define SNVS_LPSR_REG		0x4C	/* LP Status Register */
 #define SNVS_LPCR_REG		0x38	/* LP Control Register */
 #define SNVS_HPSR_REG		0x14
Signature · 1 line
2.35.1
maintainer Applied
#2 lore raw
In reply to Sebastian Krzyszkowiak
Quoted 9 lines · Sebastian Krzyszkowiak

Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1 (chapters 57.9 and 6.4.5 respectively).

Without this, trying to read the revision number results in 0 on all revisions, causing the i.MX6 quirk to apply on all platforms, which in turn causes the driver to synthesise power button release events instead of passing the real one as they happen even on platforms like i.MX8 where that's not wanted.

Quoted 4 lines
Fixes 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q")
Cc <[email protected]>
Tested-by Martin Kepplinger <[email protected]>
Signed-off-by Sebastian Krzyszkowiak <[email protected]>

Applied, thank you.

Signature · 1 line
Dmitry