fix the toshiba_acpi write_lcd return value

PATCH New Matthijs van Otterdijk 1 participant 1 message Jan 4, 2007 ACPI

Share & tools

Matthijs van Otterdijk

author

2007-01-04 21:07 UTC #0 lore raw

PATCH 1/1 fix the toshiba_acpi write_lcd return value

the write_lcd function in toshiba_acpi returns 0 on success since the big ACPI patch merged in 2.6.20-rc2. It should return count.

Signed-off-by Matthijs van Otterdijk <[email protected]>

---
 drivers/acpi/toshiba_acpi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/acpi/toshiba_acpi.c +2 -2

diff -up a/drivers/acpi/toshiba_acpi.c b/drivers/acpi/toshiba_acpi.c
@@ -321,11 +321,11 @@ static int set_lcd_status(struct backlig
 static unsigned long write_lcd(const char *buffer, unsigned long count)
 {
 	int value;
-	int ret = count;
+	int ret;
 
 	if (sscanf(buffer, " brightness : %i", &value) == 1 &&
 	    value >= 0 && value < HCI_LCD_BRIGHTNESS_LEVELS)
-		ret = set_lcd(value);
+		ret = (ret = set_lcd(value)) == 0 ? count : ret;
 	else
 		ret = -EINVAL;
 	return ret;