Skip to contentSkip to conversation

CFG_LOAD_ADDR vs. CONFIG_LOADADDR vs. CFG_TFTP_LOADADDR

U-Boot-Users Timur Tabi 2 participants 4 messages Jan 10, 2007

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR? Looking at the code, it looks like their both used as default load addresses, but I don't see why they should have different values (they do in most header files).

The README also talks about CFG_TFTP_LOADADDR, but I don't see where that's used in the code.

Signature · 2 lines
Timur Tabi
Linux Kernel Developer @ Freescale
#1 lore raw
Quoted 1 line · In message <[email protected]> you wrote:

What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR? Looking at the

One underscore, a 'O', a 'N', and a 'I' ;-)

CFG_LOAD_ADDR is what you are supposed to use in the code.

CONFIG_LOADADDR is the value used to initialize the "loadaddr" variable in the default environment.

Quoted 2 lines

code, it looks like their both used as default load addresses, but I don't see why they should have different values (they do in most header files).

I see little reason to define CONFIG_LOADADDR at all.

Quoted 2 lines

The README also talks about CFG_TFTP_LOADADDR, but I don't see where that's used in the code.

It ain't used, and should be removed.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our business is run on trust.  We trust you will pay in advance.
author
#2 lore raw
Quoted 3 lines · Wolfgang Denk
Quoted 1 line

What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR? Looking at the

One underscore, a 'O', a 'N', and a 'I' ;-)

Otto Waalkes could take lessons from you.

Quoted 9 lines

CFG_LOAD_ADDR is what you are supposed to use in the code.

CONFIG_LOADADDR is the value used to initialize the "loadaddr" variable in the default environment.

Quoted 2 lines

code, it looks like their both used as default load addresses, but I don't see why they should have different values (they do in most header files).

I see little reason to define CONFIG_LOADADDR at all.

Then what's the best way to define a default value for the "loadaddr" variable?

Signature · 2 lines
Timur Tabi
Linux Kernel Developer @ Freescale
#3 lore raw
Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 3 lines

CONFIG_LOADADDR is the value used to initialize the "loadaddr" variable in the default environment.

...

Quoted 3 lines
Quoted 1 line

I see little reason to define CONFIG_LOADADDR at all.

Then what's the best way to define a default value for the "loadaddr" variable?

Define CONFIG_LOADADDR.

But, as mentioned implicitely before, I see little reason to define the "loadaddr" variable at all.

Define CFG_LOAD_ADDR, and that's it. Having more than one defualt value seems a broken design to me.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A dirty mind is a joy forever."                       - Randy Kunkee