2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{,6} device initialization order."
Hi,
The patch titled "IPV4/IPV6: Fix inet{,6} device initialization order" shipped in 2.6.19.2 appears to be the cause of this regression:
https://bugs.gentoo.org/show_bug.cgi?id=161907
Is this a known issue? Should this patch be dropped from -stable?
Thanks,
Daniel
I expect this is the failure to join the all-nodes multicast group, in which case the fix has already been posted to netdev. I believe the router advertisements are sent to that, and if the join failed, it wouldn't receive any of them.
I think it's better to add the fix than withdraw this patch, since the original bug is a crash.
Details:
The IPv6 code passes the "dev" entry to the multicast group incrementer and uses it to dereference to get the in6_dev. IPv4, by contrast, passes the in_dev directly to its equivalent functions.
IPv6 joins the required "all-nodes" multicast group in the multicast device initialization function, which due to the fix won't have a dev entry at that time. The patch posted by Yoshifuji Hideaki moves the all-nodes join until after the ip6_ptr is added to the dev.
+-DLS
From: David Stevens <[email protected]>
Date: Sun, 14 Jan 2007 19:47:49 -0800
Quoted 2 lines
I think it's better to add the fix than withdraw this patch, since the original bug is a crash.
I completely agree.
Re: [stable] 2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{, 6} device initialization order."
Quoted 7 lines · David Miller
From: David Stevens <[email protected]>
Date: Sun, 14 Jan 2007 19:47:49 -0800Quoted 2 lines
I think it's better to add the fix than withdraw this patch, since the original bug is a crash.
I completely agree.
Great, can someone forward the patch to us?
thanks,
greg k-h
Re: [stable] 2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{, 6} device initialization order."
Quoted 6 lines · Greg KH
Quoted 4 lines · David Miller
From: David Stevens <[email protected]>
Date: Sun, 14 Jan 2007 19:47:49 -0800
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
I think it's better to add the fix than withdraw this patch, since the original bug is a crash.
I completely agree.
Great, can someone forward the patch to us?
Should be the fix from http://bugzilla.kernel.org/show_bug.cgi?id=7817
Quoted 4 lines
thanks,
greg k-h
Regards,
Gabriel
Re: [stable] 2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{, 6} device initialization order."
In article <[email protected]> (at Tue, 16 Jan 2007 03:01:56 +0100), Gabriel C <[email protected]> says:
Quoted 10 lines
Quoted 9 lines · Greg KH
Quoted 7 lines · David Miller
From: David Stevens <[email protected]>
Date: Sun, 14 Jan 2007 19:47:49 -0800Quoted 3 lines
I think it's better to add the fix than withdraw this patch, since the original bug is a crash.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
I completely agree.
Great, can someone forward the patch to us?
Should be the fix from http://bugzilla.kernel.org/show_bug.cgi?id=7817
I've resent the patch to <[email protected]>.
--yoshfuji
Re: [stable] 2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{, 6} device initialization order."
From: YOSHIFUJI Hideaki <[email protected]>
Date: Tue, 16 Jan 2007 11:06:30 +0900 (JST)
Quoted 5 lines
In article <[email protected]> (at Tue, 16 Jan 2007 03:01:56 +0100), Gabriel C <[email protected]> says:
Quoted 1 line
Should be the fix from http://bugzilla.kernel.org/show_bug.cgi?id=7817
I've resent the patch to <[email protected]>.
Thank you.