Skip to contentSkip to conversation

Remove CONFIG_NET_WIRELESS

PATCH Johannes Berg 3 participants 5 messages Jan 15, 2007 1 message not in the archive

Subsystems (4)
Networking Network drivers Networking drivers (wireless) 802.11 (including cfg80211/NL80211)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Johannes Berg

author maintainer
#1 lore raw
Quoted 3 lines · Maarten Lankhorst

Remove CONFIG_NET_WIRELESS
Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus. Verified this with a grep.

I don't really care about the symbol and I'm in favour of removing it if it is useless, but I don't understand the rationale. How does enabling this cause anything to fail?

johannes

#2 lore raw

Johannes Berg schreef:

Quoted 7 lines · Maarten Lankhorst
Quoted 5 lines

Remove CONFIG_NET_WIRELESS
Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus. Verified this with a grep.

Quoted 6 lines

I don't really care about the symbol and I'm in favour of removing it if it is useless, but I don't understand the rationale. How does enabling this cause anything to fail?

johannes

Enabling this doesn't cause anything to fail, but my wireless router doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS isn't selected. This in turn causes wext-common.o to not be built, so I get missing symbols and a build breakage. That's why I made wext-common.o depend on CONFIG_WIRELESS_EXT instead of CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I decided to kill that symbol.

maarten

author maintainer
#3 lore raw
Quoted 14 lines · Maarten Lankhorst

Johannes Berg schreef:

Quoted 7 lines · Maarten Lankhorst
Quoted 5 lines

Remove CONFIG_NET_WIRELESS
Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus. Verified this with a grep.

Quoted 6 lines

I don't really care about the symbol and I'm in favour of removing it if it is useless, but I don't understand the rationale. How does enabling this cause anything to fail?

johannes

Quoted 7 lines

Enabling this doesn't cause anything to fail, but my wireless router doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS isn't selected. This in turn causes wext-common.o to not be built, so I get missing symbols and a build breakage. That's why I made wext-common.o depend on CONFIG_WIRELESS_EXT instead of CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I decided to kill that symbol.

Ok, that makes sense to me. Let's put this in but with this better description rather than the original one.

johannes

#4 lore raw
Quoted 11 lines · Johannes Berg
Quoted 7 lines · Maarten Lankhorst

Enabling this doesn't cause anything to fail, but my wireless router doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS isn't selected. This in turn causes wext-common.o to not be built, so I get missing symbols and a build breakage. That's why I made wext-common.o depend on CONFIG_WIRELESS_EXT instead of CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I decided to kill that symbol.

Ok, that makes sense to me. Let's put this in but with this better description rather than the original one.

The original mail with patch apparently didn't get to netdev (I haven't received it and it's not in netdev archive). Maarten, could you resend it please?

Thanks,

Jiri

Signature · 2 lines
Jiri Benc
SUSE Labs
#5 lore raw

Jiri Benc schreef:

Quoted 16 lines · Johannes Berg
Quoted 11 lines · Maarten Lankhorst
Quoted 9 lines

Enabling this doesn't cause anything to fail, but my wireless router doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS isn't selected. This in turn causes wext-common.o to not be built, so I get missing symbols and a build breakage. That's why I made wext-common.o depend on CONFIG_WIRELESS_EXT instead of CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I decided to kill that symbol.

Quoted 3 lines

Ok, that makes sense to me. Let's put this in but with this better description rather than the original one.

Quoted 9 lines

The original mail with patch apparently didn't get to netdev (I haven't received it and it's not in netdev archive). Maarten, could you resend it please?

Thanks,

Jiri

Sorry, must have missed sending it to netdev, original message follows.

Remove CONFIG_NET_WIRELESS
Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus. Verified this with a grep.

Signed-off-by Maarten Lankhorst <[email protected]>
drivers/net/wireless/Kconfig +0 -6
index 03dbe60..b9620c6 100644
@@ -544,11 +544,5 @@ source "drivers/net/wireless/zd1211rw/Kc
 
 source "drivers/net/wireless/d80211/Kconfig"
 
-# yes, this works even when no drivers are selected
-config NET_WIRELESS
-	bool
-	depends on NET_RADIO && (ISA || PCI || PPC_PMAC || PCMCIA)
-	default y
-
 endmenu
net/wireless/Makefile +1 -1
index f285440..44ae23a 100644
@@ -12,5 +12,5 @@ obj-ny :=
 
 # this needs to be compiled in...
 obj-$(CONFIG_CFG80211_WEXT_COMPAT) += wext-compat.o
-obj-$(CONFIG_CFG80211_WEXT_COMPAT)$(CONFIG_NET_WIRELESS) += wext-common.o
+obj-$(CONFIG_CFG80211_WEXT_COMPAT)$(CONFIG_WIRELESS_EXT) += wext-common.o
 obj-y += $(obj-yy) $(obj-yn) $(obj-ny)