Skip to contentSkip to conversation

Fix bug in 836x and 832x platform code

PATCH New Li Yang 1 participant 1 message Jan 17, 2007

Subsystems (2)
lore
Share & tools
lore

Li Yang

author
#0 lore raw

PATCH 1/1 Fix bug in 836x and 832x platform code

The wrongly use of of_find_node_by_name() causes of_node_put() on a node which has already been put. It causes the refcount of the node to underflow, which triggers the WARN_ON in kref_get for 836x and 832x.

---

arch/powerpc/platforms/83xx/mpc832x_mds.c |    2 +-
arch/powerpc/platforms/83xx/mpc8360e_pb.c |    2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/platforms/83xx/mpc832x_mds.c +0 -0
index f58c978..4d47119 100644
@@ -103,7 +103,7 @@ static void __init mpc832x_sys_setup_arch(void)
#ifdef CONFIG_QUICC_ENGINE
	qe_reset();

- if ((np = of_find_node_by_name(np, "par_io")) != NULL) {

+	if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) {
		par_io_init(np);
		of_node_put(np);
arch/powerpc/platforms/83xx/mpc8360e_pb.c +0 -0
index 7bfd47a..53b92a9 100644
@@ -108,7 +108,7 @@ static void __init mpc8360_sys_setup_arch(void)
#ifdef CONFIG_QUICC_ENGINE
	qe_reset();

- if ((np = of_find_node_by_name(np, "par_io")) != NULL) {

+	if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) {
		par_io_init(np);
		of_node_put(np);