Skip to contentSkip to conversation

sata_mv HighPoint 2310 support (88SX7042)

PATCH In review Olof Johansson 2 participants 2 messages Jan 19, 2007 – Jan 20, 2007 libata

lore
Share & tools
lore

Olof Johansson

author
#0 lore raw

PATCH 1/1 sata_mv HighPoint 2310 support (88SX7042)

Hi,

With the following patch, my HighPoint 2310 with a Marvell 88SX7042 on it seems to work OK.

The controller only has 4 ports, with MV_FLAG_DUAL_HC it seems to init 8 ports and fails miserably at probe time. There are no other devices mapped to that chip, maybe it was just incorrectly specified in the first place?

Signed-off-by Olof Johansson <[email protected]>
drivers/ata/sata_mv.c +3 -2
Index: linux-2.6/drivers/ata/sata_mv.c
===================================================================
@@ -523,8 +523,7 @@ static const struct ata_port_info mv_por
 	},
 	{  /* chip_7042 */
 		.sht		= &mv_sht,
-		.flags		= (MV_COMMON_FLAGS | MV_6XXX_FLAGS |
-				   MV_FLAG_DUAL_HC),
+		.flags		= (MV_COMMON_FLAGS | MV_6XXX_FLAGS),
 		.pio_mask	= 0x1f,	/* pio0-4 */
 		.udma_mask	= 0x7f,	/* udma0-6 */
 		.port_ops	= &mv_iie_ops,

@@ -545,6 +544,8 @@ static const struct pci_device_id mv_pci
 
 	{ PCI_VDEVICE(ADAPTEC2, 0x0241), chip_604x },
 
+	{ PCI_VDEVICE(TTI, 0x2310), chip_7042 },
+
 	{ }			/* terminate list */
 };
#1 lore raw
Quoted 11 lines · Olof Johansson

Hi,

With the following patch, my HighPoint 2310 with a Marvell 88SX7042 on it seems to work OK.

The controller only has 4 ports, with MV_FLAG_DUAL_HC it seems to init 8 ports and fails miserably at probe time. There are no other devices mapped to that chip, maybe it was just incorrectly specified in the first place?

Signed-off-by Olof Johansson <[email protected]>

The docs say 8-port.

Nonetheless, I will apply your patch, since working-in-the-field proof trumps docs on occasion (including this occasion).

We'll revisit if someone complains that their 7042 only sees 4 of 8 ports.

Jeff