Skip to contentSkip to conversation

USB: In init_endpoint_class, use PTR_ERR to obtain an errno value, not IS_ERR

PATCH New Josh Triplett 1 participant 1 message Jan 24, 2007 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: In init_endpoint_class, use PTR_ERR to obtain an errno value, not IS_ERR

init_endpoint_class calls class_create, and checks the result for an error with IS_ERR; however, if true, it then returns the result of IS_ERR (a boolean) rather than PTR_ERR (the actual errno).

---
 drivers/usb/core/endpoint.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/core/endpoint.c +1 -1
index 5e628ae..e0ec704 100644
@@ -229,7 +229,7 @@ static int init_endpoint_class(void)
 	kref_init(&ep_class->kref);
 	ep_class->class = class_create(THIS_MODULE, "usb_endpoint");
 	if (IS_ERR(ep_class->class)) {
-		result = IS_ERR(ep_class->class);
+		result = PTR_ERR(ep_class->class);
 		goto class_create_error;
 	}