Skip to contentSkip to conversation

Fix kvm-svn/kernel build on 32-bit

PATCH In review Ben Collins 3 participants 4 messages Feb 4, 2007 1 message not in the archive KVM

lore
Share & tools
lore

Ben Collins

author
#0 lore raw

PATCH 1/1 Fix kvm-svn/kernel build on 32-bit

Build currently fails with x86.

kvm_main.c +4 -1
Index: kernel/kvm_main.c
===================================================================
@@ -1148,6 +1148,7 @@
 
 	kvm_arch_ops->decache_regs(vcpu);
 	ret = -KVM_EINVAL;
+#ifdef CONFIG_X86_64
 	if (is_long_mode(vcpu)) {
 		nr = vcpu->regs[VCPU_REGS_RAX];
 		a0 = vcpu->regs[VCPU_REGS_RDI];

@@ -1156,7 +1157,9 @@
 		a3 = vcpu->regs[VCPU_REGS_RCX];
 		a4 = vcpu->regs[VCPU_REGS_R8];
 		a5 = vcpu->regs[VCPU_REGS_R9];
-	} else {
+	} else
+#endif
+	{
 		nr = vcpu->regs[VCPU_REGS_RBX] & -1u;
 		a0 = vcpu->regs[VCPU_REGS_RAX] & -1u;
 		a1 = vcpu->regs[VCPU_REGS_RCX] & -1u;
Signature · 9 lines
Ubuntu:    http://www.ubuntu.com/
Linux1394: http://www.linux1394.org/


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
#1 lore raw

Does kvm try to support 64-bit guests on a 32-bit host kernel? (64-bit CPU of course)

It looks to me like this patch might prevent that scenario.

Quoted 32 lines · Ben Collins

Build currently fails with x86.

Index: kernel/kvm_main.c
===================================================================

kvm_main.c (working copy) renamed from kvm_main.c (revision 4381) +4 -2
@@ -1148,6 +1148,7 @@
 
        kvm_arch_ops->decache_regs(vcpu);
        ret = -KVM_EINVAL;
+#ifdef CONFIG_X86_64
        if (is_long_mode(vcpu)) {
                nr = vcpu->regs[VCPU_REGS_RAX];
                a0 = vcpu->regs[VCPU_REGS_RDI];

@@ -1156,7 +1157,9 @@
                a3 = vcpu->regs[VCPU_REGS_RCX];
                a4 = vcpu->regs[VCPU_REGS_R8];
                a5 = vcpu->regs[VCPU_REGS_R9];
-       } else {
+       } else
+#endif
+       {
                nr = vcpu->regs[VCPU_REGS_RBX] & -1u;
                a0 = vcpu->regs[VCPU_REGS_RAX] & -1u;
                a1 = vcpu->regs[VCPU_REGS_RCX] & -1u;
 
 
--

Ubuntu:    http://www.ubuntu.com/
Linux1394: http://www.linux1394.org/
Quoted 10 lines

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

A message that is not in the archive (sent off-list or not yet received): 2e59e6970702031923k467c198asd20266093ef858d9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

author
#3 lore raw
Quoted 4 lines · On Sat, 2007-02-03 at 21:23 -0600, [email protected]…

Does kvm try to support 64-bit guests on a 32-bit host kernel? (64-bit CPU of course)

It looks to me like this patch might prevent that scenario.

No it doesn't, but this patch wouldn't prevent it any more than other parts of the code (where the VCPU_REGS_RX macros are already wrapped by CONFIG_X86_64 ifdef's).

Signature · 9 lines
Ubuntu:    http://www.ubuntu.com/
Linux1394: http://www.linux1394.org/


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
#4 lore raw
In reply to Ben Collins
Quoted 2 lines · Ben Collins

Build currently fails with x86.

I just committed an identical patch from Anthony.

Signature · 8 lines
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642