Skip to contentSkip to conversation

8349emds default dts updates for USB change

PATCH In review Li Yang 2 participants 4 messages Feb 5, 2007 – Feb 6, 2007

Subsystems (2)
Device tree bindings PowerPC
lore
Share & tools
lore

Li Yang

author
#0 lore raw

PATCH 3/3 8349emds default dts updates for USB change

Signed-off-by Li Yang <[email protected]>

---
arch/powerpc/boot/dts/mpc8349emds.dts | 6 ++++++

1 files changed, 6 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8349emds.dts +0 -0
index efceb34..ba31af1 100644
@@ -39,6 +39,11 @@

		reg = <00000000 10000000>;	// 256MB at 0
	};

+ bcsr@f8000000 {
+ device_type = "board-control";
+ reg = <e2400000 8000>;
+ };
+

	soc8349@e0000000 {
		#address-cells = <1>;
		#size-cells = <1>;
@@ -103,6 +108,7 @@
			#size-cells = <0>;
			interrupt-parent = <700>;
			interrupts = <26 2>;
+			dr_mode = "otg";
			phy_type = "ulpi";
		};
#1 lore raw
Quoted 10 lines · Li Yang
Signed-off-by Li Yang <[email protected]>

---
arch/powerpc/boot/dts/mpc8349emds.dts | 6 ++++++

1 files changed, 6 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8349emds.dts +0 -0
index efceb34..ba31af1 100644

arch/powerpc/boot/dts/mpc8349emds.dts line 43

Quoted 5 lines
arch/powerpc/boot/dts/mpc8349emds.dts +3 -0
@@ -39,6 +39,11 @@
 		reg = <00000000 10000000>;	// 256MB at 0
 	};
+	bcsr@f8000000 {
+		device_type = "board-control";
+		reg = <e2400000 8000>;

Are the bcsr's at f8000000 or e2400000?

arch/powerpc/boot/dts/mpc8349emds.dts line 111

Quoted 10 lines
arch/powerpc/boot/dts/mpc8349emds.dts +3 -0
+	};
+
 	soc8349@e0000000 {
 		#address-cells = <1>;
 		#size-cells = <1>;

@@ -103,6 +108,7 @@
 			#size-cells = <0>;
 			interrupt-parent = <700>;
 			interrupts = <26 2>;
+			dr_mode = "otg";

You're introducing a new property without any Documentation describing it.

arch/powerpc/boot/dts/mpc8349emds.dts line 113

Quoted 2 lines
arch/powerpc/boot/dts/mpc8349emds.dts +0 -0
 			phy_type = "ulpi";
 		};

- k

author
#2 lore raw
Quoted 15 lines

-----Original Message-----
From: Kumar Gala [mailto:[email protected]]
Sent: Monday, February 05, 2007 11:07 PM
To: Li Yang-r58472
Cc: Paul; [email protected]
Subject: Re: [PATCH 3/3] 8349emds default dts updates for USB change =20
=20
On Feb 5, 2007, at 3:10 AM, Li Yang wrote:
=20

Quoted 5 lines
Signed-off-by Li Yang <[email protected]>

---
arch/powerpc/boot/dts/mpc8349emds.dts | 6 ++++++

1 files changed, 6 insertions(+), 0 deletions(-)
Quoted 13 lines

arch/powerpc/boot/dts/mpc8349emds.dts line 43

Quoted 11 lines
arch/powerpc/ renamed from arch/powerpc/boot/dts/mpc8349emds.dts +0 -0

boot/dts/mpc8349emds.dts
index efceb34..ba31af1 100644

arch/powerpc/boot/dts/mpc8349emds.dts +3 -0
@@ -39,6 +39,11 @@
 		reg =3D <00000000 10000000>;	// 256MB at 0
 	};
+	bcsr@f8000000 {
+		device_type =3D "board-control";
+		reg =3D <e2400000 8000>;

=20
Are the bcsr's at f8000000 or e2400000?

According to the default u-boot configuration in tree, it is e2400000.

- Leo

#3 lore raw
Quoted 29 lines · On Feb 5, 2007, at 9:17 PM, Li Yang-r58472 wrote:
Quoted 15 lines

-----Original Message-----
From: Kumar Gala [mailto:[email protected]]
Sent: Monday, February 05, 2007 11:07 PM
To: Li Yang-r58472
Cc: Paul; [email protected]
Subject: Re: [PATCH 3/3] 8349emds default dts updates for USB change

Quoted 5 lines · Li Yang
Signed-off-by Li Yang <[email protected]>

---
arch/powerpc/boot/dts/mpc8349emds.dts | 6 ++++++

1 files changed, 6 insertions(+), 0 deletions(-)
Quoted 13 lines

arch/powerpc/boot/dts/mpc8349emds.dts line 43

Quoted 11 lines
arch/powerpc/ renamed from arch/powerpc/boot/dts/mpc8349emds.dts +0 -0

boot/dts/mpc8349emds.dts
index efceb34..ba31af1 100644

arch/powerpc/boot/dts/mpc8349emds.dts +3 -0
@@ -39,6 +39,11 @@
 		reg = <00000000 10000000>;	// 256MB at 0
 	};
+	bcsr@f8000000 {
+		device_type = "board-control";
+		reg = <e2400000 8000>;

Are the bcsr's at f8000000 or e2400000?

Quoted 1 line

According to the default u-boot configuration in tree, it is e2400000.

Fine, so what is it bcsr@f8000000?

- k