Skip to contentSkip to conversation

ps3 usb missed the addition of new argument to ps3_alloc_io_irq()

PATCH In review Al Viro 2 participants 3 messages Feb 9, 2007

Subsystems (5)
lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 ps3 usb missed the addition of new argument to ps3_alloc_io_irq()

---
 drivers/usb/host/ehci-ps3.c |    2 +-
 drivers/usb/host/ohci-ps3.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-ps3.c +1 -1
index 371f194..4d781a2 100644
@@ -104,7 +104,7 @@ static int ps3_ehci_sb_probe(struct ps3_system_bus_device *dev)
 	dev_dbg(&dev->core, "%s:%d: mmio mapped_addr %lxh\n", __func__,
 		__LINE__, dev->m_region->lpar_addr);
 
-	result = ps3_alloc_io_irq(dev->interrupt_id, &virq);
+	result = ps3_alloc_io_irq(PS3_BINDING_CPU_ANY, dev->interrupt_id, &virq);
 
 	if (result) {
 		dev_dbg(&dev->core, "%s:%d: ps3_construct_io_irq(%d) failed.\n",
drivers/usb/host/ohci-ps3.c +1 -1
index 69d948b..62283a3 100644
@@ -107,7 +107,7 @@ static int ps3_ohci_sb_probe(struct ps3_system_bus_device *dev)
 	dev_dbg(&dev->core, "%s:%d: mmio mapped_addr %lxh\n", __func__,
 		__LINE__, dev->m_region->lpar_addr);
 
-	result = ps3_alloc_io_irq(dev->interrupt_id, &virq);
+	result = ps3_alloc_io_irq(PS3_BINDING_CPU_ANY, dev->interrupt_id, &virq);
 
 	if (result) {
 		dev_dbg(&dev->core, "%s:%d: ps3_construct_io_irq(%d) failed.\n",
Signature · 1 line
1.5.0-rc2.GIT
#2 lore raw
Quoted 7 lines · Geoff Levand
Quoted 1 line · Al Viro

Greg had this same change queued for his usb tree.

Update the PS3 irq allocation routines to take an argument indicating which cpu (processor thread) the interrupt should be serviced on.

---
I fixed Al's patch to have the proper line lengths.

-Geoff

 drivers/usb/host/ehci-ps3.c |    3 ++-
 drivers/usb/host/ohci-ps3.c |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-ps3.c +2 -1
@@ -104,7 +104,8 @@ static int ps3_ehci_sb_probe(struct ps3_
 	dev_dbg(&dev->core, "%s:%d: mmio mapped_addr %lxh\n", __func__,
 		__LINE__, dev->m_region->lpar_addr);
 
-	result = ps3_alloc_io_irq(dev->interrupt_id, &virq);
+	result = ps3_alloc_io_irq(PS3_BINDING_CPU_ANY, dev->interrupt_id,
+		&virq);
 
 	if (result) {
 		dev_dbg(&dev->core, "%s:%d: ps3_construct_io_irq(%d) failed.\n",
drivers/usb/host/ohci-ps3.c +2 -1
@@ -107,7 +107,8 @@ static int ps3_ohci_sb_probe(struct ps3_
 	dev_dbg(&dev->core, "%s:%d: mmio mapped_addr %lxh\n", __func__,
 		__LINE__, dev->m_region->lpar_addr);
 
-	result = ps3_alloc_io_irq(dev->interrupt_id, &virq);
+	result = ps3_alloc_io_irq(PS3_BINDING_CPU_ANY, dev->interrupt_id,
+		&virq);
 
 	if (result) {
 		dev_dbg(&dev->core, "%s:%d: ps3_construct_io_irq(%d) failed.\n",