Skip to contentSkip to conversation

SATA patch.

U-Boot-Users mushtaq khan 3 participants 3 messages Feb 22, 2007

lore
Share & tools
lore
#0 lore raw

Hi,

I have attach a patch, for a SATA controller of Intel processor with South Bridge ICH5, ICH6 and ICH7. These chipset's don't support AHCI, and so you cann't use the driver ahci.c in u-boot code.
I have divided the code into two files, functions which are controller specifc are kept in ata-piix.c under directory drivers(this is with reference to ata-piix driver in kernel). And functions which are common to Sata controllers are kept in cmd_sata.c, under directory common (this is with reference to libata in kernel and cmd_ide.c in u-boot).

Thanks,
Mushtaq khan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.tar.gz
Type: application/x-gzip
Size: 12089 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070222/b193fbae/attachment.bin

#1 lore raw

Mushtaq,

Quoted 11 lines · mushtaq khan

Hi,

I have attach a patch, for a SATA controller of Intel processor with South Bridge ICH5, ICH6 and ICH7. These chipset's don't support AHCI, and so you cann't use the driver ahci.c in u-boot code.
I have divided the code into two files, functions which are controller specifc are kept in ata-piix.c under directory drivers(this is with reference to ata-piix driver in kernel). And functions which are common to Sata controllers are kept in cmd_sata.c, under directory common (this is with reference to libata in kernel and cmd_ide.c in u-boot).

Quoted 2 lines

Thanks,
Mushtaq khan.

I started reading through this and quickly gave up. Please address the following before re-submitting:

1. General coding standards violations:
line lengths < 78 characters
No '#if 0' or '#if 1'
Keep blank lines to a readable minimum
No C++ style comments
blah, blah, blah - read the guidelines

2. The only files you should send are patches. The others are superfluous. Changelog isn't necessary and the other one should either be in the e-mail or as a README

3. Please use a .diff or .patch filename extension. Text editors often key syntax highlighting and other things from extensions.

Please read the following. It will help you format your submission.

http://www.kernel.org/pub/software/scm/git/docs/everyday.html

regards,
Ben

#2 lore raw

[U-Boot-Users] Bad u-boot ETHERLITE driver performance.

Hi:

On Xilinx Spartan-3e Starter Kit during uClinux image downloading from u-boot via TFTP some packets get lost slower down downloading process.

This is typical downloading snapshot:

U-Boot> tftp 23000000 lm125/rel/1.0.0/image.ub
TFTP from server 192.168.0.141; our IP address is 192.168.0.206 Filename 'lm125/rel/1.0.0/image.ub'. Load address: 0x23000000 Loading:
#################################################################

         #######################################T

##########################

#################################################################

#################################################################

         ##########################T ##############################T
#########
         ############################################T
###################T 
         ###############################################################

done
Bytes transferred = 3313728 (329040 hex)
U-Boot>

This is happening only with ETHERNETLITE core and never with EMAC core (network setup is precisely the same). Also as soon as uClinux is loaded, network applications (including NFS and TFTP) are working smoothly meaning that problem is in u-boot emaculite drivers themselves (I'm using u-boot 1.1.4 snapshot from Petalinux distro).

Wolfgang Denk suggested here
http://www.denx.de/wiki/view/DULG/TFTPTimeout that it can be problem with full/half duplex configuration, but I couldn't find how to configure such mode is configured for emaculite driver.

Please advise,

Leonid.