mips: PMC MSP71xx mips common
Quoted 20 lines · Sergei Shtylyov
Hello.
Quoted 14 lines · Marc St-Jean
[PATCH 2/5] mips: PMC MSP71xx mips common
Patch to add mips common support for the PMC-Sierra MSP71xx devices.
These 5 patches along with the previously posted serial patch will boot the PMC-Sierra MSP7120 Residential Gateway board.
Signed-off-by Marc St-Jean <[email protected]>arch/mips/Kconfig +0
-0[...]
Quoted 12 lines
arch/mips/Kconfig
Quoted 10 lines
arch/mips/Kconfig +10
-0+menu "Options for PMC-Sierra MSP chipsets" + depends on PMC_MSP + +config PMC_MSP_EMBEDDED_ROOTFS + bool "Root filesystem embedded in kernel image" + select MTD + select MTD_BLOCK + select MTD_PMC_MSP_RAMROOT + select MTD_RAM +Hm, why not just use initramfs?
I investigated this as part of an earlier thread. Initramfs is not a read-only "ROM" fs but a compressed writable fs. Once expanded it will take more memory.
To lower memory usage for embedded usage of our devices we've added a method to embedded cramfs/squashfs file systems into the kernel image.
I've made sure it was unobtrusive and that no linker script changes, etc. were required.
Quoted 8 lines
arch/mips/Kconfig
Quoted 6 lines
arch/mips/Kconfig +6
-0+config PMC_MSP_UNCACHED + bool "Run uncached" + select MIPS_UNCACHED + +endmenu +Erm, was there really a need for separate option?
Are you aware of an existing option to accomplish the same results? I have not found it.
Quoted 35 lines
Quoted 13 lines
arch/mips/kernel/traps.c +1
-0@@ -70,6 +70,7 @@ extern asmlinkage void handle_reserved(void);extern int fpu_emulator_cop1Handler (struct pt_regs *xcp,struct mips_fpu_struct *ctx,int has_fpu); +void (*board_watchpoint_handler)(struct pt_regs *regs);void (*board_be_init)(void );int (*board_be_handler)(struct pt_regs *regs,int is_fixup);void (*board_nmi_handler_setup)(void );arch/mips/kernel/traps.c asmlinkage void do_mdmx(struct pt_regs *regs) · line 869
Quoted 10 lines
arch/mips/kernel/traps.c +0
-7@@ -860,13 +861,17 @@ asmlinkage void do_mdmx(struct pt_regs *regs) asmlinkage void do_watch(struct pt_regs *regs) { -/* -* We use the watch exception where available to detect stack -* overflows. -*/ -dump_tlb_all (); -show_regs (regs); - panic("Caught WATCH exception - probably caused by stackoverflow.");
arch/mips/kernel/traps.c asmlinkage void do_mdmx(struct pt_regs *regs) · line 868
Quoted 5 lines
arch/mips/kernel/traps.c +5
-0+if (board_watchpoint_handler) { + (*board_watchpoint_handler)(regs); + }else { +/* +* We use the watch exception where available to detect stack
arch/mips/kernel/traps.c asmlinkage void do_mdmx(struct pt_regs *regs) · line 873
Quoted 5 lines
arch/mips/kernel/traps.c +5
-0+* overflows. +*/ +dump_tlb_all (); +show_regs (regs); + panic("Caught WATCH exception - probably caused by
Quoted 7 lines
stack overflow.");
arch/mips/kernel/traps.c asmlinkage void do_mdmx(struct pt_regs *regs) · line 875
Quoted 2 lines
arch/mips/kernel/traps.c +1
-0+ } }There was no real need for else and massive change, just add return
right
after calling the handler...
Thanks, will do for the next submission.
Marc
Hello.
Quoted 11 lines · Marc St-Jean
Quoted 8 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+config PMC_MSP_UNCACHED + bool "Run uncached" + select MIPS_UNCACHED + +endmenu +Erm, was there really a need for separate option?
Are you aware of an existing option to accomplish the same results? I have not found it.
How's that when you're using it! "Run uncached" is in the "Kernel hacking"
menu.
Quoted 1 line
Marc
WBR, Sergei
Quoted 35 lines · Marc St-Jean
Quoted 20 lines · Sergei Shtylyov
Hello.
Quoted 14 lines · Marc St-Jean
[PATCH 2/5] mips: PMC MSP71xx mips common
Patch to add mips common support for the PMC-Sierra MSP71xx devices.
These 5 patches along with the previously posted serial patch will boot the PMC-Sierra MSP7120 Residential Gateway board.
Signed-off-by Marc St-Jean <[email protected]>arch/mips/Kconfig +0
-0[...]
Quoted 12 lines
arch/mips/Kconfig
Quoted 10 lines
arch/mips/Kconfig +10
-0+menu "Options for PMC-Sierra MSP chipsets" + depends on PMC_MSP + +config PMC_MSP_EMBEDDED_ROOTFS + bool "Root filesystem embedded in kernel image" + select MTD + select MTD_BLOCK + select MTD_PMC_MSP_RAMROOT + select MTD_RAM +Hm, why not just use initramfs?
Quoted 8 lines
I investigated this as part of an earlier thread. Initramfs is not a read-only "ROM" fs but a compressed writable fs. Once expanded it will take more memory.
To lower memory usage for embedded usage of our devices we've added a method to embedded cramfs/squashfs file systems into the kernel image.
Why not just run the cramfs/squashfs on a standard mdtblock device?
Quoted 4 lines
I've made sure it was unobtrusive and that no linker script changes, etc. were required.