Skip to contentSkip to conversation

fbdev: Ignore VESA modes if framebuffer is disabled

PATCH RESEND New Antonino A. Daplas 1 participant 1 message Feb 25, 2007 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 4/9 fbdev: Ignore VESA modes if framebuffer is disabled

If the option vga=<VESA graphics mode> is added to the boot parameter, it will activate graphics mode, but without any framebuffer support, the user is left with an unusable display.

Change the behavior such that the user is instead prompted for another mode (ala vga=ask).

NOTE: People can always use vbetool to set a graphics mode if this is really desired, but the number of people doing this approaches zero.

---

 arch/i386/boot/video.S   |    4 +++-
 arch/x86_64/boot/video.S |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)
arch/i386/boot/video.S +3 -1
index 9101969..78573da 100644
@@ -496,9 +496,11 @@ mode_set:
 	cmpb	$VIDEO_FIRST_V7>>8, %ah
 	jz	setv7
 	
+#ifdef CONFIG_FB
 	cmpb	$VIDEO_FIRST_VESA>>8, %ah
 	jnc	check_vesa
-	
+#endif
+		
 	orb	%ah, %ah
 	jz	setmenu
 	
arch/x86_64/boot/video.S +3 -1
index 6af75a7..d58aa0b 100644
@@ -496,9 +496,11 @@ mode_set:
 	cmpb	$VIDEO_FIRST_V7>>8, %ah
 	jz	setv7
 	
+#ifdef CONFIG_FB
 	cmpb	$VIDEO_FIRST_VESA>>8, %ah
 	jnc	check_vesa
-	
+#endif
+		
 	orb	%ah, %ah
 	jz	setmenu
 	

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV