SATA PATCH

Be wrote:

This patch will be processed faster if you're able to get it under 40kB and attach unzipped. It's currently 40.1kB, so this should be easy for you.

Hi,

Resending the SATA patch with size less than 40kb.

Thanks,
-Mushtaq

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Feature_decription.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070314/691cfdd0/attachment.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Sata.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070314/691cfdd0/attachment-0001.txt

Dear Mushtaq,

Thanks. The patch has a few coding style issues: indentation by space instead of TABs, trailing white space, etc.

Please see http://www.denx.de/wiki/UBoot/CodingStyle

Please insert a few more spaces, i. e. instead of

	}else if(strcmp(argv[1],"part") == 0){
write:
	} else if (strcmp(argv[1],"part") == 0) {

In a few places your indentation looks random, like here:

	printf ("%ld blocks written: %s\n",
	                                        n, (n==cnt) ? "OK" : "ERROR");

Please use only lower case letters for the command name, i. e. "sata" instead of "Sata".

In common/Makefile and drivers/Makefile, please keep the list of object file names alphabetically sorted.

Please clean up and resubmit.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'd like to meet the man who invented sex and see what  he's  working
on now.

Hi ,
I have done the indentation by running the script "Lindent" of linux
source code with -pcs option.

Thanks,
-Mushtaq Khan.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sata.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070326/6410ffab/attachment.txt