cosmetic adaption of drivers/ide/Kconfig concerning SATA

PATCH Applied Patrick Ringl 2 participants 5 messages Mar 17, 2007 – Mar 24, 2007

Share & tools

Patrick Ringl

author

2007-03-17 23:14 UTC #0 lore raw

PATCH 1/1 cosmetic adaption of drivers/ide/Kconfig concerning SATA

Hello,
since especially Serial ATA has it's own menu point now, I guess we can change the description of the deprecated SATA driver as well, since the new libATA subsystem is not configured through a SCSI low-level driver anymore, but has it's own menu point.

The following patch is against 2.6.21-rc4:

drivers/ide/Kconfig +1 -1

@@ -103,7 +103,7 @@
 	---help---
 	  There are two drivers for Serial ATA controllers.
 
-	  The main driver, "libata", exists inside the SCSI subsystem
+	  The main driver, "libata", exists inside the ATA subsystem
 	  and supports most modern SATA controllers.
 
 	  The IDE driver (which you are currently configuring) supports

---

Since I am not subscribed to the list, I'd find it great if I were personally CC'ed. :-)

Best regards
Patrick

Bartlomiej Zolnierkiewicz

2007-03-18 00:03 UTC #1 lore raw

Quoted 1 line · Patrick Ringl

Hello,

Hi,

Quoted 10 lines

since especially Serial ATA has it's own menu point now, I guess we can change the description of the deprecated SATA driver as well, since the new libATA subsystem is not configured through a SCSI low-level driver anymore, but has it's own menu point.
The following patch is against 2.6.21-rc4:

drivers/ide/Kconfig line 106

Quoted 5 lines

drivers/ide/Kconfig +1 -1

@@ -103,7 +103,7 @@
  	---help---
  	  There are two drivers for Serial ATA controllers.
 
-	  The main driver, "libata", exists inside the SCSI subsystem
+	  The main driver, "libata", exists inside the ATA subsystem

Strictly speaking libata is not a separate subsystem (it still uses SCSI subsystem) and "ATA subsystem" may be misleading, since we now have:

* "ATA/ATAPI/MFM/RLL support" menu for drivers/ide

* "Serial ATA (prod) and Parallel ATA (experimental) drivers" menu for libata

What about replacing "exists inside" into "uses" and adding info about the new menu instead?

Thanks,
Bart

Patrick Ringl

author

2007-03-18 00:31 UTC #2 lore raw

Re: [PATCH UPDATED][2] cosmetic adaption of drivers/ide/Kconfig concerning SATA

Bartlomiej Zolnierkiewicz wrote:

Hello,

Quoted 21 lines · Patrick Ringl

Quoted 1 line
Hello,
Hi,
drivers/ide/Kconfig line 106
Quoted 12 lines
since especially Serial ATA has it's own menu point now, I guess we can change the description of the deprecated SATA driver as well, since the new libATA subsystem is not configured through a SCSI low-level driver anymore, but has it's own menu point.
The following patch is against 2.6.21-rc4:
drivers/ide/Kconfig +1 -1
@@ -103,7 +103,7 @@
  	---help---
  	  There are two drivers for Serial ATA controllers.
 
-	  The main driver, "libata", exists inside the SCSI subsystem
+	  The main driver, "libata", exists inside the ATA subsystem
Strictly speaking libata is not a separate subsystem (it still uses SCSI subsystem) and "ATA subsystem" may be misleading, since we now have:

Quoted 6 lines

* "ATA/ATAPI/MFM/RLL support" menu for drivers/ide
* "Serial ATA (prod) and Parallel ATA (experimental) drivers" menu for libata
What about replacing "exists inside" into "uses" and adding info about the new menu instead?

Well, that's even a better idea :-) I wasn't that sure about what to do .. it's just that it could be misleading since the new (s/p)ata drivers are not living in the scsi low-level subsystem anymore, but got their own menu point.

Here's a different patch >:)

--- linux-2.6.20.old/drivers/ide/Kconfig 2007-03-18 00:05:11.000000000 +0100

+++ linux-2.6.20/drivers/ide/Kconfig 2007-03-18 01:23:51.000000000 +0100

@@ -103,8 +103,10 @@

---help---

There are two drivers for Serial ATA controllers.

- The main driver, "libata", exists inside the SCSI subsystem

- and supports most modern SATA controllers.

+ The main driver, "libata", uses the SCSI subsystem

+ and supports most modern SATA controllers. In order to use it

+ you may take a look at "Serial ATA (prod) and Parallel ATA

+ (experimental) drivers".

The IDE driver (which you are currently configuring) supports

a few first-generation SATA controllers.

---

Quoted 4 lines

Thanks,
Bart

regards,
Patrick

Bartlomiej Zolnierkiewicz

Applied

2007-03-23 23:47 UTC #3 lore raw

Re: [PATCH UPDATED][2] cosmetic adaption of drivers/ide/Kconfig concerning SATA

Quoted 31 lines · Patrick Ringl

Bartlomiej Zolnierkiewicz wrote:
Hello,
Quoted 28 lines · Patrick Ringl
Quoted 1 line
Hello,
Hi,
Quoted 10 lines
since especially Serial ATA has it's own menu point now, I guess we can change the description of the deprecated SATA driver as well, since the new libATA subsystem is not configured through a SCSI low-level driver anymore, but has it's own menu point.
The following patch is against 2.6.21-rc4:
drivers/ide/Kconfig line 106
Quoted 5 lines
drivers/ide/Kconfig +1 -1
@@ -103,7 +103,7 @@
  	---help---
  	  There are two drivers for Serial ATA controllers.
 
-	  The main driver, "libata", exists inside the SCSI subsystem
+	  The main driver, "libata", exists inside the ATA subsystem
Strictly speaking libata is not a separate subsystem (it still uses SCSI subsystem) and "ATA subsystem" may be misleading, since we now have:
* "ATA/ATAPI/MFM/RLL support" menu for drivers/ide
* "Serial ATA (prod) and Parallel ATA (experimental) drivers" menu for libata

Quoted 8 lines

Quoted 2 lines
What about replacing "exists inside" into "uses" and adding info about the new menu instead?
Well, that's even a better idea :-) I wasn't that sure about what to do .. it's just that it could be misleading since the new (s/p)ata drivers are not living in the scsi low-level subsystem anymore, but got their own menu point.
Here's a different patch >:)

applied

[ The patch was whitespace damaged and didn't apply et all
so I had to manually change the Kconfig to merge your change. ]

Thanks,
Bart

Patrick Ringl

author

2007-03-24 16:06 UTC #4 lore raw

Re: [PATCH UPDATED][2] cosmetic adaption of drivers/ide/Kconfig concerning SATA

Quoted 38 lines · Bartlomiej Zolnierkiewicz

Quoted 36 lines · Patrick Ringl
Bartlomiej Zolnierkiewicz wrote:
Hello,
Quoted 23 lines · Patrick Ringl
Quoted 3 lines
Hello,
Hi,
drivers/ide/Kconfig line 107
Quoted 13 lines
since especially Serial ATA has it's own menu point now, I guess we can change the description of the deprecated SATA driver as well, since the new libATA subsystem is not configured through a SCSI low-level driver anymore, but has it's own menu point.
The following patch is against 2.6.21-rc4:
drivers/ide/Kconfig +1 -1
@@ -103,7 +103,7 @@
  	---help---
  	  There are two drivers for Serial ATA controllers.
 
-	  The main driver, "libata", exists inside the SCSI subsystem
+	  The main driver, "libata", exists inside the ATA subsystem
 
Strictly speaking libata is not a separate subsystem (it still uses SCSI subsystem) and "ATA subsystem" may be misleading, since we now have:
Quoted 7 lines
* "ATA/ATAPI/MFM/RLL support" menu for drivers/ide
* "Serial ATA (prod) and Parallel ATA (experimental) drivers" menu for libata
What about replacing "exists inside" into "uses" and adding info about the new menu instead?
Well, that's even a better idea :-) I wasn't that sure about what to do .. it's just that it could be misleading since the new (s/p)ata drivers are not living in the scsi low-level subsystem anymore, but got their own menu point.

Quoted 8 lines

Quoted 2 lines
Here's a different patch >:)
applied
[ The patch was whitespace damaged and didn't apply et all
so I had to manually change the Kconfig to merge your change. ]

D'Oh .. Probably due to the fact that I copied it and did not attach it in plain/text.

Thanks

Quoted 4 lines

Thanks,
Bart

regards,
Patrick