tests/kms_chamelium: document capture audio buffer size constraints

PATCH In review Simon Ser 3 participants 4 messages May 17, 2019

lore

Share & tools

lore

Simon Ser

author

2019-05-17 10:27 UTC #0 lore raw

PATCH 1/1 tests/kms_chamelium: document capture audio buffer size constraints

Explain why we need to choose a big enough buffer for audio capture.

Signed-off-by Simon Ser <[email protected]>

---
 tests/kms_chamelium.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

tests/kms_chamelium.c +8 -1

index c8b6b22d7b4a..4db604d32cae 100644
@@ -924,7 +924,14 @@ do_test_display_audio(data_t *data, struct chamelium_port *port,
 
 	/* Needs to be a multiple of 128, because that's the number of samples
 	 * we get per channel each time we receive an audio page from the
-	 * Chamelium device. */
+	 * Chamelium device.
+	 *
+	 * Additionally, this value needs to be high enough to guarantee we
+	 * capture a full period of each sine we generate. If we capture 2048
+	 * samples at a 192KHz sampling rate, we get a full period for a >94Hz
+	 * sines. For lower sampling rates, the capture duration will be
+	 * longer.
+	 */
 	channel_len = CAPTURE_SAMPLES;
 	channel = malloc(sizeof(double) * channel_len);

--
2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-05-17 11:20 UTC #1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium: document capture audio buffer size constraints

== Series Details ==

Series: tests/kms_chamelium: document capture audio buffer size constraints
URL : https://patchwork.freedesktop.org/series/60770/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6092 -> IGTPW_2996
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/60770/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2996 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html

* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [PASS][3] -> [INCOMPLETE][4] ([fdo#108602] / [fdo#108744])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [INCOMPLETE][5] ([fdo#107718]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/fi-blb-e6850/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_guc:
- fi-apl-guc: [INCOMPLETE][7] ([fdo#103927]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/fi-apl-guc/igt@i915_selftest@live_guc.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/fi-apl-guc/igt@i915_selftest@live_guc.html

* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: [FAIL][9] ([fdo#110623]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/fi-apl-guc/igt@i915_selftest@live_hangcheck.html

[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[fdo#110623]: https://bugs.freedesktop.org/show_bug.cgi?id=110623

Participating hosts (54 -> 46)
------------------------------

Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* IGT: IGT_4994 -> IGTPW_2996

CI_DRM_6092: aff6826a227752600fca7e1f66adfbf51606d51e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2996: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/
IGT_4994: 555019f862c35f1619627761d6da21385be40920 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Martin Peres

Reviewed-by on v1 1/1

2019-05-17 11:52 UTC #2 lore raw

In reply to Simon Ser

Quoted 3 lines · Simon Ser

Explain why we need to choose a big enough buffer for audio capture.
Signed-off-by Simon Ser <[email protected]>

Reviewed-by Martin Peres <[email protected]>

Quoted 25 lines

---
 tests/kms_chamelium.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

tests/kms_chamelium.c +8 -2

index c8b6b22d7b4a..4db604d32cae 100644
@@ -924,7 +924,14 @@ do_test_display_audio(data_t *data, struct chamelium_port *port,
 
 	/* Needs to be a multiple of 128, because that's the number of samples
 	 * we get per channel each time we receive an audio page from the
-	 * Chamelium device. */
+	 * Chamelium device.
+	 *
+	 * Additionally, this value needs to be high enough to guarantee we
+	 * capture a full period of each sine we generate. If we capture 2048
+	 * samples at a 192KHz sampling rate, we get a full period for a >94Hz
+	 * sines. For lower sampling rates, the capture duration will be
+	 * longer.
+	 */
 	channel_len = CAPTURE_SAMPLES;
 	channel = malloc(sizeof(double) * channel_len);
 
--

Quoted 2 lines

2.21.0

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-05-17 14:43 UTC #3 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_chamelium: document capture audio buffer size constraints

In reply to Simon Ser

== Series Details ==

Series: tests/kms_chamelium: document capture audio buffer size constraints
URL : https://patchwork.freedesktop.org/series/60770/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6092_full -> IGTPW_2996_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/60770/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2996_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: [PASS][1] -> [FAIL][2] ([fdo#108686])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb6/igt@[email protected]
- shard-hsw: [PASS][3] -> [INCOMPLETE][4] ([fdo#103540])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-hsw4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-hsw1/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size:
- shard-snb: [PASS][5] -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-snb7/igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-snb2/igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-iclb: [PASS][7] -> [FAIL][8] ([fdo#103167]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109441]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb3/igt@kms_psr@psr2_sprite_blt.html

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-apl7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-apl6/igt@[email protected]

* igt@perf@short-reads:
- shard-kbl: [PASS][13] -> [FAIL][14] ([fdo#103183])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-kbl2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-kbl1/igt@[email protected]

#### Possible fixes ####

* igt@gem_eio@in-flight-suspend:
- shard-kbl: [FAIL][15] ([fdo#110667]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-kbl3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-kbl2/igt@[email protected]
- shard-glk: [FAIL][17] ([fdo#110667]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-glk9/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-glk7/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][19] ([fdo#108566]) -> [PASS][20] +5 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-apl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-apl5/igt@[email protected]

* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-hsw: [DMESG-WARN][21] ([fdo#102614]) -> [PASS][22] +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-hsw5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-hsw1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: [FAIL][23] ([fdo#103167]) -> [PASS][24] +6 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [FAIL][25] ([fdo#103167] / [fdo#110378]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb4/igt@[email protected]

* igt@kms_mmap_write_crc@main:
- shard-hsw: [DMESG-FAIL][27] ([fdo#102614]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-hsw5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-hsw1/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][29] ([fdo#103166]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb8/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][31] ([fdo#109441]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_sysfs_edid_timing:
- shard-iclb: [FAIL][33] ([fdo#100047]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb3/igt@kms_sysfs_edid_timing.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb6/igt@kms_sysfs_edid_timing.html

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-kbl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-kbl2/igt@[email protected]

* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: [FAIL][37] ([fdo#105010]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-apl8/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-apl1/igt@[email protected]

#### Warnings ####

* igt@gem_mmap_gtt@forked-big-copy-xy:
- shard-iclb: [TIMEOUT][39] ([fdo#109673]) -> [INCOMPLETE][40] ([fdo#107713] / [fdo#109100]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6092/shard-iclb2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2996/shard-iclb1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (10 -> 6)
------------------------------

Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005

Build changes
-------------

* IGT: IGT_4994 -> IGTPW_2996
* Piglit: piglit_4509 -> None

== Logs ==