Skip to contentSkip to conversation

ROTALIGN Alpha support

U-Boot-Users Krzysztof Helt 3 participants 3 messages Feb 5, 2007 – Feb 6, 2007

lore
Share & tools
lore
#0 lore raw

Hello,

This patch adds support for Pruftechnik's ROTALIGN Alpha board.

The patch allows to upload and flash Linux, then boots it.

The second flash bank and SMC9196 chip do not work yet.

Regards,
Krzysztof Helt

----------------------------------------------------
Nominowany do Oscara za najlepsz? rol? m?sk? Will Smith
jako samotny ojciec nie poddaj?cy si? losowi.
W POGONI ZA SZCZ??CIEM - w kinach od 9 lutego!
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fwpogoni.html&sid=1009
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ra-uboot2.diff.gz
Type: application/x-gzip
Size: 9652 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070205/9d5ae7bc/attachment.bin

#1 lore raw
Quoted 7 lines · Krzysztof Helt

Hello,

This patch adds support for Pruftechnik's ROTALIGN Alpha board.

The patch allows to upload and flash Linux, then boots it.

The second flash bank and SMC9196 chip do not work yet.

Can you please repost your patch in-line (instead of gzipped attachment). It is far easier to comment on an inline patch.

Thanks,
g.

Signature · 4 lines
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195
#2 lore raw
In reply to Krzysztof Helt
Quoted 6 lines · In message <[email protected]> you wrote:

This patch adds support for Pruftechnik's ROTALIGN Alpha board.

The patch allows to upload and flash Linux, then boots it.

The second flash bank and SMC9196 chip do not work yet.

* Please clean up the Coding style violations (C++ comments, trailing white space, indentation not by TAB, ...).

* Please remove dead code like here:

	--- u-boot-1.1.6/board/raalpha/config.mk        1970-01-01
	01:00:00.000000000 +0100
	+++ u-boot-1.1.6.ra/board/raalpha/config.mk     2006-11-02
	15:15:01.000000000 +0100
	@@ -0,0 +1,3 @@
	+#TEXT_BASE = 0xa1700000
	+TEXT_BASE = 0xa3080000
	+#TEXT_BASE = 0

* Please explain why you think this is necessary:

+int board_late_init(void)
+{
+ setenv("stdout", "serial");
+ setenv("stderr", "serial");
+ return 0;
+}

Then resubmit.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Landru! Guide us!
	-- A Beta 3-oid, "The Return of the Archons", stardate 3157.4